Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2013-01-14 Thread Stephan Bergmann
On 01/14/2013 12:42 AM, Marc-André Laverdière wrote: Quick question: is this code security-sensitive at all? No. sal/typesconfig/typesconfig.c turns out to be dead code; I'll removed it. Stephan ___ LibreOffice mailing list

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2013-01-13 Thread Marc-André Laverdière
Quick question: is this code security-sensitive at all? I know that there has been some security issues related to one compiler (Microsoft's) that was optimizing away the memset in some cases. So the suggested workaround was a loop. Reference: Writing Secure Code. The other question is: Are we

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2013-01-08 Thread Stephan Bergmann
On 12/24/2012 06:44 PM, Julien Nabet wrote: On 24/12/2012 18:29, Norbert Thiebaud wrote: On Mon, Dec 24, 2012 at 8:45 AM, julien2412serval2...@yahoo.fr wrote: By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a

[PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git a/sal/typesconfig/typesconfig.c b/sal/typesconfig/typesconfig.c index 473f07a..ef52c5f

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Riccardo Magliocchetti
Il 24/12/2012 15:45, julien2412 ha scritto: Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git a/sal/typesconfig/typesconfig.c

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Riccardo Magliocchetti wrote Il 24/12/2012 15:45, julien2412 ha scritto: diff --git a/sal/typesconfig/typesconfig.c b/sal/typesconfig/typesconfig.c index 473f07a..ef52c5f 100644 --- a/sal/typesconfig/typesconfig.c +++ b/sal/typesconfig/typesconfig.c @@ -262,11 +262,9 @@ int GetAlignment(

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Norbert Thiebaud
On Mon, Dec 24, 2012 at 8:45 AM, julien2412 serval2...@yahoo.fr wrote: Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Julien Nabet
On 24/12/2012 18:29, Norbert Thiebaud wrote: On Mon, Dec 24, 2012 at 8:45 AM, julien2412serval2...@yahoo.fr wrote: Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a