Hi, I have submitted a patch for review:
https://gerrit.libreoffice.org/2903 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/2903/1 Use initialization list for ODbTypeWizDialogSetup Some members got initialized by assignment instead of initialization list without need. A refactoring artifact most likely. Change-Id: I6b1d4036a24bd26443ce7c6e44e51d08b8b83b20 --- M dbaccess/source/ui/dlg/dbwizsetup.cxx 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx index cb53dfd..d5f2973 100644 --- a/dbaccess/source/ui/dlg/dbwizsetup.cxx +++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx @@ -133,27 +133,27 @@ , m_bApplied(sal_False) , m_bUIEnabled( sal_True ) , m_bIsConnectable( sal_False) - , m_sRM_IntroText(ModuleRes(STR_PAGETITLE_INTROPAGE)) - , m_sRM_dBaseText(ModuleRes(STR_PAGETITLE_DBASE)) - , m_sRM_TextText(ModuleRes(STR_PAGETITLE_TEXT)) - , m_sRM_MSAccessText(ModuleRes(STR_PAGETITLE_MSACCESS)) - , m_sRM_LDAPText(ModuleRes(STR_PAGETITLE_LDAP)) - , m_sRM_ADOText(ModuleRes(STR_PAGETITLE_ADO)) - , m_sRM_JDBCText(ModuleRes(STR_PAGETITLE_JDBC)) - , m_sRM_MySQLNativePageTitle(ModuleRes(STR_PAGETITLE_MYSQL_NATIVE)) + , m_sRM_IntroText( ModuleRes( STR_PAGETITLE_INTROPAGE ) ) + , m_sRM_dBaseText( ModuleRes( STR_PAGETITLE_DBASE ) ) + , m_sRM_TextText( ModuleRes( STR_PAGETITLE_TEXT ) ) + , m_sRM_MSAccessText( ModuleRes( STR_PAGETITLE_MSACCESS ) ) + , m_sRM_LDAPText( ModuleRes( STR_PAGETITLE_LDAP ) ) + , m_sRM_ADOText( ModuleRes( STR_PAGETITLE_ADO ) ) + , m_sRM_JDBCText( ModuleRes( STR_PAGETITLE_JDBC ) ) + , m_sRM_MySQLNativePageTitle( ModuleRes( STR_PAGETITLE_MYSQL_NATIVE ) ) + , m_sRM_OracleText( ModuleRes( STR_PAGETITLE_ORACLE ) ) + , m_sRM_MySQLText( ModuleRes( STR_PAGETITLE_MYSQL ) ) + , m_sRM_ODBCText( ModuleRes( STR_PAGETITLE_ODBC ) ) + , m_sRM_SpreadSheetText( ModuleRes( STR_PAGETITLE_SPREADSHEET ) ) + , m_sRM_AuthentificationText( ModuleRes( STR_PAGETITLE_AUTHENTIFICATION ) ) + , m_sRM_FinalText( ModuleRes( STR_PAGETITLE_FINAL ) ) + , m_sWorkPath( SvtPathOptions().GetWorkPath() ) , m_pGeneralPage( NULL ) - , m_pMySQLIntroPage(NULL) + , m_pMySQLIntroPage( NULL ) , m_pCollection( NULL ) { DBG_CTOR(ODbTypeWizDialogSetup,NULL); // no local resources needed anymore - m_sRM_MySQLText = String(ModuleRes(STR_PAGETITLE_MYSQL)); - m_sRM_OracleText = String(ModuleRes(STR_PAGETITLE_ORACLE)); - m_sRM_ODBCText = String(ModuleRes(STR_PAGETITLE_ODBC)); - m_sRM_SpreadSheetText = String(ModuleRes(STR_PAGETITLE_SPREADSHEET)); - m_sRM_AuthentificationText = String(ModuleRes(STR_PAGETITLE_AUTHENTIFICATION)); - m_sRM_FinalText = String(ModuleRes(STR_PAGETITLE_FINAL)); - m_sWorkPath = SvtPathOptions().GetWorkPath(); pFinalPage = NULL; // extract the datasource type collection from the item set DbuTypeCollectionItem* pCollectionItem = PTR_CAST(DbuTypeCollectionItem, _pItems->GetItem(DSID_TYPECOLLECTION)); -- To view, visit https://gerrit.libreoffice.org/2903 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b1d4036a24bd26443ce7c6e44e51d08b8b83b20 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mathias Hasselmann <math...@openismus.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice