Hi, I have submitted a patch for review:
https://gerrit.libreoffice.org/4001 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/4001/1 Use the new type-checking Reference constructor to reduce code noise Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 --- M basctl/source/basicide/baside3.cxx M basctl/source/basicide/moduldl2.cxx M basic/source/basmgr/basicmanagerrepository.cxx M basic/source/uno/dlgcont.cxx M basic/source/uno/namecont.cxx M comphelper/source/processfactory/processfactory.cxx A compilerplugins/clang/store/referencecasting.cxx A compilerplugins/clang/store/referencecasting.hxx M cui/source/dialogs/hangulhanjadlg.cxx M cui/source/options/optdict.cxx M dbaccess/source/core/dataaccess/ModelImpl.cxx M dbaccess/source/core/dataaccess/connection.cxx M dbaccess/source/core/dataaccess/datasource.cxx M dbaccess/source/core/dataaccess/documentdefinition.cxx M dbaccess/source/core/recovery/subcomponentloader.cxx M dbaccess/source/ext/macromigration/migrationengine.cxx M dbaccess/source/ui/app/subcomponentmanager.cxx M dbaccess/source/ui/browser/exsrcbrw.cxx M dbaccess/source/ui/dlg/dbwizsetup.cxx M desktop/source/app/app.cxx M extensions/source/abpilot/datasourcehandling.cxx M extensions/source/bibliography/datman.cxx M extensions/source/propctrlr/formcomponenthandler.cxx M extensions/source/propctrlr/formgeometryhandler.cxx M extensions/source/propctrlr/formlinkdialog.cxx M filter/source/msfilter/svdfppt.cxx M filter/source/svg/svgexport.cxx M filter/source/svg/svgwriter.cxx M filter/source/xsltdialog/xmlfiltertestdialog.cxx M forms/source/component/FormattedField.cxx M forms/source/component/navigationbar.cxx M forms/source/component/scrollbar.cxx M forms/source/component/spinbutton.cxx M forms/source/misc/InterfaceContainer.cxx M forms/source/xforms/model.cxx M forms/source/xforms/model_ui.cxx M forms/source/xforms/submission.cxx M forms/source/xforms/submission/replace.cxx M framework/source/fwe/helper/actiontriggerhelper.cxx M framework/source/fwe/helper/documentundoguard.cxx M framework/source/fwe/xml/menuconfiguration.cxx M framework/source/fwe/xml/statusbarconfiguration.cxx M framework/source/layoutmanager/layoutmanager.cxx M framework/source/services/backingwindow.cxx M framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx M framework/source/uiconfiguration/uiconfigurationmanager.cxx M framework/source/uielement/toolbarmanager.cxx M framework/source/uifactory/menubarfactory.cxx M framework/source/uifactory/uielementfactorymanager.cxx M framework/source/xml/imagesconfiguration.cxx M oox/source/drawingml/chart/converterbase.cxx M oox/source/drawingml/textfield.cxx M oox/source/drawingml/textparagraph.cxx M oox/source/drawingml/textrun.cxx M oox/source/export/drawingml.cxx M oox/source/export/shapes.cxx M oox/source/helper/containerhelper.cxx M package/source/manifest/ManifestWriter.cxx M sc/source/filter/excel/xecontent.cxx M sc/source/filter/excel/xichart.cxx M sc/source/filter/oox/stylesbuffer.cxx M sc/source/filter/oox/viewsettings.cxx M sc/source/filter/oox/workbookhelper.cxx M sc/source/filter/oox/worksheetbuffer.cxx M scripting/source/dlgprov/dlgprov.cxx M scripting/source/provider/BrowseNodeFactoryImpl.cxx M scripting/source/stringresource/stringresource.cxx M sd/source/core/CustomAnimationEffect.cxx M sd/source/core/sdpage2.cxx M sd/source/core/stlpool.cxx M sd/source/filter/eppt/pptexanimations.cxx M sd/source/ui/animations/CustomAnimationPane.cxx M sd/source/ui/framework/factories/BasicViewFactory.cxx M sd/source/ui/view/ViewShellBase.cxx M sdext/source/minimizer/graphiccollector.cxx M sdext/source/presenter/PresenterViewFactory.cxx M sfx2/source/appl/newhelp.cxx M sfx2/source/dialog/taskpane.cxx M sfx2/source/view/frame2.cxx M sfx2/source/view/viewfrm.cxx M svtools/source/contnr/templwin.cxx M svx/source/dialog/rubydialog.cxx M svx/source/form/filtnav.cxx M svx/source/form/fmobj.cxx M svx/source/form/fmpgeimp.cxx M svx/source/form/fmshimp.cxx M svx/source/form/fmtools.cxx M svx/source/form/fmundo.cxx M svx/source/form/fmvwimp.cxx M svx/source/form/formcontroller.cxx M svx/source/form/formcontrolling.cxx M svx/source/form/navigatortree.cxx M svx/source/form/navigatortreemodel.cxx M sw/source/filter/xml/xmlexp.cxx M sw/source/filter/xml/xmltbli.cxx M sw/source/ui/dbui/dbmgr.cxx M sw/source/ui/dbui/dbtree.cxx M toolkit/source/controls/controlmodelcontainerbase.cxx M toolkit/source/controls/grid/defaultgridcolumnmodel.cxx M toolkit/source/controls/tabpagecontainer.cxx M ucb/source/cacher/dynamicresultsetwrapper.cxx M ucb/source/ucp/file/bc.cxx M ucb/source/ucp/file/filglob.cxx M ucb/source/ucp/ftp/ftpcontent.cxx M unotools/source/config/configitem.cxx M unoxml/source/dom/attr.cxx M unoxml/source/dom/characterdata.cxx M unoxml/source/dom/document.cxx M unoxml/source/dom/element.cxx M unoxml/source/dom/node.cxx M unoxml/source/dom/node.hxx M unoxml/source/dom/saxbuilder.cxx M xmloff/source/core/DomBuilderContext.cxx M xmloff/source/core/DomExport.cxx M xmloff/source/script/XMLEventExport.cxx M xmloff/source/style/styleexp.cxx M xmloff/source/text/XMLAutoTextEventExport.cxx M xmloff/source/text/XMLTextMarkImportContext.cxx M xmloff/source/text/txtimp.cxx M xmloff/source/text/txtparae.cxx M xmloff/source/text/txtparai.cxx M xmloff/source/xforms/xformsexport.cxx 122 files changed, 549 insertions(+), 506 deletions(-) -- To view, visit https://gerrit.libreoffice.org/4001 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin <noelgran...@gmail.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice