Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread David Ostrovsky
://lists.freedesktop.org/mailman/listinfo/libreoffice From 87a43003980eac899c5ec07832abefc3e01d3855 Mon Sep 17 00:00:00 2001 From: David Ostrovsky david.ostrov...@gmx.de Date: Thu, 7 Jun 2012 23:59:04 +0200 Subject: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter Change-Id

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Thomas Arnhold
Arg sorry for this... On Thu, 07 Jun 2012 18:35:05 -0500, Daniel Bankston wrote: On 06/07/2012 05:05 PM, David Ostrovsky wrote: Hi, this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter. I have no idea, why I'm getting it now, git blame says that the last

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Daniel Bankston
On 06/08/2012 01:14 AM, David Ostrovsky wrote: Hi Daniel, trying to send it to once time again. Regards David Looks good to me, but please let someone else concur (preferably one of the calc gurus). Respectfully, Daniel Bankston ___ LibreOffice

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Daniel Bankston
On 06/08/2012 01:17 AM, Thomas Arnhold wrote: Arg sorry for this... Thomas, I don't think it's that big of a worry. Although, perhaps it would have been better to submit the revised version of the patch to the mailing list before pushing. David caught it, though, so no worries. This is

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Stephan Bergmann
On 06/08/2012 12:05 AM, David Ostrovsky wrote: this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter. I have no idea, why I'm getting it now, git blame says that the last changes in this file were years ago ... Oops, sorry, only discovered this thread now that I

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Eike Rathke
Hi Daniel, On Friday, 2012-06-08 01:32:26 -0500, Daniel Bankston wrote: Looks good to me, but please let someone else concur (preferably one of the calc gurus). All fine, a leftover from dead code removal. Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n

[PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-07 Thread David Ostrovsky
Hi, this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter. I have no idea, why I'm getting it now, git blame says that the last changes in this file were years ago ... Regards David .0001-WaE-in-ScTabViewShell-UpdateNumberFormatter.patch.swp Description:

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-07 Thread Daniel Bankston
On 06/07/2012 05:05 PM, David Ostrovsky wrote: Hi, this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter. I have no idea, why I'm getting it now, git blame says that the last changes in this file were years ago ... Regards David Hi, David, I can't open