Re: [PATCH] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold
Hi Oliver, right. But I wanted to remove the macro only. There were 1663 cases like foo = [::rtl::]OUString("..") in the source before my commit. Now there are 2885. Huge increase, I know, but the other ones could be improved, too. Maybe with some script foo. Regardless how this is done it wi

Re: [PATCH] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello since you have - -aMap[0] = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("YES")); - -aMap[1] = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("NO")); +aMap[0] = ::rtl::OUString("YES"); +aMap[1] = ::rtl::OUString("NO"); in the same

[PATCH] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2832 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/2832/1 automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings Done with a perl regex: s/OUString\s*\(\s