Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-31 Thread Jan Holesovsky
Hi Muhammad, Muhammad Haggag píše v Čt 31. 05. 2012 v 21:46 +0200: > I have confirmed that the word counting logic somehow focuses on the > cursor, and I'll either fix that or follow a model similar to the word > count dialog where we update in response to editing actions only. > > Unfortunately

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-31 Thread Muhammad Haggag
I have confirmed that the word counting logic somehow focuses on the cursor, and I'll either fix that or follow a model similar to the word count dialog where we update in response to editing actions only. Unfortunately I'm currently on the road for a couple of days. I'll continue working on it on

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-31 Thread Ivan Timofeev
Another nasty side-effect: https://bugs.freedesktop.org/show_bug.cgi?id=50540 Who could have thought! ( *pensive* I hereby confirm that my claims like "This patch is safe" are not valid anymore.) Regards, Ivan ___ LibreOffice mailing list LibreOffic

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-27 Thread Ivan Timofeev
On 27.05.2012 12:28, Muhammad Haggag wrote: Can you share the bug once you open it? Sure! https://bugs.freedesktop.org/show_bug.cgi?id=50386 Cheers, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mai

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-27 Thread Muhammad Haggag
On Sat, May 26, 2012 at 9:27 PM, Ivan Timofeev wrote: > On 26.05.2012 22:06, Ivan Timofeev wrote: >> >> this patch makes scrolling in writer impossible :( it always brings the >> view back to the cursor > > > Oops, wait. That happens only if a document contains the Page Count field > (Insert -> Fi

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-26 Thread Ivan Timofeev
On 26.05.2012 22:06, Ivan Timofeev wrote: this patch makes scrolling in writer impossible :( it always brings the view back to the cursor Oops, wait. That happens only if a document contains the Page Count field (Insert -> Fields -> Page Count). WTF? Why it causes a recount every second?...

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-26 Thread Ivan Timofeev
Hi all, this patch makes scrolling in writer impossible :( it always brings the view back to the cursor (btw so does Tools -> Word Count, but only once it is invoked). It looks like the cause is the following lines: @@ -1197,6 +1198,25 @@ void SwView::StateStatusLine(SfxItemSet &rSet)

Re: [Libreoffice-ux-advise] [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-24 Thread Muhammad Haggag
Thanks for the help! I created a followup patch that makes the strings as resources: https://bugs.freedesktop.org/attachment.cgi?id=62063 Review: https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=34772&attachment=62063 Regards, --Muhammad ___

Re: [Libreoffice-ux-advise] [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-23 Thread Petr Mladek
Michael Meeks píše v Út 22. 05. 2012 v 17:57 +0100: > Normally for this a pseudo-printf format would be used so use a % or $ > magic in the string to be replaced. For an example of that: > > String STR_RECOVER_QUERY > { > Text [ en-US ] = "Should the file \"$1\" be restored?" ; > }; You

Re: [Libreoffice-ux-advise] [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-22 Thread Michael Meeks
On Tue, 2012-05-22 at 18:36 +0300, Muhammad Haggag wrote: > a glance what the numbers mean. It looks like this: > http://imgur.com/3WqVD Wow - glad you got it working nicely :-) Thanks for that ... > Also, I'm not sure how localizable string literals are handled in the > code base. Does

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-22 Thread Muhammad Haggag
On Tue, May 22, 2012 at 6:13 PM, Regina Henschel wrote: > Hi Muhammad, >[...] > I don't know about "standard 'large' documents" for testing. You can use the > document 'part1' of the ODF specification, which has 864 pages. > http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.odt

Re: [PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-22 Thread Regina Henschel
Hi Muhammad, Muhammad Haggag schrieb: Hello. [..] Verification: == I tested with small documents (to the tune of 30 pages, ~3500 words). I'd like to try it out on a large/huge document to make sure there's no performance impact. Are there any standard "large" documents used for LO per

[PATCH] fdo#34772 Word count / statistics in the status bar

2012-05-22 Thread Muhammad Haggag
Hello. (Ux folks, please advise on the "UX/Localization" section below). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34772 Patch: = https://bugs.freedesktop.org/attachment.cgi?id=61962 Patch review: === https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=34772&atta