Hi, Cao,
Just checked your patch (Change-Id:
I57d1245db650d12e6b2c05baece379038b673689) merged with:
Version: 4.1.0.0.alpha0+
Build ID: 0b897dd455968862e348de2c5e1c57d4d73640b
This patch indeed fixes all of the problems mentioned in fdo#47018,
including the crash.
Brilliant. Thanks a lot, Cao!
Hi Stephan,
In fact a more proper solution is to write everything to SvStream and
restores from it in pasting ( which is currently not completely
implemented).
I've finish the attributes loading from SvStream here
https://gerrit.libreoffice.org/#/c/3369/.
However, in numpages.cxx the tab picking
Hi Stephan,
Thanks for taking the time to test it :-)
I've made a new patch that fixes the crash and the copy/paste action.
You can try it here
https://gerrit.libreoffice.org/3352
Best,
Cao Cuong Ngo
On 04/09/2013 05:05 PM, Stephan van den Akker wrote:
Just tested this patch, applied to:
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3285
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3285/1
fdo#47018 fix Impress crash on modifying bullet
Add verifying of numbering rule to avoid invalidated attribute
Building LO with this patch now. I will report my findings asap.
2013/4/9 Cao Cuong Ngo (via Code Review) ger...@gerrit.libreoffice.org
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3285
To pull it, you can do:
git pull
Just tested this patch, applied to:
Version: 4.1.0.0.alpha0+
Build ID: 2705fc72df2058332773b5cb04a6b4d207f5e39
The proposed patch will prevent the crash, but it seems that the underlying
problem is not solved by this:
The bullets do not survive the copy / paste action of the EditEngineFormat:
