Re: [PUSHED] Create OUString and OString number(*) methods.

2013-01-22 Thread Lubos Lunak
On Monday 21 of January 2013, Stephan Bergmann wrote: > On 01/21/2013 06:05 PM, Lubos Lunak wrote: > > On Monday 21 of January 2013, Stephan Bergmann wrote: > >> While the gotcha of printing a large unsigned value as a negative value > >> thanks to calling rtl_ustr_valueOfInt64 internally can be a

Re: [PUSHED] Create OUString and OString number(*) methods.

2013-01-21 Thread Stephan Bergmann
On 01/21/2013 06:05 PM, Lubos Lunak wrote: On Monday 21 of January 2013, Stephan Bergmann wrote: On 01/18/2013 05:20 PM, Luboš Luňák (via Code Review) wrote: assert( ll <= SAL_MAX_INT64 ); // valueOfInt64 may not be able to handle the highest bit in the various number() function definitions m

Re: [PUSHED] Create OUString and OString number(*) methods.

2013-01-21 Thread Lubos Lunak
On Monday 21 of January 2013, Stephan Bergmann wrote: > On 01/18/2013 05:20 PM, Luboš Luňák (via Code Review) wrote: > > https://gerrit.libreoffice.org/1625 > > I must admit that I didn't review the later revisions of that patch > while in progress at gerrit, That's actually from me afterwar

Re: [PUSHED] Create OUString and OString number(*) methods.

2013-01-21 Thread Stephan Bergmann
On 01/18/2013 05:20 PM, Luboš Luňák (via Code Review) wrote: Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1625 I must admit that I didn't review the later revisions of that patch while in prog

[PUSHED] Create OUString and OString number(*) methods.

2013-01-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1625 -- To view, visit https://gerrit.libreoffice.org/1625 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer