make OUString::copy() clip (was: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import)

2012-08-01 Thread Eike Rathke
Hi Stephan, On Wednesday, 2012-08-01 18:17:12 +0200, Stephan Bergmann wrote: > make rtl::OUString::copy(beginIndex, count) clip to [0..length)? > yeah, why not (then again, -1's sentinel nature, cf. indexOf, might > mean that silent clipping of beginIndex=-1 to beginIndex=0 is > unfortunate) We

Re: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import

2012-08-01 Thread Stephan Bergmann
On 08/01/2012 03:29 PM, Michael Meeks wrote: That aside - I've never been a big fan of the "crash on bad input" mode of OUString::copy() that seems incredibly lame to me. Is there any convincing performance reason that anyone can work out for not just returning an empty string in these ca

[PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import

2012-08-01 Thread Michael Meeks
On Wed, 2012-08-01 at 14:14 +0200, Eike Rathke wrote: > Please review and cherry-pick to 3-6 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=21cb8210c74e52896ce7fb063f1578b13672f4bd > that fixes https://bugs.freedesktop.org/show_bug.cgi?id=53012 Done. > In case we do 3.6.0.5rc