[Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Jesso Murugan
Hi, There were some repeated calls in two for loops in ExpandColumnSelection function in swnewtable.cxx so I combined the two loops so that the same calls need not be made again. I debugged and tested after making the changes, everything works as expected. - Jesso Clarence 0001-Improved-for-lo

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Matteo Casalin
Hi all, just a minor hint from my side: in the original code nBox was incremented only when "pBox == rBoxes[nBox]", while in the new one it happens unconditionally. I don't know if this could be an issue or not. To preserve the original behaviour a single conditional if ( nBox < nBoxCnt

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Jesso Murugan
Hi Matteo, >just a minor hint from my side: in the original code nBox was >incremented only when "pBox == rBoxes[nBox]", while in the >new one it happens unconditionally. Sorry for over looking that. > I don't know if this could be an issue or not. I tested by re building and putti

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Matteo Casalin
Hi Jesso, -- Jesso Murugan wrote: (09/07/2012 16:33) > Hi Matteo, > > >just a minor hint from my side: in the original code nBox was > >incremented only when "pBox == rBoxes[nBox]", while in the > >new one it happens unconditionally. >

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-10 Thread Jesso Murugan
Hi, I've submitted a new patch with Matteo's suggestion to Gerrit directly. So discard this patch. - Jesso Clarence ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice