On Sun, 2012-04-29 at 16:16 +0800, Elton Chung wrote:
> Hi there,
> This patch removes 1 unused method.
Looks good to me, pushed now, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailm
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed now, thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedeskt
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good, pushed. Thanks for this.
It bothers me a little that there was a addListener and a removeListener
where the addListener is used while removeListener is unused. It
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good to me, pushed. Thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedes
On Tue, 2012-04-24 at 07:21 +0100, Vicente Rafael Estévez Vacas wrote:
> Did I correct it and send it back to?
No need, fixed now.
> Yeah right, I will confirm the terms of license LGPLv3 + / MPL +
> combination.
Great, thanks.
C.
___
LibreOffice m
ation.
Sorry for my English.
De: Caolán McNamara
Para: Vicente Rafael Estévez Vacas
CC: "libreoffice@lists.freedesktop.org"
Enviado: Martes 24 de abril de 2012 0:22
Asunto: Re: [PUSHED] PATCH: Remove unused code from editing
On Mon, 2012-04-23
On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote:
> Asunto: PATCH: Remove unused code from editing
Basically good. Though you need to build after your make your changes to
pick up that there's a small mixup between the unused
sdr::contact::ViewObjectContactOfUnoControl::isCon
Pushed. Thank you!
On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote:
Hello,
These is the patch that I've created.
Licence: made available under the MPL/LGPLv3+
Ferran Vidal
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://
Thank you!
On 04/23/2012 02:06 AM, Santiago Martinez wrote:
This patch removes unused code as listed in unusedcode.easy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote:
> Hello,
> These is the patch that I've created.
Looks good, pushed, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mai
On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed. Thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.o
On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
pushed, thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/
On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listin
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Yup, pushed now. Well, actually Julien removed the same code and got in
first.
C.
___
LibreOffice mailing list
LibreOffice@lists.
Pushed. Thank you!
On 04/05/2012 12:10 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinf
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote:
> Hi there,
>
> removed unused methods
pushed, thanks for these
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Wed, 2012-03-28 at 21:51 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good, pushed now, thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesk
On Wed, 2012-03-28 at 21:31 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Look good, pushed now.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/lis
> FWIW, if a class has only one constructor and that constructor is unused
> then it indicates that the whole class (except perhaps for any static
> methods it might have) should be possible to be removed.
Sorry, I'll think more next time.
Petr
___
LibreO
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote:
> Hi there,
>
> yet another remove unused code patch.
Pushed now, thanks for this.
FWIW, if a class has only one constructor and that constructor is unused
then it indicates that the whole class (except perhaps for any static
methods it might
On Tue, 2012-03-27 at 21:20 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.o
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote:
> Hi there,
>
> another bits of unused code removed.
looks good, pushed now, thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote:
> Hi there,
>
> removed some code from oox.
Pushed, looks good. I suspect that this will have a bit of a cascade
effect and a pile more stuff will become available for removal on the
next run.
C.
__
On Sun, 2012-03-25 at 18:29 +0200, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, hopefully nothing is used there under windows, but if it is
we'll know soon enough :-), pushed.
C.
___
LibreOffice mai
On Sat, 2012-03-24 at 01:03 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
great, pushed now, thanks.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Fri, 2012-03-23 at 22:07 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed now, thanks.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/ma
On Fri, 2012-03-23 at 21:42 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
looks good, pushed now, thanks for that.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedeskto
On Tue, 2012-03-20 at 21:26 +0100, Chr. Rossmanith wrote:
> A PresenterAnimation could be instantiated here
>
> ModeChangeAnimation (
> const ::boost::shared_ptr& rpSprite,
> const Reference& rxCanvas)
> : PresenterAnimation (0, 1000, 20),
>mpSprite(rpSp
Am 20.03.2012 15:56, schrieb Caolán McNamara:
On Tue, 2012-03-20 at 13:54 +, Caolán McNamara wrote:
Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator
ctor is never called, and its the only constructor, so one is never
instantiated, so you can remove the whole thing wit
On Tue, 2012-03-20 at 15:07 +, Caolán McNamara wrote:
> I've a shed full of stuff I can't throw out just in case some day we
> need it. Not that removing stuff from sdext will give me more space in
> my shed I suppose.
:-) I have a similar shed - I can't get into it either ;-) but I r
On Tue, 2012-03-20 at 15:24 +0100, Chr. Rossmanith wrote:
> At least it doesn't change the position of mxSprite. Only the cpu is a
> little less idle :-) Then I'll continue to remove maTransform? Or
> should it be kept for future use?
I'm not a fan of "some day we'll use it", ditch it if it do
On Tue, 2012-03-20 at 13:54 +, Caolán McNamara wrote:
> Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator
> ctor is never called, and its the only constructor, so one is never
> instantiated, so you can remove the whole thing without loss of
> functionality.
Whoops, its
Hi,
Probably the private variable maTransform can be removed as well: it is
initialized with the identity transform and never changed afterwards.
Does that suggest that the actual call to
mxSprite->transform(maTransform) is actually a no-op ?
At least it doesn't change the position of mxSprite.
On Sat, 2012-03-17 at 21:03 +0100, Chr. Rossmanith wrote:
> Hi,
>
> some more code removal.
Looks good, pushed this now.
> Probably the private variable maTransform can be removed as well: it is
> initialized with the identity transform and never changed afterwards.
Does that suggest that the
On Sat, 2012-03-17 at 15:34 +0100, Chr. Rossmanith wrote:
> Hi,
>
> I had a look at unusedcode.easy (sdext/presenter) and removed a little
> bit more than mentioned there: as there are no end callbacks added
> (AddEndCallback() was unused), there is no need to run them ->
> RunEndCallbacks() co
On Sun, 2012-03-18 at 14:40 +0100, Petr Vorel wrote:
> Hi there,
>
> some unused code removed (oox, sc).
Looks good to me, pushed now, thanks for these.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mai
On Fri, 2012-03-16 at 20:20 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good to me, pushed now, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.free
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara wrote:
> On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote:
>> Hi!
>>
>> These patches remove unused code as listed in unusedcode.easy
>
> Looks good, pushed now. Thanks for these. If I'm not wrong, this is you
> first submission ? If so, ca
On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote:
> Hi!
>
> These patches remove unused code as listed in unusedcode.easy
Looks good, pushed now. Thanks for these. If I'm not wrong, this is you
first submission ? If so, can you add yourself to
http://wiki.documentfoundation.org/Developme
Hi Petr,
On 09.03.2012 11:39, Petr Vorel wrote:
another patch removing unused code. Actually I need an advice this time. Is
method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted?
As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel
free to drop
Pushed.
On 03/08/2012 02:07 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffi
Pushed.
On 03/08/2012 02:19 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffi
Pushed.
On 03/08/2012 01:05 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreo
Pushed.
On 03/08/2012 01:27 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.eas
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffic
On Mon, 2012-02-27 at 21:10 +0100, Santiago Martinez wrote:
> Hi, i'm not sure if this patch is correct so please review. I deleted
> BiffInputStream::sizeBase(), skipByteString(bool) and skipUniString()
> methods listed in unusedcode.easy. But also deleted another two
> methods (skipUniStringBody
On Mon, 2012-02-27 at 20:10 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good, pushed now, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedeskto
On 19.02.2012 03:13, Petr Vorel wrote:
I removed a little bit of unused code (unusedcode.easy).
Thank you!
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 19.02.2012 12:28, Elton Chung wrote:
This patch removes 4 unused methods from basegfx.
Pushed, thanks.
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 19.02.2012 12:25, Elton Chung wrote:
This patch removes 5 unused methods.
Pushed, thank you!
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 18.02.2012 19:35, Elton Chung wrote:
This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d.
Yeah, nice catch. Thanks, pushed.
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/m
On Tue, Feb 14, 2012 at 01:43:11PM +, Caolán McNamara wrote:
> On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote:
>> Thanks, but this one should actually be used in
>> ODatabaseMetaData::getTableTypes. It is probably a bug that it is not,
>> I'll convert getTableTypes to using it
>
On Mon, 2012-02-13 at 15:38 +, Caolán McNamara wrote:
> On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote:
> > Hello,
> >
> > Attached is my first contribution to Libreoffice
>
> Looks good to me, pushed now, thanks for this.
adding PUSHED tag dammit.
C.
On Thu, 2012-02-09 at 02:44 +0800, Elton Chung wrote:
> Hi,
> This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+.
Thanks for these, pushed now.
C.
p.s. Well, I did leave out the DDe* ones because at least some are used
under windows, and it needs a bit more work to identify if they
On Thu, 2012-02-09 at 21:02 +0100, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
Looks good, pushed, thanks for this.
C.
p.s. of course, my intention was that *elses* utterly useless unused
code should go, *mine* of course was a work in progress which I w
pushed this one after all.
SfxMedium::GetHdl() seems to be used for now (in
tools/inc/tools/ref.hxx), maybe we can remove all of those macro
definitions...
I also removed 'using SfxControllerItem::GetCoreMetric;' statement from
sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded.
Pushed, thanks; however I have returned
ScSubTotalDescriptorBase::GetData(ScSubTotalParam&) const
ScSubTotalDescriptorBase::PutData(ScSubTotalParam const&)
back to the header, because these functions are is pure virtual, and the
implementations in ScSubTotalDescriptorBase is unused, not the all
Hi Elton,
thanks for your patch; I tweaked it a bit and then pushed.
Notes:
1. ScVbaWorksheet( const css::uno::Reference< ov::XHelperInterface >&
xParent, const css::uno::Reference< css::uno::XComponentContext >&
xContext );
is *not* unused, we can see it at least in
sc/source/ui/vba/vbawork
Hi Santiago,
28.01.2012 02:02, Santiago Martinez пишет:
This patch removes unused code as listed in unusedcode.easy
Pushed, thank you!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b507836fc88f294ef55652174b66dc706125599
Cheers,
Ivan
___
Hi,
On Friday, 2012-01-20 21:53:57 +0100, Michael Stahl wrote:
> thanks Santiago for the patch, pushed:
Marking thread [PUSHED]
Eike
--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
p
59 matches
Mail list logo
