Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Kohei Yoshida
On 06/01/2012 09:27 PM, Kohei Yoshida wrote: On 06/01/2012 06:54 PM, Rafael Dominguez wrote: The last 3-5 commits arent merged, those implement the missing exporting part and pending one of import. Ok. Perhaps we should merge those into master? We have a feature freeze coming up, so if you've

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Kohei Yoshida
On 06/01/2012 06:54 PM, Rafael Dominguez wrote: The last 3-5 commits arent merged, those implement the missing exporting part and pending one of import. Ok. Perhaps we should merge those into master? We have a feature freeze coming up, so if you've already implemented the export part, we c

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Rafael Dominguez
On Fri, Jun 1, 2012 at 6:14 PM, Markus Mohrhard < markus.mohrh...@googlemail.com> wrote: > Hello Rafael, > > > > > Sorry i forgot to tell you that the exporting code is not merged to > master, > > its in features/chart_errorbars i pushed the patch too to that branch. > > I merged your branch to ma

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Markus Mohrhard
Hello Rafael, > > Sorry i forgot to tell you that the exporting code is not merged to master, > its in features/chart_errorbars i pushed the patch too to that branch. I merged your branch to master back in April. Regards, Markus ___ LibreOffice mailing

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Rafael Dominguez
On Fri, Jun 1, 2012 at 4:33 PM, Kohei Yoshida wrote: > On Fri, 2012-06-01 at 14:05 -0400, Kohei Yoshida wrote: > > Hello Rafael, > > > > On Fri, 2012-06-01 at 11:13 -0430, Rafael Dominguez wrote: > > > > > i tried a lot of ideas and looked at how other code handle it but i > > > cant seem to get i

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Kohei Yoshida
On Fri, 2012-06-01 at 14:05 -0400, Kohei Yoshida wrote: > Hello Rafael, > > On Fri, 2012-06-01 at 11:13 -0430, Rafael Dominguez wrote: > > > i tried a lot of ideas and looked at how other code handle it but i > > cant seem to get it work, if you could check it out and fix it or tell > > me whats

Re: [REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Kohei Yoshida
Hello Rafael, On Fri, 2012-06-01 at 11:13 -0430, Rafael Dominguez wrote: > i tried a lot of ideas and looked at how other code handle it but i > cant seem to get it work, if you could check it out and fix it or tell > me whats wrong, that would > be highly appreciated. As we chatted on IRC, I'll

[REVIEW] fdo#33773 X-Axis Error Bars

2012-06-01 Thread Rafael Dominguez
This patch is the continuation of my work of adding support for x error bars, this patch implements importing the bars from ODF format but there's still one case that don't seem to work right, when you import error bars to other applications besides calc that use their own data provider. It seems