Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

2012-07-16 Thread Markus Mohrhard
2012/7/13 Eike Rathke er...@redhat.com: Hi Markus, On Friday, 2012-07-13 20:39:07 +0200, Markus Mohrhard wrote: In case of swapping we don't need all the special cases of ScAttrArray for finding the right place and inserting removing from the doc pool, we can just exchange the two pointers

[REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

2012-07-13 Thread Markus Mohrhard
Hey, [1] is a fix for i#118877. I did not like the idea from the apache bug fix to manipulate the manual ref count and decided to implement a cleaner solution for swapping rows/columns. In case of swapping we don't need all the special cases of ScAttrArray for finding the right place and

Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

2012-07-13 Thread Eike Rathke
Hi Markus, On Friday, 2012-07-13 20:39:07 +0200, Markus Mohrhard wrote: In case of swapping we don't need all the special cases of ScAttrArray for finding the right place and inserting removing from the doc pool, we can just exchange the two pointers which is faster and does not require