Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
On Mon, 2012-02-13 at 21:16 +0100, Eike Rathke wrote: > Hi Kohei, > > On Monday, 2012-02-13 12:40:11 -0500, Kohei Yoshida wrote: > > > Attached change (not yet committed to master) will fix a crasher bug > > which is one of the bugs reported in > > > > https://bugs.freedesktop.org/show_bug.cgi?i

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Eike Rathke
Hi Kohei, On Monday, 2012-02-13 12:40:11 -0500, Kohei Yoshida wrote: > Attached change (not yet committed to master) will fix a crasher bug > which is one of the bugs reported in > > https://bugs.freedesktop.org/show_bug.cgi?id=45916 > > It originally comes from > > https://issues.apache.org/o

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
Hi Ivan, On Mon, Feb 13, 2012 at 1:13 PM, Ivan Timofeev wrote: > Hi Kohei, > ScFormulaCell::Compile: > >    pCode = aComp.CompileString( rFormula ); >    if ( pCodeOld ) >        delete pCodeOld; >    if( !pCode->GetCodeError() ) >    { > > A crash will be right here, inside Compile?.. No it do

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Ivan Timofeev
Hi Kohei, On 13.02.2012 21:40, Kohei Yoshida wrote: The problem happened when calc was not able to compile the formula string for whatever reason, in which case pCode would remain NULL after the Compile is called in one of its constructors. Sorry, I did not test the bug, but... ScFormulaCell:

[REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
Attached change (not yet committed to master) will fix a crasher bug which is one of the bugs reported in https://bugs.freedesktop.org/show_bug.cgi?id=45916 It originally comes from https://issues.apache.org/ooo/show_bug.cgi?id=118851 There were several ways to think this as far as I could see.