Re: [PUSHED][3-4,3-5][REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-13 Thread Caolán McNamara
On Fri, 2012-02-10 at 18:12 +0100, Jan Holesovsky wrote: > Please approve for libreoffice-3-5, and for libreoffice-3-4 too, if it > applies there. Applied to 3-4 as well, and seems sane, pushed to 3-4 as well. C. ___ LibreOffice mailing list LibreOffic

[PUSHED 3-5] Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-13 Thread Jan Holesovsky
[just marking as PUSHED] Jan Holesovsky píše v Po 13. 02. 2012 v 13:15 +0100: > Hi Michael, > > Michael Meeks píše v Po 13. 02. 2012 v 11:59 +: > > > > Returning a 'I was unable create a cursor' value via throwing runtime > > > exception [in SwXFootnote::createTextCursorByRange()] is not rea

Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-13 Thread Jan Holesovsky
Hi Michael, Michael Meeks píše v Po 13. 02. 2012 v 11:59 +: > > Returning a 'I was unable create a cursor' value via throwing runtime > > exception [in SwXFootnote::createTextCursorByRange()] is not really > > efficient ;-) - but I have no idea what I might break by changing that, > > so I ju

Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-13 Thread Michael Meeks
On Fri, 2012-02-10 at 18:12 +0100, Jan Holesovsky wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=9951de4a10386a85dc1bfa465304cd0005414b8e Workaround looks fine to me :-) I'm amazed that we throw such a hard exception here, but ... > Returning a 'I was unable create a cu

[REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-10 Thread Jan Holesovsky
Hi, We throw an uncatched exception: https://bugs.freedesktop.org/show_bug.cgi?id=42771 The fix is here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9951de4a10386a85dc1bfa465304cd0005414b8e Returning a 'I was unable create a cursor' value via throwing runtime exception [in SwXFootn