Re: [REVIEW for 3.5] Fix redundant assignment of nAngle in switch in svx

2012-03-20 Thread Petr Mladek
julien2412 píše v Po 19. 03. 2012 v 14:40 -0700: yep it creates fractal :-) You know, it is better to be careful. There are many workarounds for bugs in the code. For example, there was a bug in widgets ordering. The workaround made one widget transparent and passed events to the other widget.

Re: [REVIEW for 3.5] Fix redundant assignment of nAngle in switch in svx

2012-03-19 Thread Tor Lillqvist
Can I cherry-pick this commit 49d7d4b3255f731ce9a8b5256da25f6a9bf53169 to 3.5 ? Any idea what the visual impact of this change is? Who knows, maybe the calling code actually expects the apparently nonsense semantics by now;) --tml ___ LibreOffice

Re: [REVIEW for 3.5] Fix redundant assignment of nAngle in switch in svx

2012-03-19 Thread julien2412
yep it creates fractal :-) More seriously, I saw that it's at least used here in this file sw/source/core/doc/tblafmt.cxx (line 413) Julien. -- View this message in context:

[REVIEW for 3.5] Fix redundant assignment of nAngle in switch in svx

2012-03-18 Thread julien2412
Hello, In svx cppcheck reports this : [source/items/algitem.cxx:183]: (warning) Redundant assignment of nAngle in switch Here are the lines : switch( static_cast SvxCellOrientation ( GetValue() ) ) { case SVX_ORIENTATION_BOTTOMTOP: nAngle = 9000; case