[Bug 34465] get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

https://bugs.freedesktop.org/show_bug.cgi?id=34465 Björn Michaelsen changed: What|Removed |Added CC|libreoffice@lists.freedeskt | |op.org

[Bug 34465] get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

https://bugs.freedesktop.org/show_bug.cgi?id=34465 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, 2012/11/30 Bjoern Michaelsen > Yes, there are quite a few evil cornercases lurking there. Before changing > those conditionals, I think it is a good idea to just add assertions that > make > sure these assumptions are kept consistent all the time. A start would be > to > check that wh

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

On 30/11/12 15:19, Maciej Rumianowski wrote: > Hi Bjoern, > > thanks for reply :) > > So, to change the conditionals, we need to make sure the state is > consistent. > Thus: > - adding the asserts > > Do you mean DBG_ASSERT or real assert? if the goal is to track down client co

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, thanks for reply :) So, to change the conditionals, we need to make sure the state is > consistent. > Thus: > - adding the asserts > Do you mean DBG_ASSERT or real assert? How do debug those DBG_ASSERT, when compiling I don't get a lot of output. My command is make 2>&1 | tee build.l

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

On Thu, Nov 22, 2012 at 08:52:20AM +0100, Maciej Rumianowski wrote: > I have hit a problem that i don't fully understand. Disabled items are > SfxVoidItem with Which 0, but inserted with different one. State of Item is > check with TYPE Macro as below > > > if ( (*ppFnd)->Type() == TYPE(SfxVoidIte

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Just Ping if someone could help me on that. 2012/11/26 Maciej Rumianowski > I failed here. Every place Item with which-id 4040 (EE_FEATURE_LINEBR) is > created/copied/setWhich is a valid SfxVoidItem with Type() method. Only > fails in SfxItemSet destructor as below > > Program received signal SI

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

I failed here. Every place Item with which-id 4040 (EE_FEATURE_LINEBR) is created/copied/setWhich is a valid SfxVoidItem with Type() method. Only fails in SfxItemSet destructor as below Program received signal SIGSEGV, Segmentation fault. > 0x4496cc33 in SfxItemSet::~SfxItemSet (this=0xbfff51e8, >

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

> > Ok I lack knowledge about inheritance and what really is called. Above are > not equal :( > (gdb) print (*ppFnd)->StaticType() == (*ppFnd)->Type() >> $7 = false >> > > Ok, I have found (maybe) why it is going so. A class that inherits from SfxPoolItem does not use TYPEINFO() macro and i have to

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

2012/11/22 Maciej Rumianowski > > > 2012/11/22 Maciej Rumianowski > >> Hi Bjoern, >> >> I have hit a problem that i don't fully understand. Disabled items are >> SfxVoidItem with Which 0, but inserted with different one. State of Item is >> check with TYPE Macro as below >> >>> if ( (*ppFnd)->Ty

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

2012/11/22 Maciej Rumianowski > Hi Bjoern, > > I have hit a problem that i don't fully understand. Disabled items are > SfxVoidItem with Which 0, but inserted with different one. State of Item is > check with TYPE Macro as below > >> if ( (*ppFnd)->Type() == TYPE(SfxVoidItem) ) >>

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, I have hit a problem that i don't fully understand. Disabled items are SfxVoidItem with Which 0, but inserted with different one. State of Item is check with TYPE Macro as below > if ( (*ppFnd)->Type() == TYPE(SfxVoidItem) ) > return SFX_ITEM_DISABLED; > So it

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Maciej, On Wed, Nov 07, 2012 at 04:41:04PM +0100, Maciej Rumianowski wrote: > I've started to work on the *Bug > 34465*i awesome! > and I have some questions: > > 1) What do you suggest to find all places where Put( const SfxPoolItem&, > US

Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Björn, I've started to work on the *Bug 34465*and I have some questions: 1) What do you suggest to find all places where Put( const SfxPoolItem&, USHORT nWhich) is used? I came up with idea to make function private and fix all places wher