[SOLVED] Re: Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-11 Thread Julien Nabet
On 11/04/2014 13:20, Caolán McNamara wrote: On Tue, 2014-04-08 at 20:58 +0200, Julien Nabet wrote: ... I submitted a gerrit review 4.2: https://gerrit.libreoffice.org/8897 I'm rather reluctant to change this in 4.2 without a specific known problem that it fixes. Ok then, I abandonned it. Juli

Re: Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-11 Thread Caolán McNamara
On Tue, 2014-04-08 at 20:58 +0200, Julien Nabet wrote: > I've just pushed the fix on master. "make check" on top level was ok. > Searching in git history during "make check", I found this commit from 2008: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d20a47c3d50d0a88543b2355ec7340fc74

Re: Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-08 Thread Julien Nabet
On 08/04/2014 13:10, Caolán McNamara wrote: On Sat, 2014-04-05 at 15:51 -0700, julien2412 wrote: Hello, Cppcheck reported this svx/source/unodraw/unomod.cxx 492 multiCondition style Expression is always false because 'else if' condition matches previous condition at line 460. Remark: It

Re: Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-08 Thread Caolán McNamara
On Sat, 2014-04-05 at 15:51 -0700, julien2412 wrote: > Hello, > > Cppcheck reported this > svx/source/unodraw/unomod.cxx > 492 multiCondition style Expression is always false because 'else if' > condition matches previous condition at line 460. > > Remark: It's a new kind of cppcheck detecti

Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-05 Thread julien2412
{ 494 nType = OBJ_TABLE; 495 } see http://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unomod.cxx#460 Which one of this block is ok? Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-else-if-condition-matches-previou