Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-26 Thread Stephan Bergmann
On 23/09/2019 13:55, Stephan Bergmann wrote: Miklos, in light of that maybe you have an idea how to improve your test? seen that addressed now with "CppunitTest_sw_uiwriter: improve limit in testTdf105330"

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-25 Thread Stephan Bergmann
On 20/09/2019 13:51, Stephan Bergmann wrote: On 20/09/2019 08:54, Stephan Bergmann wrote: I experience the same, but on a non-scaled (to the best of my knowledge) Windows 8 box.  I initially came up with "Fix CppunitTest_sw_uiwriter for my Windows

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-23 Thread Miklos Vajna
Hi Luke, On Sat, Sep 21, 2019 at 11:53:19AM +, Luke Benes wrote: > Does it really make sense for all of these unit tests to be DPI dependent? My understanding is that in almost all cases this is not intentional, rather stems from starting to test some code which was not covered previously.

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-23 Thread Patrick Jaap
Hi! In my commit I tested for fly portions. Is this really the right commit? And I don't know in what specific environment the unit tests should be executed. Do we take display scaling into account? Best, Patrick Am Sonntag, 15. September 2019, 03:52:01 CEST schrieb Luke Benes: > The Unit

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-22 Thread Luke Benes
After Stephan and Balazs' patches, I can now build on windows with HiDPI. Thanks guys! Does it really make sense for all of these unit tests to be DPI dependent? -Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-20 Thread Stephan Bergmann
On 20/09/2019 08:54, Stephan Bergmann wrote: I experience the same, but on a non-scaled (to the best of my knowledge) Windows 8 box.  I initially came up with "Fix CppunitTest_sw_uiwriter for my Windows build", but see Miklos' comment there.  I

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-20 Thread Stephan Bergmann
On 19/09/2019 20:52, Luke Benes wrote: The Unit Test in https://cgit.freedesktop.org/libreoffice/core/commit/?id=c56bf1479cc71d1a2b0639f6383e90c1f7e3655b Is failing on Windows with 125% scale factor. The build fails with the following error: C:/core/sw/qa/extras/uiwriter/uiwriter2.cxx(2253) :

CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-19 Thread Luke Benes
Miklos, The Unit Test in https://cgit.freedesktop.org/libreoffice/core/commit/?id=c56bf1479cc71d1a2b0639f6383e90c1f7e3655b Is failing on Windows with 125% scale factor. The build fails with the following error: C:/core/sw/qa/extras/uiwriter/uiwriter2.cxx(2253) : error : Assertion Test name:

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-17 Thread Németh László
Hi Luke, Luke Benes ezt írta (időpont: 2019. szept. 17., K, 3:44): > Sorry. I copy/pasted the wrong commit id. The build started failing after > the Unit Test added in > > https://cgit.freedesktop.org/libreoffice/core/commit/?id=55136439e71b7adc62a46a3d3dc8de26d54d989d > > tdf127448 Chart:

Re: CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-16 Thread Luke Benes
Sorry. I copy/pasted the wrong commit id. The build started failing after the Unit Test added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=55136439e71b7adc62a46a3d3dc8de26d54d989d tdf127448 Chart: Avoid distortion of charts with multilevel axis labels Should the assert be relaxed

CppunitTest_sw_layoutwriter failing on Windows with HiDPI

2019-09-14 Thread Luke Benes
The Unit Test added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ac31078b9c46231f8ecf0409a1724749ac8c5a4 Is causing the core Unit Test CppunitTest_sw_layoutwriter to fail when you set, Settings->Display->Scale=125% in Windows 10. horizontal_multilevel.odt: