Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-10 Thread Stephan Bergmann
On 04/10/2012 11:23 AM, Noel Grandin wrote: I've fixed some of the failures, and now I'm bumping into a SIGSEGV, which I really don't know how to track down. Latest git patch attached. rtl_uString_acquire () from

Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-10 Thread Noel Grandin
I was working off a stable point (i.e. a point in time when I could make check successfully from master). I'll have to rebase the patch off the latest master because so much has changed. On 2012-04-10 11:31, Stephan Bergmann wrote: There has been some trouble with editeng lately, which Kohei

Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-05 Thread Stephan Bergmann
On 04/04/2012 05:00 PM, Noel Grandin wrote: I've converted a bunch of stuff, including graphic/GraphicProvider. I'm now getting failures in some of the unit tests. Are my changes at fault, or is there something else that needs fixing? Thanks, Noel Grandin File tested,Test Result,Execution Time

Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-04 Thread Noel Grandin
On 2012-04-03 17:10, Stephan Bergmann wrote: It does throw. The constructors are guaranteed to either return a non-null reference or throw an exception (the default constructors all throw com.sun.star.uno.DeploymentException, which is derived from RuntimeException; explicit constructors

Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-04 Thread Stephan Bergmann
On 04/04/2012 10:13 AM, Noel Grandin wrote: On 2012-04-03 17:10, Stephan Bergmann wrote: So you'd probably also come across code like ReferenceX x(...createInstance...); if (x.is()) { ... } that you can simplify by using a constructor and removing the x.is() check. What about code that

EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-03 Thread Noel Grandin
Hi I'm working my way through the codebase, translating the easy stuff. What is the cleanest translation of this: Reference graphic::XGraphicProvider xGraphProv( xFact-createInstance( C2U(com.sun.star.graphic.GraphicProvider)), uno::UNO_QUERY_THROW );

Re: EasyHack, fdo#46808, Adapt UNO services to new style, Phase II

2012-04-03 Thread Stephan Bergmann
On 04/03/2012 03:11 PM, Noel Grandin wrote: I'm working my way through the codebase, translating the easy stuff. What is the cleanest translation of this: Reference graphic::XGraphicProvider xGraphProv( xFact-createInstance( C2U(com.sun.star.graphic.GraphicProvider)), uno::UNO_QUERY_THROW );