Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-18 Thread Miklos Vajna
Hi Renato, On Tue, Dec 16, 2014 at 01:18:34PM +, Renato Ferreira wrote: > More to the point, I opened both documents on Word and they are identical, > no invisible images at all. So maybe it is OK? Thanks for checking. So please change the limit to suit your needs. On my machine, the old va

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-16 Thread Renato Ferreira
Hi Miklos, > http://opengrok.libreoffice.org/xref/core/sw/qa/extras/README describes > how the sw export tests work. So, to manually reproduce: open the docx > file, save it as docx, then open both the original and the saved file in > Word, and make sure that the asserted aspect does not differ (

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-16 Thread Miklos Vajna
Hi Renato, On Mon, Dec 15, 2014 at 12:28:20PM +, Renato Ferreira wrote: > However, how does the export/import/export thing works? I tried loading the > .docx, saving it as .odt and exporting again, but unless I did something > wrong, I think I ended up with the same file... http://opengrok.

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-15 Thread Renato Ferreira
> > > Each time I write such an assertion, I add a comment about what was the > old/wrong value, so in case you get 1999 instead of 2000, you have a > chance to judge if the old rounding error is back or in fact the 1999 vs > 2000 is not a big difference in this case. In this case, it says "the > i

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-15 Thread Stephan Bergmann
On 12/15/2014 09:53 AM, Stephan Bergmann wrote: 21856 is what I consistently get on a 15" retina Mac, building against 10.10 SDK. ...and running on 10.10.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mai

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-15 Thread Stephan Bergmann
On 12/13/2014 12:44 AM, Renato Ferreira wrote: commit b1b29ae795ff86097b21907f814d94bd5488929d Author: Stephan Bergmann mailto:sberg...@redhat.com>> Date: Thu Nov 20 12:06:11 2014 +0100 ...at least, that's the value for me on Mac with retina Change-Id: I041b497bab9415b2b33d6b4b91f3c5

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-15 Thread Miklos Vajna
Hi, On Fri, Dec 12, 2014 at 06:52:03PM -0500, Kohei Yoshida wrote: > > Test name: testCropPixel::Import_Export_Import > > assertion failed > > - Expression: getXPath(pXmlDoc, "//a:srcRect", "l").toInt32() <= 21856 > ... > > > > My Mac (Retina 13") gives the value 22452, but I'm not able to tell

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-14 Thread Renato Ferreira
> > > Usually, each import export test has an associated file you can open, > then by comparing the content of the file and the code in the test, one > can perhaps make a best effort guess of what the test expects, and what > expectation is incorrect and/or whether there is a real bug in it... > >

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-13 Thread Alex Thurgood
Le 13/12/2014 00:44, Renato Ferreira a écrit : > Hi everybody, > > As I had mentioned in another thread, a unit test has been failing in my > machine for some time. This is not a fatal error, but I think it would > be beneficial to understand where the problem comes from. > > The test is CppunitT

Re: Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-12 Thread Kohei Yoshida
On Fri, 2014-12-12 at 23:44 +, Renato Ferreira wrote: > > Test name: testCropPixel::Import_Export_Import > assertion failed > - Expression: getXPath(pXmlDoc, "//a:srcRect", "l").toInt32() <= 21856 ... > > My Mac (Retina 13") gives the value 22452, but I'm not able to tell > which value is "v

Failing unit test in Mac OS X Yosemite 10.10.1

2014-12-12 Thread Renato Ferreira
Hi everybody, As I had mentioned in another thread, a unit test has been failing in my machine for some time. This is not a fatal error, but I think it would be beneficial to understand where the problem comes from. The test is CppunitTest_sw_ooxmlexport (ooxmlimport failed for some time, but app