Re: Gerrit Code-Review +1 / -1

2017-11-08 Thread Jan Holesovsky
Hi Thorsten, Thorsten Behrens píše v Út 07. 11. 2017 v 23:00 +0100: > > 1) Code-Style label in gerrit > > > > https://gerrit-review.googlesource.com/Documentation/config-labels. > > html#label_custom > > > Just added - group BuildBots has rights to set +1/-1. Cool - thanks! :-) > > 3) Tool th

Re: Gerrit Code-Review +1 / -1

2017-11-07 Thread Thorsten Behrens
Jan Holesovsky wrote: > We need: > > 1) Code-Style label in gerrit > > https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom > Just added - group BuildBots has rights to set +1/-1. > 2) Gerrit trigger to trigger the style checking itself > > https://wiki.jenkins.

Gerrit Code-Review +1 / -1

2017-11-02 Thread Jan Holesovsky
Hi, I have no idea who has enough karma to actually do changes to the gerrit and jenkins config, so I'm CC'ing Guilhem + Christian; do you have an advice? I've done the research 'what needs to be done', and I think it is no rocket science ;-) - but also CC'ing David for sanity check. We need: 1