Re: Gitiles VCS browser

Guilthem, Why have you not answered my question about returning the Commit Bot back to cgit? Gitiles is wasting our time. For example, just now I followed the commit bot link on tdf#42949 to

Re: Gitiles VCS browser

It is telling that when I asked what you prefer, you answered that the extraneous information “doesn't hurt “. Your tolerance to noise may be higher than many, but it’s a well-established fact the less clutter in the UI, the faster it is for humans to use.  Gitiles is fails here, takes longer

Re: Gitiles VCS browser

On 06.04.2019 17:18, Luke Benes wrote: > Mike, > That is not an apples to apples comparison. In your browser open and compare > side-by-side: > > https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a > and >

Re: Gitiles VCS browser

Mike, That is not an apples to apples comparison. In your browser open and compare side-by-side: https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a and https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a Do you really like

Re: Gitiles VCS browser

Hi, On 06.04.2019 1:46, Luke Benes wrote: > No one in QA and no developers have voiced a preference for gitiles. > Because it's slower, it's UI and UX is harder to read, it lacks useful > tools like search,  and the URLs are a pain to work with. It's inferior > in every way. Personally I like

Re: Gitiles VCS browser

Guilhem, There is something wrong with your benchmark methodology. This cgit page loads in under 1 second: https://cgit.freedesktop.org/libreoffice/core/log/sw/source/filter/ww8/docxattributeoutput.cxx?ofs=50 While

Re: Gitiles VCS browser

On Fri, 05 Apr 2019 at 17:07:06 +, Kaganski Mike wrote: > On 05.04.2019 19:55, Guilhem Moulin wrote: >> On Fri, 05 Apr 2019 at 09:17:01 +0200, Miklos Vajna wrote: >>> One more aspect: perhaps I'm just unlucky, but on average, I found >>> cgit to load much faster than these git.libreoffice.org

Re: Gitiles VCS browser

On 05.04.2019 19:55, Guilhem Moulin wrote: > Hi Miklos, > > On Fri, 05 Apr 2019 at 09:17:01 +0200, Miklos Vajna wrote: >> One more aspect: perhaps I'm just unlucky, but on average, I found >> cgit to load much faster than these git.libreoffice.org links. > > Hmm that's interesting. That's not

Re: Gitiles VCS browser

Hi Miklos, On Fri, 05 Apr 2019 at 09:17:01 +0200, Miklos Vajna wrote: > One more aspect: perhaps I'm just unlucky, but on average, I found > cgit to load much faster than these git.libreoffice.org links. Hmm that's interesting. That's not something I'm able to reproduce by taking 100 random

Re: Gitiles VCS browser

On Wed, 20 Mar 2019 at 16:24:49 +, Luke Benes wrote: > In his last email, Mike explains how the gitiles timestamps lead to > confusion. This is a serious problem for my use case. You mean https://lists.freedesktop.org/archives/libreoffice/2018-November/081343.html ? This was addressed on Nov

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi, On Thu, Apr 04, 2019 at 05:19:32PM +, Luke Benes wrote: > So unless someone has some compelling reasons to keep it, I > respectfully ask that the Commit Notification Bot be switch back to > cgit. We have tried to use it, and as far as I can tell, universally > dislike it. One more

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Switching to hub redirection solves the annoying symbols that Gitiles appends to URLs leading to copy and paste errors and the timestamp issue. But it does not address: * Lack of Built-in, easy to use search functionality * Lack of branch tags, allowing you to see what release you are on when

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Maybe just use the hub redirection, e.g. https://hub.libreoffice.org/git-core/40264372657160b69b9639eff4fe0263af8f9033 https://hub.libreoffice.org/git-online/eaa4a7838a913979eddd2304053b1697ad596586 Using the hub has the advantage that the links would still work even if cgit.fdo was no longer

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Could you please change the Commit Notification bot back to cgit? In the 6 months, that I have been testing gitiles, I have found no advantages and many disadvantages over cgit. In general, it presents information in an inferior way and it’s URL’s have led to multiple copy and paste errors,

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 17/10/2018 14:05, Eike Rathke wrote: For diffs I much prefer the gerrit view because it highlights changes within changed lines, for example https://gerrit.libreoffice.org/plugins/gitiles/core/+/9672d034b9e760f24ac9a6652ab45dee15ee260a%5E%21/ vs

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

One minor thing that cgit.freedesktop.org provides is a "Diffstat" block (listing all files changed) between the commit message and the individual files' diffs, see e.g. . That's not present at

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 11/6/2018 4:12 PM, Miklos Vajna wrote: > So what to change? https://git.libreoffice.org/core/+log/HEAD -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Mike, On Tue, Nov 06, 2018 at 07:30:45AM +, Kaganski Mike wrote: > Well - of course, there's no guarantees; but given the workflow, when we > have the author date recorded when the first version of commit was > created, which might be months before the commit gets into the final >

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 10/31/2018 9:15 AM, Guilhem Moulin wrote: > On Tue, 30 Oct 2018 at 16:18:36 +, Luke Benes wrote: >> The date gitiles displays in the log is the author date, rather than >> the much more useful commit date. > > Quoting my own <20181023142926.GB21836@localhost.localdomain>: > > | It's shows

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Guilhem, On Friday, 2018-10-26 15:44:53 +0200, Guilhem Moulin wrote: > On Wed, 17 Oct 2018 at 21:03:45 +0200, Guilhem Moulin wrote: > > On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote: > >> For diffs I much prefer the gerrit view because it highlights changes > >> within changed

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 30 Oct 2018 at 16:18:36 +, Luke Benes wrote: > The date gitiles displays in the log is the author date, rather than > the much more useful commit date. Quoting my own <20181023142926.GB21836@localhost.localdomain>: | It's shows the authored date, not the commit date. We can easily

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Now that gitiles is linked to bugzilla instead of cgit, I'm giving it a good workout. From a QA perspective, it's missing 2 key features that interfere with my workflow. The date gitiles displays in the log is the author date, rather than the much more useful commit date. When trying to

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Björn, On Sun, 28 Oct 2018 at 10:55:01 +0100, Bjoern Michaelsen wrote: > Can we have it as the link in these "commit notifications" Sure, done: https://bugs.documentfoundation.org/show_bug.cgi?id=119410#c6 . Cheers, -- Guilhem. signature.asc Description: PGP signature

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi, On Wed, Oct 17, 2018 at 04:27:54AM +0200, Guilhem Moulin wrote: > * diff: https://gerrit.libreoffice.org/plugins/gitiles/core/+/master%5E%21/ > vs. > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=refs/heads/master that looks great! Can we have it as the link in these

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 23 Oct 2018 at 04:29:05 -0500, Adolfo Jayme Barrientos wrote: > Since loading the whole diff for a commit would potentially crash my > browser, I find it very helpful to load each file’s individual diff in > a commit like this [1]. Also, I can open per-file diffs in separate > tabs for

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Eike, On Wed, 17 Oct 2018 at 21:03:45 +0200, Guilhem Moulin wrote: > On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote: >> For diffs I much prefer the gerrit view because it highlights changes >> within changed lines, for example >> >>

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 23 Oct 2018 at 13:42:34 +0200, Christian Lohmaier wrote: > On Tue, Oct 23, 2018 at 1:15 PM Adolfo Jayme Barrientos > wrote: >> Missatge de Kaganski Mike del dia dt., 23 d’oct. >> 2018 a les 4:40: >>> Well - e.g., >>>

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 23 Oct 2018 at 09:40:20 +, Kaganski Mike wrote: > What seems odd to me is why the log like > https://gerrit.libreoffice.org/plugins/gitiles/core/+log/HEAD shows > commit creatin time that is different from the time the commit was > pushed to the branch. I would like to see

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 23 Oct 2018 at 09:42:54 +0200, Lionel Elie Mamane wrote: > On Tue, Oct 23, 2018 at 07:34:54AM +0200, Guilhem Moulin wrote: >> On Mon, 22 Oct 2018 at 17:25:11 +0200, Lionel Elie Mamane wrote: >>> On Mon, Oct 22, 2018 at 04:33:21PM +0200, Guilhem Moulin wrote: Might be orthogonal to the

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Adolfo, On Tue, Oct 23, 2018 at 1:15 PM Adolfo Jayme Barrientos wrote: > > Missatge de Kaganski Mike del dia dt., 23 > d’oct. 2018 a les 4:40: > > Well - e.g., > > https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986 > > shows the individual links for

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Missatge de Kaganski Mike del dia dt., 23 d’oct. 2018 a les 4:40: > Well - e.g., > https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986 > shows the individual links for each file like this: > > icon-themes/breeze/links.txt[diff] >

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 10/23/2018 12:29 PM, Adolfo Jayme Barrientos wrote: > Gitiles lacks this kind of per-file-diff links, so I can only load a > diff of all the files touched by the commit. This isn’t nice for my > underpowered computer, and it really breaks my workflow. Well - e.g.,

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi, Guilhem: > Right now https://gerrit.libreoffice.org/#/c/$CHANGENUM/ has both gitweb > and Gitiles links, but unless we hear strong objection we'll disable > gitweb at the end of the month Here’s an objection! :P Well, I have this use case: every diff in the translations repository is huge,

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, Oct 23, 2018 at 07:34:54AM +0200, Guilhem Moulin wrote: > On Mon, 22 Oct 2018 at 17:25:11 +0200, Lionel Elie Mamane wrote: >> On Mon, Oct 22, 2018 at 04:33:21PM +0200, Guilhem Moulin wrote: >>> Might be orthogonal to the git:// vs. https:// vs. ssh:// >>> discussion. Gerrit uses JGit as

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Mon, 22 Oct 2018 at 17:25:11 +0200, Lionel Elie Mamane wrote: > On Mon, Oct 22, 2018 at 04:33:21PM +0200, Guilhem Moulin wrote: >> On Mon, 22 Oct 2018 at 11:51:35 +0200, Lionel Elie Mamane wrote: >>> On Wed, Oct 17, 2018 at 09:03:45PM +0200, Guilhem Moulin wrote: SSH is only used for

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 22/10/2018 16:25, Lionel Elie Mamane wrote: 1) Someone's out in the woods home DSL line in the woods; fiber hasn't come to that village yet, or has come to the town but not that particular street. RTT time about 50ms; bandwidth about 20 Mbps down (or less), much less up. This

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Mon, Oct 22, 2018 at 04:33:21PM +0200, Guilhem Moulin wrote: > On Mon, 22 Oct 2018 at 11:51:35 +0200, Lionel Elie Mamane wrote: >> On Wed, Oct 17, 2018 at 09:03:45PM +0200, Guilhem Moulin wrote: >>> SSH is only used for transport, a git processed is exec()'ed on the >>> remote just like for

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Mon, 22 Oct 2018 at 11:51:35 +0200, Lionel Elie Mamane wrote: > On Wed, Oct 17, 2018 at 09:03:45PM +0200, Guilhem Moulin wrote: >> On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote: >>> On Wednesday, 2018-10-17 04:27:54 +0200, Guilhem Moulin wrote: Lastly, it's now possible to clone

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Wed, Oct 17, 2018 at 09:03:45PM +0200, Guilhem Moulin wrote: > On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote: >> On Wednesday, 2018-10-17 04:27:54 +0200, Guilhem Moulin wrote: >>> Lastly, it's now possible to clone and fetch git repositories over >>> https:// . While git:// URLs

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Am 17.10.2018 um 20:10 schrieb Guilhem Moulin: It does indeed, but it's a bit hidden:-P https://gerrit.libreoffice.org/plugins/gitiles/core/+log/?author=caolan How attached are you to the search form? We could definitely add one to the template, but for now I only changed it (on the

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Guilhem, On Wed, Oct 17, 2018 at 08:10:01PM +0200, Guilhem Moulin wrote: > Done on our gerrit stage instance (https://vm178.documentfoundation.org/); > will > do the same thing on the prod instance next time we have to restart the > service. Thanks! > It does indeed, but it's a bit

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Wed, 17 Oct 2018 at 18:51:31 +, slacka wrote: > Thanks Guilhem! I like the look of gitiles, but they both need better > integration. Could you add hyperlinks to referenced commit messages > and to bugzilla? > […] > Note how gitiles is missing both and gitweb does not link to the bug >

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Wed, 17 Oct 2018 at 22:31:37 +, Xisco Fauli wrote: > Sometimes i use the range search from cgit. e.g > > https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=647fc41763d1310479d59262734caa296f6e558d..044122de1153bd785ed555c96b6aca67e9d0f739 > > Do you know how I can do it with

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Guilhem, El 17/10/18 a les 20:10, Guilhem Moulin ha escrit: > It does indeed, but it's a bit hidden :-P > > https://gerrit.libreoffice.org/plugins/gitiles/core/+log/?author=caolan > > How attached are you to the search form? Sometimes i use the range search from cgit. e.g

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi, On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote: > On Wednesday, 2018-10-17 04:27:54 +0200, Guilhem Moulin wrote: > >> * diff: https://gerrit.libreoffice.org/plugins/gitiles/core/+/master%5E%21/ >> vs. >>

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Thanks Guilhem! I like the look of gitiles, but they both need better integration. Could you add hyperlinks to referenced commit messages and to bugzilla? cgit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=048b8e45813f6a19a4ff56e1d676fe9450325cd2 gitiles:

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Miklos, On Wed, 17 Oct 2018 at 09:26:40 +0200, Miklos Vajna wrote: > On Wed, Oct 17, 2018 at 04:27:54AM +0200, Guilhem Moulin > wrote: >> Right now https://gerrit.libreoffice.org/#/c/$CHANGENUM/ has both gitweb >> and Gitiles links, but unless we hear strong objection we'll disable >> gitweb

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Guilhem, On Wednesday, 2018-10-17 04:27:54 +0200, Guilhem Moulin wrote: > * diff: https://gerrit.libreoffice.org/plugins/gitiles/core/+/master%5E%21/ > vs. > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=refs/heads/master For diffs I much prefer the gerrit view

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 17/10/2018 09:26, Miklos Vajna wrote: Hi Guilhem, On Wed, Oct 17, 2018 at 04:27:54AM +0200, Guilhem Moulin wrote: Right now https://gerrit.libreoffice.org/#/c/$CHANGENUM/ has both gitweb and Gitiles links, but unless we hear strong objection we'll disable gitweb at the end of the month,

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Guilhem, On Wed, Oct 17, 2018 at 04:27:54AM +0200, Guilhem Moulin wrote: > Right now https://gerrit.libreoffice.org/#/c/$CHANGENUM/ has both gitweb > and Gitiles links, but unless we hear strong objection we'll disable > gitweb at the end of the month, and serve requests to >

[TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Dear developers, As announced a few hours ago in the infra call minutes, we deployed another git browser — Gitiles — alongside gitweb. It's also what the Google folks are using (in fact they're upstream), and IMHO has quite a nicer feel than the venerable gitweb/cgit: * summary: