Re: Is the lcl_LocalFunction naming convention useful?

2012-10-22 Thread Eike Rathke
Hi Stephan, On Monday, 2012-10-15 12:24:38 +0200, Stephan Bergmann wrote: > symbols were matched against white/black-lists, and lcl_* was always > black-listed. Long gone (and I have no idea why people didn't > simply use "static" anyway). IIRC, by chance, not using static stems from times wher

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-15 Thread Stephan Bergmann
On 10/09/2012 07:59 AM, Tor Lillqvist wrote: Where did this lcl_ convention come from? The lcl_ prefix has no meaning to a compiler or linker. One way this /did/ have influence on linking was the old mechanism to select symbols for DLL export on Windows, where the available symbols were match

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-12 Thread Kohei Yoshida
On 10/09/2012 01:59 AM, Tor Lillqvist wrote: Where did this lcl_ convention come from? The lcl_ prefix has no meaning to a compiler or linker. If the intent is to make such functions file-local, why not use the static keyword, or an anonymous namespace instead, so that they actually *are* local a

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-12 Thread Lubos Lunak
On Tuesday 09 of October 2012, Tor Lillqvist wrote: > Where did this lcl_ convention come from? The lcl_ prefix has no > meaning to a compiler or linker. If the intent is to make such > functions file-local, why not use the static keyword, or an anonymous > namespace instead, so that they actually

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Michael Meeks
Hi Tor, On Tue, 2012-10-09 at 09:29 +0300, Tor Lillqvist wrote: > Anyway, my main point was not that we should drop the "lcl_" prefix, > but that we should make these functions *actually* local, also for the > tool-chain, i.e. either static or in anonymous namespaces. Amen - we should sta

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Bjoern Michaelsen
On Tue, Oct 09, 2012 at 08:59:47AM +0300, Tor Lillqvist wrote: > Where did this lcl_ convention come from? http://wiki.openoffice.org/wiki/Writer_Code_Conventions#free_functions_and_methods > The lcl_ prefix has no meaning to a compiler or linker. If the intent is to > make such functions file-lo

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Lubos Lunak
On Tuesday 09 of October 2012, Miklos Vajna wrote: > On Tue, Oct 09, 2012 at 09:29:45AM +0300, Tor Lillqvist wrote: > > > > Where did this lcl_ convention come from? From a codebase that is ridden with Hungarian notation and other eye-"pleasing" features? > > But how is the fact that you see t

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-08 Thread Miklos Vajna
On Tue, Oct 09, 2012 at 09:29:45AM +0300, Tor Lillqvist wrote: > But how is the fact that you see that some lcl_Function is "local" > make it easier to understand what the function does? Isn't it only > unnecessary visual fluff? Example: if it's lcl_Foo(), I just search in the local file. If it's

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-08 Thread Tor Lillqvist
> So I think it's useful: when I read code, it makes understanding a bit > easier. But how is the fact that you see that some lcl_Function is "local" make it easier to understand what the function does? Isn't it only unnecessary visual fluff? Anyway, my main point was not that we should drop the

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-08 Thread Noel Grandin
On 2012-10-09 07:59, Tor Lillqvist wrote: Where did this lcl_ convention come from? The lcl_ prefix has no meaning to a compiler or linker. If the intent is to make such functions file-local, why not use the static keyword, or an anonymous namespace instead, so that they actually *are* local als

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-08 Thread Miklos Vajna
On Tue, Oct 09, 2012 at 08:59:47AM +0300, Tor Lillqvist wrote: > Where did this lcl_ convention come from? The lcl_ prefix has no > meaning to a compiler or linker. If the intent is to make such > functions file-local, why not use the static keyword, or an anonymous > namespace instead, so that th

Is the lcl_LocalFunction naming convention useful?

2012-10-08 Thread Tor Lillqvist
Where did this lcl_ convention come from? The lcl_ prefix has no meaning to a compiler or linker. If the intent is to make such functions file-local, why not use the static keyword, or an anonymous namespace instead, so that they actually *are* local also to the tool-chain? (You can still keep the