Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-11 Thread Michael Stahl
On 08/03/13 09:55, Markus Mohrhard wrote: On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote: The import for files written by gnumeric should map the values to the corresponding ODF values and during export we only want to export them as ODF and never into the gnumeric namespace. This

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-08 Thread Markus Mohrhard
Hey Eric, On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote: First we need to move the new values in CurveStyle.idl to the end and remove all the GNM_* values. Moving the values to the end ensures that the old values stay unchanged which causes as little trouble for extension

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-08 Thread Eric Seynaeve
Hello Markus, thanks for your review. On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote: First we need to move the new values in CurveStyle.idl to the end and remove all the GNM_* values. Moving the values to the end ensures that the old values stay unchanged which causes as little

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-06 Thread Markus Mohrhard
Hey Eric, I have added my first real code for submission to LO :-) It's in gerrit: https://gerrit.libreoffice.org/2476. I'm going to review it in the next days. so here is the inital review for your change. Your patch looks already quite good but there are some small changes necessary

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-06 Thread Markus Mohrhard
Anyway, I will now create a mock for the UI and discuss this on the UI list. Once this is done, what would be the best way to add the new UI functionality ? A friendly push in the right direction would save me quite some time ;-) You should design the dialogs nowadays with Glade.

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-04 Thread Eric Seynaeve
Hello Markus, I also want to add some debug code in what I have done, mainly to print a warning if new curve types are fed to LO. What's the best way to do that ? From https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Contro lling_Debug_Code I would think to add the

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-02 Thread Markus Mohrhard
Hey Eric, I have added my first real code for submission to LO :-) It's in gerrit: https://gerrit.libreoffice.org/2476. I'm going to review it in the next days. I looked on the LO website to find some pointers around in the code, but didn't really found it. My main helpers were OpenGrok

fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-01 Thread Eric Seynaeve
Hello everyone, I have added my first real code for submission to LO :-) It's in gerrit: https://gerrit.libreoffice.org/2476. It took me a while to find my way around the code and also to get used to the new possibilities in C++. I looked on the LO website to find some pointers around in the

Re: New feature in Calc: Stepped Lines graphs

2013-02-22 Thread Thorsten Behrens
Regina Henschel wrote: Where do I find that information? In the JIRA issue you quoted - https://tools.oasis-open.org/issues/browse/OFFICE-3662 :) Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list

Re: Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Eric Seynaeve
On Wednesday 20 February 2013 11:09:06 Regina Henschel wrote: In Gnumeric I see an interpolation with stepped lines. Is it that, what you want to get? If yes, then I would not implement them as new chart type in LO, but use the same way as in Gnumeric and make it a new kind of interpolation.

Re: Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Eric Seynaeve
On Wednesday 20 February 2013 11:09:06 Regina Henschel wrote: The specification is not written in a way, that some people image cool new features, but they look, what existing programs do. And those things which are common are standardized. Therefore LO has ODF1.2 extended and Gnumeric with

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Michael Stahl
On 20/02/13 22:11, Eric Seynaeve wrote: On Wednesday 20 February 2013 11:09:06 Regina Henschel wrote: The specification is not written in a way, that some people image cool new features, but they look, what existing programs do. And those things which are common are standardized. Therefore LO

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Regina Henschel
Hi Michael, hi Eric, Michael Stahl schrieb: On 20/02/13 22:11, Eric Seynaeve wrote: On Wednesday 20 February 2013 11:09:06 Regina Henschel wrote: The specification is not written in a way, that some people image cool new features, but they look, what existing programs do. And those things

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Regina Henschel
Hi Eric, Eric Seynaeve schrieb: On Wednesday 20 February 2013 11:09:06 Regina Henschel wrote: In Gnumeric I see an interpolation with stepped lines. Is it that, what you want to get? If yes, then I would not implement them as new chart type in LO, but use the same way as in Gnumeric

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Thorsten Behrens
Eric Seynaeve wrote: Regina, I looked at the xml in Gnumeric. It indicates it as follows: style:style ... style:chart-properties chart:interpolation=gnm:step-end.../ /style:style I guess the 'gnm:step-end' is a foreign element/attribute. Should I implement something similar for LO ?

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Thorsten Behrens
Regina Henschel wrote: I'm not sure whether the way Gnumeric does it, is grammatically correct. Perhaps it is necessary to make an own attribute LOchart:interpolation, which then allows more values. Thorsten might know it, and you should ask him. Prefixes in attribute values are meaningless

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Thorsten Behrens
I wrote: To your question, step-start, step-end, step-center-x, and step-center-y (without any prefix) are added as permissible values to ODF1.3 (thanks to Andreas Guelzow of Gnumeric fame), so I would simply go and use those. I would assume Gnumeric reads, or soonish will read, those. If it

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Regina Henschel
Hi Thorsten, Thorsten Behrens schrieb: [..] At any rate, the point is moot, since the additional values got accepted into ODF1.3 already,[..] Where do I find that information? Kind regards Regina ___ LibreOffice mailing list

Re: New feature in Calc: Stepped Lines graphs

2013-02-21 Thread Michael Stahl
On 21/02/13 15:43, Regina Henschel wrote: Michael Stahl schrieb: On 20/02/13 22:11, Eric Seynaeve wrote: style:style ... style:chart-properties chart:interpolation=gnm:step-end.../ /style:style I guess the 'gnm:step-end' is a foreign element/attribute. Should I implement something similar

New feature in Calc: Stepped Lines graphs

2013-02-20 Thread Eric Seynaeve
Hello everyone, in order to scratch my own itch, I started working on a stepped lines feature for XY graphs (and Line graphs) in Calc. See bugzilla 61135. This is my first coding in LO :-) Next steps would be to expose this functionality in the UI and check that it would be saved and read in

Re: New feature in Calc: Stepped Lines graphs

2013-02-20 Thread Regina Henschel
Hi Eric, Eric Seynaeve schrieb: Hello everyone, in order to scratch my own itch, I started working on a stepped lines feature for XY graphs (and Line graphs) in Calc. See bugzilla 61135 https://bugs.freedesktop.org/show_bug.cgi?id=61135. This is my first coding in LO :-) you are welcome.

Re: New feature in Calc: Stepped Lines graphs

2013-02-20 Thread Jan Holesovsky
Hi Eric, Regina Henschel píše v St 20. 02. 2013 v 11:09 +0100: in order to scratch my own itch, I started working on a stepped lines feature for XY graphs (and Line graphs) in Calc. See bugzilla 61135 https://bugs.freedesktop.org/show_bug.cgi?id=61135. This is my first coding in LO :-)

Re: Re: New feature in Calc: Stepped Lines graphs

2013-02-20 Thread Eric Seynaeve
On Wednesday 20 February 2013 14:04:12 Jan Holesovsky wrote: If you want to have user experience input on the changes, the best is to involve the guys at libreoffice-ux-adv...@lists.freedesktop.org, either to check what you have already done, or to work with them on the design. I'll do that