Hello Daniel,
>
> I'll take a look later today. If everything looks correct we are
> planning to merge these changes back to master as a little performance
> improvement for 3-6.
I reviewed the patches and they are really great. The only thing I
changed was getLength to isEmpty that I mentioned o
Hey Daniel.
> Did you guys have a chance to look at my
> changes to the ScXMLTableRowCellContext merge methods to determine if they
> are appropriate or not?
>
I'll take a look later today. If everything looks correct we are
planning to merge these changes back to master as a little performance
i
On 05/26/2012 10:22 AM, Markus Mohrhard wrote:
Hey Daniel,
2012/5/26 Daniel Bankston:
Hi, Kohei and Markus,
I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have
removed the ScDocFunc layer and simplified the whole method in general.
Great. I will have a look at it on Tuesda
On 05/26/2012 10:58 AM, Michael Meeks wrote:
On Sat, 2012-05-26 at 17:24 +0200, Markus Mohrhard wrote:
That is not planned. Only during import all the code in ScDocFunc does
not make much sense. We neither need to repaint areas nor do we need
undo/redo code.
Cool - yes, it's a nonsense
On Sat, 2012-05-26 at 17:24 +0200, Markus Mohrhard wrote:
> That is not planned. Only during import all the code in ScDocFunc does
> not make much sense. We neither need to repaint areas nor do we need
> undo/redo code.
Cool - yes, it's a nonsense to be doing all that pointless non-work o
Hey Michael,
> Oh - hmm. So - for the collaborative editing work we need a clean
> interface between user input (controller) and the model. So far we're
> using the ScDocFunc for that, and at least we need to intercept all UI
> editing at some suitably granular level through there.
>
>
Hey Daniel,
2012/5/26 Daniel Bankston :
> Hi, Kohei and Markus,
>
> I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have
> removed the ScDocFunc layer and simplified the whole method in general.
Great. I will have a look at it on Tuesday.
>
> As I mentioned to Kohei at some po
Hi Daniel,
On Sat, 2012-05-26 at 03:36 -0500, Daniel Bankston wrote:
> I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have
> removed the ScDocFunc layer and simplified the whole method in general.
Oh - hmm. So - for the collaborative editing work we need a clean
inter
Hi, Kohei and Markus,
I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have
removed the ScDocFunc layer and simplified the whole method in general.
As I mentioned to Kohei at some point, when I was originally removing
the UNO calls from the code, I was trying not to question
