Re: [PATCH] libzmf: Fix installation when using Doxygen 1.14

On 2025-05-29 09:29, Christoph Grüninger wrote: Installation of libzmf fails when the documentation is built using Doxygen 1.14. The latest Doxygen does no longer create PNG images and provides JavaScript files instead. Please find a proposed patch attached. Further, some changes to the build

[PATCH] libzmf: Fix installation when using Doxygen 1.14

Hello libzmf folks! Installation of libzmf fails when the documentation is built using Doxygen 1.14. The latest Doxygen does no longer create PNG images and provides JavaScript files instead. Please find a proposed patch attached. Further, some changes to the build system are attached, too

Re: Subject: [PATCH] Request for review - Fix for Bug 103035: Improved Header/Footer dialog UI

page as new patch sets. Also, if CI build fails for some reason, either related to your code or not, the solution is not sending that again with a different Change-Id. If the failure is related to your patch, it is expected that you fix your submission and send a new patch set in the same Gerrit

Subject: [PATCH] Request for review - Fix for Bug 103035: Improved Header/Footer dialog UI

Hi all, I’ve submitted a patch for Bug 103035 that improves the Header/Footer dialog UI related to text formatting in LibreOffice Calc. Gerrit link: https://gerrit.libreoffice.org/c/core/+/184177 Just to share a bit — before this patch, I tried fixing three other bugs. Even though I wrote code

epm patch which reduces cpu and storage consumption for the default deb packages

Hello. I proposed a patch for the epm external software which is integrated on master. This lowers the size of the default debian package files which are provided on https://www.libreoffice.org/ . The modified deb.c file uses the dpkg-deb and xz environment variables in order to deal with

Subject: Request for code review on tdf#103405 patch (LibreOffice GSoC)

Hi Ilmari, I hope you're doing well. I’ve submitted a cleaned-up patch for tdf#103405, which replaces sal_uLong with auto in vclhelperbufferdevice.cxx. It has passed Jenkins and is now awaiting review: Patch link: https://gerrit.libreoffice.org/c/core/+/183998 I’d be grateful if you could

GSoC 2025 Proposal Update: Patch Submitted for Easy Hack (Bug 34465)

Dear LibreOffice Developers, I’m writing to share an update regarding my GSoC 2025 proposal titled: "Incremental Modernization of LibreOffice Core: Converting 500+ Manual Loops Safely" As part of the qualification process, I’ve submitted a patch for an Easy Hack: 🔗 Patch L

Re: Again missing patch on LibO core master

Does he look good in it? On Thu, 28 Nov 2024 at 3:30 AM, Julien Nabet wrote: > Hello Andreas, > > Cherry-pick on master waiting for review here: > https://gerrit.libreoffice.org/c/core/+/177445 > > Julien > >

Re: Again missing patch on LibO core master

Hello Andreas, Cherry-pick on master waiting for review here: https://gerrit.libreoffice.org/c/core/+/177445 Julien

Again missing patch on LibO core master

Hi all, I had to investigate again about patches that didn't make it to LibreOffice core, branch master. And I found out that the API change with commit: https://gerrit.libreoffice.org/c/core/+/176715 is missing on master. I tested this patch on my local LibreOffice build and it b

Re: Missing Patch on LibO core master again

Hi Miklos, hi all, Am 20.11.24 um 08:52 schrieb Miklos Vajna: Hi, On Tue, Nov 19, 2024 at 11:44:10PM +0100, Andreas Mantke wrote: which changes the table design. The changes were committed with patch '7ea2394e7b4370186c58001549a51acb58c7e49f' https://gerrit.libreoffice.org/c/cor

Re: Missing Patch on LibO core master again

Hi, On Tue, Nov 19, 2024 at 11:44:10PM +0100, Andreas Mantke wrote: > which changes the table design. The changes were committed with patch > '7ea2394e7b4370186c58001549a51acb58c7e49f' > https://gerrit.libreoffice.org/c/core/+/174433 https://gerrit.libreoffice.org/c/core/+

Missing Patch on LibO core master again

Hi all, I had to investigate again about patches that didn't make it to LibreOffice core, branch master. I found out that there are changes in: sc/source/ui/unoobj/docuno.cxx which changes the table design. The changes were committed with patch '7ea2394e7b4370186c58001549a51acb58c7e

Re: GSoC: Libreoffice Theme (VCL_WIN Patch)

ge in the codebase that I am not aware of, or it's something from QT's side. https://gerrit.libreoffice.org/c/core/+/168016/33 (Part 1 of the patch series. all the others are in a relation chain). Regards Sahil Gautam

Re: Missing Patch Of LOK in LibreOffice Core Repo

Hi Andreas, On Sun, Jul 21, 2024 at 06:46:52PM +0200, Andreas Mantke wrote: > I looked into the LibreOffice core repository about the current state of > LOK and stumbled over a patch that didn't make into the LibreOffice > master since May 2024: > https://gerrit.libreoffice.or

Re: GSoC: Libreoffice Theme (VCL_WIN Patch)

as vcl_osx is done. All the files involved have messed up permissions in the patch for some reason (all are shown as executables). It says "file mode changed from regular to executable". [PATCH] https://gerrit.libreoffice.org/c/core/+/170840 Regards Sahil Gautam

Missing Patch Of LOK in LibreOffice Core Repo

Hi all, I looked into the LibreOffice core repository about the current state of LOK and stumbled over a patch that didn't make into the LibreOffice master since May 2024: https://gerrit.libreoffice.org/c/core/+/167858 Maybe it has been overlooked to send the commit also to the LibreOffice

Patch that adds NeoOffice code to existing LibreOffice code needs review

I have submitted, but not committed, the following patch that basically copies a fix for a macOS bug from the NeoOffice codebase: https://gerrit.libreoffice.org/c/core/+/170426 The copied code is available under the MPL 2.0 license so I assume that it is OK to add the inline fix in the

Re: Can someone review a patch to fix the audio in PPTX?

Hi Vladislav, On Tue, Mar 12, 2024 at 03:08:23PM +0300, Владислав Тараканов wrote: > irgalie...@mail.ru and I recently sent a patch that adds launching media > files in presentation mode from the presentation directory if they were not > found in the absolute path. At the moment

Can someone review a patch to fix the audio in PPTX?

Hello. irgalie...@mail.ru and I recently sent a patch that adds launching media files in presentation mode from the presentation directory if they were not found in the absolute path. At the moment, we have implemented functionality only for GStreamer. Before adding implementations for

Re: Missing Patch Inside LibreOffice Core Branch Master

Hi Andreas, On Wed, Dec 27, 2023 at 02:50:58PM +0100, Andreas Mantke wrote: > I found out again that at least one patch didn't make it to the > LibreOffice core repository, branch master: > https://gerrit.libreoffice.org/c/core/+/160022 > > I hope this is a lapse again and

Missing Patch Inside LibreOffice Core Branch Master

Hi all, I found out again that at least one patch didn't make it to the LibreOffice core repository, branch master: https://gerrit.libreoffice.org/c/core/+/160022 I hope this is a lapse again and it would be good to have this patch in the LibreOffice core master tree too. It's curr

Re: Missing Patch Inside LibreOffice Core Master Branch

Hi Andreas, On Thu, Aug 10, 2023 at 09:05:06PM +0200, Andreas Mantke wrote: > I looked on the LibreOffice Gerrit and found out that a patch of the > LibreOffice kit has not been committed to the LibreOffice master branch: > https://gerrit.libreoffice.org/c/core/+/155282 > > I

Missing Patch Inside LibreOffice Core Master Branch

Hi all, I looked on the LibreOffice Gerrit and found out that a patch of the LibreOffice kit has not been committed to the LibreOffice master branch: https://gerrit.libreoffice.org/c/core/+/155282 I think it would only a lapse that it didn't make it only in branch but not into the m

Patch in Gerrit to bring Spanish dictionaries up to current version 2.7

Hi, I don't know whether it is needed or not to announce it here, but, just in case, I've just committed this changeset to Gerrit to update shipped Spanish spellcheck dictionaries to our current version 2.7: https://gerrit.libreoffice.org/c/dictionaries/+/145025 Thanks in advance, and Happy New

[RESOLVED] Re: Error when trying to submit patch on gerrit (No space left on device)

On 03/09/2022 09:12, Julien Nabet wrote: Hello, This morning when trying to submit a patch, I got: no branch specified, guessing current branch master Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 12 threads Compressing objects: 100% (6/6

Error when trying to submit patch on gerrit (No space left on device)

Hello, This morning when trying to submit a patch, I got: no branch specified, guessing current branch master Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 12 threads Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 622

Re: Improve WriteCustomGeometry in oox export; review of patch

Hi Regina, On Thu, Mar 24, 2022 at 07:33:24PM +0100, Regina Henschel wrote: > The commit message is quite detailed. If something is still unclear, please > send me a mail. Not only that, but the various test files you added in the tests also helped to understand the problem you solve. Thanks fo

Improve WriteCustomGeometry in oox export; review of patch

Hi Miklos, hi all, the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready for review. It is a change in the way a custGeom element is generated. I have dropped the export via PolyPolygon. Instead our path commands are directly mapped to oox path commands. That is a larger

Re: submit a revised patch to an abandoned gerrit change

imply submit a new patch and refer to the abandoned one (I have no need for elevated permissions). Winfried I think the issue will be, however, that the authorship information will have been diluted. I guess if you note in the commit message who the original author was and that you adapted it

Re: submit a revised patch to an abandoned gerrit change

> On 13 Jan 2022, at 12:11 am, Winfried Donkers > wrote: > >  >> >>> I have the same menu, but just next to the menu button (the vertical ...), >>> on the left side, there is also a RESTORE button. >>> >> Might only work for own patches.

Re: submit a revised patch to an abandoned gerrit change

I have the same menu, but just next to the menu button (the vertical ...), on the left side, there is also a RESTORE button. Might only work for own patches. OK, thanks all, I'll simply submit a new patch and refer to the abandoned one (I have no need for elevated permissions). Winfried

Re: submit a revised patch to an abandoned gerrit change

Jan-Marek Glogowski wrote: > I have the same menu, but just next to the menu button (the vertical ...), > on the left side, there is also a RESTORE button. > Might only work for own patches. Cheers, -- Thorsten signature.asc Description: PGP signature

Re: submit a revised patch to an abandoned gerrit change

On 12.01.22 08:56, Jan-Marek Glogowski wrote: On 12.01.22 07:22, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any rest

Re: submit a revised patch to an abandoned gerrit change

On 12.01.22 07:22, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button; in menu I see Cherry pick, Download

Re: submit a revised patch to an abandoned gerrit change

Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button; in menu I see Cherry pick, Download patch and Ignore. Winfried

Re: submit a revised patch to an abandoned gerrit change

On 11.01.22 16:16, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try?

submit a revised patch to an abandoned gerrit change

h the (still unresolved) bug report. I made changes to the patch and would like to submit 'my' patch to the same gerrit change with me and the original contributor as co-authors. However, gerrit won't accept the patch I submitted because the status of the change is 'abandoned&

Re: Need help with patch for Fontwork shape

Hi Miklos, thank you for starting a next try to build. The build was now successful. Kind regards Regina Regina Henschel schrieb am 12.10.2021 um 17:00: Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change was then a

Need help with patch for Fontwork shape

Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change was then a change in the commit message. But now it fails with always the same problem. I know Jenkins has a "hiccup" sometimes and tried a Rebase. B

Re: cppunit Patch feature-modernize

t 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize > <https://github.com/VXAPPS/cppunit/tree/feature-modernize> > > If you have suggestions, p

Re: cppunit Patch feature-modernize

t 5:59 PM Florian Becker > <mailto:f...@vxapps.com>> wrote: >> Hello, >> >> i have patched the libcppunit 1.15.1 to modernize and use clang flags >> with highest flag settings. Hopefully you can integrate this patch >> inside master. https://github.com/VXA

Re: cppunit Patch feature-modernize

lt; > markus.mohrh...@googlemail.com> wrote: > >> Hey Florian, >> >> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker wrote: >> >>> Hello, >>> >>> i have patched the libcppunit 1.15.1 to modernize and use clang flags >>> wi

Re: cppunit Patch feature-modernize

dernize and use clang flags >>> with highest flag settings. Hopefully you can integrate this patch >>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize >>> >>> If you have suggestions, please let me know. >> >> I'll h

Re: cppunit Patch feature-modernize

flags >> with highest flag settings. Hopefully you can integrate this patch >> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize >> >> If you have suggestions, please let me know. >> > > I'll have a look during the next few days and will

Re: cppunit Patch feature-modernize

Hey Florian, On Tue, Sep 28, 2021 at 5:59 PM Florian Becker wrote: > Hello, > > i have patched the libcppunit 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/fe

Re: cppunit Patch feature-modernize

Hi Florian, On Mon, Sep 27, 2021 at 05:27:56PM +, Florian Becker wrote: > i have patched the libcppunit 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/feature-

cppunit Patch feature-modernize

Hello, i have patched the libcppunit 1.15.1 to modernize and use clang flags with highest flag settings. Hopefully you can integrate this patch inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize If you have suggestions, please let me know. Regards, Florian

Code Reviewer needed to review patch

I need a code reviewer for a patch I submitted to gerrit for bug tdf#104169 <https://bugs.documentfoundation.org/show_bug.cgi?id=104169>. Patch : https://gerrit.libreoffice.org/c/core/+/114679 Bug : https://bugs.documentfoundation.org/show_bug.cgi?id=104169 The bug is a difficultyInter

Re: proposition for patch in CommonSalLayout.cxx

Stanisław Jeśmanowicz wrote >> > This is not always the case, because if a platform didn't include > graphite2 shaper in its HarfBuzz > implementaion, you won't have it anyway ( like ./configure > --with-graphite2=no ) > Even if you set it the shapers list (as in > https://cgit.freedesktop.org/li

Re: proposition for patch in CommonSalLayout.cxx

Stanisław Jeśmanowicz wrote > ... > Thank you for your advice, but getting familiar with gerrit on top of git > would take some time for > me now. > I hope, that some of your developers could commit this patch for me in vcl > module. > It is simple and won't harm an

Re: proposition for patch in CommonSalLayout.cxx

On 9.3.2021 20.51, Stanisław Jeśmanowicz wrote: On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me

Re: proposition for patch in CommonSalLayout.cxx

On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me in vcl module. It is simple and won't

Re: proposition for patch in CommonSalLayout.cxx

Hello Julien, On 3/9/21 9:18 AM, julien2412 wrote: Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patc

Re: proposition for patch in CommonSalLayout.cxx

Hello Miklos, On 3/9/21 9:14 AM, Miklos Vajna wrote: Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached to

Re: proposition for patch in CommonSalLayout.cxx

Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patch. So you only need now a gerrit account and submit

Re: proposition for patch in CommonSalLayout.cxx

Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: > Dear all, > > I noticed that LibreOffice is using the hard coded harfbuzz shapers list in > CommonSalLayout.cxx file (line 470). > I recommend the patch attached to be more flexible. > This

proposition for patch in CommonSalLayout.cxx

Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached to be more flexible. This take all possible shapers in a given HarfBuzz implementation. This also allows the use of newly created shapers

Patch: fix unpack-sources to not require GNU find

Requesting review. Patch submitted here a few months ago: https://gerrit.libreoffice.org/c/core/+/107936 The find that comes with macOS is BSD find and does not have -printf. On macOS: $ man /usr/share/man/man1/find.1 | grep -F printf (No results) On Linux: $ man /usr/share/man/man1/find.1

Re: Fwd: Need help implementing a patch

Heiko gave advice already. Ilmari On 23.11.2020 17.29, Xisco Fauli wrote: Adding dev list On 23/11/20 16:22, Xisco Fauli wrote: forwarding this to the dev and ux lists for a wider audience. Forwarded Message Subject:Need help implementing a patch Date: Thu, 19

Re: Fwd: Need help implementing a patch

Adding dev list On 23/11/20 16:22, Xisco Fauli wrote: > > forwarding this to the dev and ux lists for a wider audience. > > > > Forwarded Message > Subject: Need help implementing a patch > Date: Thu, 19 Nov 2020 20:30:20 -0300 > From

Re: [PATCH] Remove leftover cast of fResolutionDPI

Hi, Am 11.11.20 um 19:30 schrieb Brett T. Warden: > When building with --disable-pdfium, compilation fails due to a > reference to fResolutionDPI, which is now only defined within the > #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. Already fixed? https://cgit.freedesktop.org

Re: [PATCH] Remove leftover cast of fResolutionDPI

Brett T. Warden kirjoitti 11.11.2020 klo 20.30: When building with --disable-pdfium, compilation fails due to a reference to fResolutionDPI, which is now only defined within the #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. --- vcl/source/filter/ipdf/pdfread.cxx | 1 - 1

[PATCH] Remove leftover cast of fResolutionDPI

When building with --disable-pdfium, compilation fails due to a reference to fResolutionDPI, which is now only defined within the #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. --- vcl/source/filter/ipdf/pdfread.cxx | 1 - 1 file changed, 1 deletion(-) diff --git a/vcl/source

Re: Patch review

anshu khare kirjoitti 10.11.2020 klo 16.27: Hi Please review my patch https://gerrit.libreoffice.org/c/core/+/105501 I have tested it. It's working fine. Please merge it. You did not address Jim's comment: "Please see https://stackoverflow.com/questions/1967370/git-replaci

Patch review

Hi Please review my patch https://gerrit.libreoffice.org/c/core/+/105501 I have tested it. It's working fine. Please merge it. Thanks in advance ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/ma

New submitted patch

Hi, I have submitted my second patch on Gerrit, Here it is: https://gerrit.libreoffice.org/c/core/+/104461 It is about using " #pragma once" instead of guards, I am asking for reviewers to check what I have made. Thanks in advance. ___ L

Patch review

Hi, Could you please review my patch : https://gerrit.libreoffice.org/c/core/+/103632 Thanks and Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch Review

Hi, I have worked on Bug 134779 - Entering a table with too many columns causing Writer to lock up. Please review my patch. https://gerrit.libreoffice.org/c/core/+/101561 Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Patch review

Hi mentors, Please check https://gerrit.libreoffice.org/c/core/+/101242 I have worked on the Bug 87963 Thank you Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 9:34, Roland Illig wrote: > On 19.05.2020 07:32, Mike Kaganski wrote: >> >> See >> https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html >> > > Thanks for this pointer.  I had previously bailed out when I had t

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 07:32, Mike Kaganski wrote: On 19.05.2020 2:28, Jan-Marek Glogowski wrote: Am 18.05.20 um 20:57 schrieb Roland Illig: On 18.05.2020 09:21, Miklos Vajna wrote: Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools jus

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 2:28, Jan-Marek Glogowski wrote: > Am 18.05.20 um 20:57 schrieb Roland Illig: >> On 18.05.2020 09:21, Miklos Vajna wrote: >>> Could you please push your patch to gerrit? >> >> Nope. I won't clone a 1 GB repository and install several tools just

Re: [PATCH] libetonyek: std::for_each

Am 18.05.20 um 20:57 schrieb Roland Illig: > On 18.05.2020 09:21, Miklos Vajna wrote: >> Could you please push your patch to gerrit? > > Nope. I won't clone a 1 GB repository and install several tools just for > fixing a single line of code. It's much more efficient

Re: [PATCH] libetonyek: std::for_each

On 18.05.2020 09:21, Miklos Vajna wrote: Hi Roland, Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools just for fixing a single line of code. It's much more efficient if you do that, since you already have all the infrastruct

Re: [PATCH] libetonyek: std::for_each

Hi Roland, Could you please push your patch to gerrit? See <https://wiki.documentfoundation.org/Development/gerrit/setup>. It's much easier to take patches from there. Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.free

[PATCH] libetonyek: std::for_each

NUM3Parser.cpp: In member function 'virtual bool libetonyek::NUM3Parser::parseDocument()': NUM3Parser.cpp:46:3: error: 'for_each' is not a member of 'std' std::for_each(sheetListRefs.begin(), sheetListRefs.end(), std::bind(&NUM3Parser::parseSheet, this, std::placeholders::_1)); std::for_each n

[SOLVED] Re: Patch ok locally but fails on gerrit

Thank you Miklos and Stephan (who responded on gerrit). The use of rtl::isSurrogate() avoids to call ICU libs from starmath. Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing l

Patch ok locally but fails on gerrit

Hello, I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013) with https://gerrit.libreoffice.org/c/core/+/91941. The pb is it builds ok locally but it fails on Jenkins, eg on Linux gcc: [build LNK] Library/li

Re: Patch ok locally but fails on gerrit

Hi Julian, On Thu, Apr 09, 2020 at 12:20:30AM -0700, julien2412 wrote: > I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at > SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013) > with https://gerrit.libreoffice.org/c/core/+/91941. > The pb is it builds o

Cannot review Gerrit patch

Regina Henschel wrote on Fri Jan 3 01:15:56 UTC 2020: > I can confirm, that it does not work in the old UI. The old UI works as expected now, see this issue: [1]. [1] https://redmine.documentfoundation.org/issues/3068 ___ LibreOffice mailing list Libr

Re: Cannot review Gerrit patch

Hi Chris, I can confirm, that it does not work in the old UI. Chris Sherlock schrieb am 02-Jan-20 um 23:01: On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: Hey Chris, Chris Sherlock wrote: Quick ping. Anyone able to assist? Not really - seems to work fine here, though not using the o

Re: Cannot review Gerrit patch

On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: > > Hey Chris, > > Chris Sherlock wrote: >> Quick ping. Anyone able to assist? >> > Not really - seems to work fine here, though not using the old UI. > > Cheers, > > — Thorsten Cool. Out of interest, how on earth do I get back to the new U

Re: Cannot review Gerrit patch

Hey Chris, Chris Sherlock wrote: > Quick ping. Anyone able to assist? > Not really - seems to work fine here, though not using the old UI. Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.fr

Re: Cannot review Gerrit patch

On 30 Dec 2019, at 10:06 pm, Chris Sherlock wrote: > > Hi all, > > Does anyone know why I can’t review the following? > > https://gerrit.libreoffice.org/#/c/core/+/83439/ > > > I click on the hex/cxx files and it doesn’t open in the old clas

Cannot review Gerrit patch

Hi all, Does anyone know why I can’t review the following? https://gerrit.libreoffice.org/#/c/core/+/83439/ I click on the hex/cxx files and it doesn’t open in the old classic UI. Any ideas? Chris

review for patch for tdf#127785 Apply 180deg compensation for flipV to text range

Hi all, because my first attempt to fix the error was wrong, I have made a new proposal in https://gerrit.libreoffice.org/#/c/80310/ To be sure, that it is correct now, it would be nice, if you review the patch. Some comments and test documents are in the bug report. But perhaps you know

Re: Reverting patch

respective branch How to "build the respective branch" ? After you have checked out the gerrit patch, you can build it the same way as you build master, i.e. run './autogen.sh' and then 'make'. The checkout will be the branch that the gerrit patch has been cherry-picke

Re: Reverting patch

branch > > How to "build the respective branch" ? After you have checked out the gerrit patch, you can build it the same way as you build master, i.e. run './autogen.sh' and then 'make'. The checkout will be the branch that the gerrit patch has been cherry-picked to, e

Re: Reverting patch

On Wed, 2019-08-21 at 21:44 +0200, Regina Henschel wrote: > > The "cherry pick" button in Gerrit provides "LibreOffice 6-3", > "LibreOffice 6-3-0" and "LibreOffice 6-3-1". Which item would be the > correct one? 6.3.0 is released so ignore 6-3-0 Cherry-pick to 6-3 first to get it into the 6-3 b

Re: Reverting patch

Hi Regina, On 21/08/2019 21.44, Regina Henschel wrote: > it is about https://gerrit.libreoffice.org/#/c/77882/ > That reverts a patch, that I had made 9 months ago, because it had > introduced a regression, see bug 126271. I have submitted the revert to > master. > > U

Reverting patch

Hi all, it is about https://gerrit.libreoffice.org/#/c/77882/ That reverts a patch, that I had made 9 months ago, because it had introduced a regression, see bug 126271. I have submitted the revert to master. Unfortunately, this regression is in LibreOffice 6.3 too. Of cause I have tested

SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO

Hello all, I would like to ask if I or any other from OpenOffice Development team can port the patch from LibreOffice to OpenOffice to fix this Issue under the APL2 License, so the Issue can be fixed in OpenOffice without more work then necessary. LO Issue: 114939 OO Issue: 127661 Thanks for

Fwd: [PATCH] Add content_rating to AppData files

FYI. If anybody thinks the answers I picked below are sufficiently wrong: please comment. Forwarded Message Subject: [PATCH] Add content_rating to AppData files Date: Mon, 20 May 2019 09:13:54 +0200 From: Stephan Bergmann (via Code Review) Reply-To: sberg...@redhat.com CC

Re: Question about submitting patch for dictionaries

On 05.05.19 14:33, julien2412 wrote: Hello, I'm trying to submit a patch for dictionaries part. In /dictionaries I typed this: ../logerrit submit After several minutes, it's still trying to send the patch. Did I miss something? apparently there was some network routing problem

Re: Question about submitting patch for dictionaries

I gave a try to https://wiki.documentfoundation.org/Development/Submodules but it finally really pushed directly the patch. However, I had also took a look to the content of loggerrit and saw that "submit" was calling "push". So I'm a bit confused... If my patch is wrong,

Question about submitting patch for dictionaries

Hello, I'm trying to submit a patch for dictionaries part. In /dictionaries I typed this: ../logerrit submit After several minutes, it's still trying to send the patch. Did I miss something? I know there is this page https://wiki.documentfoundation.org/Development/Submodules but

Re: Permission not granted to push my patch

Il 04/05/2019 11:49, Kaganski Mike ha scritto: > Hi, > > On 04.05.2019 12:45, Cyrille wrote: >> I tried: >> git push ssh://lafric...@gerrit.libreoffice.org:29418/dictionaries >> HEAD:refs/for/master >> >> I got now this error: >> remote: Resolving deltas: 100% (1/1) >> remote: Processing changes

Re: Permission not granted to push my patch

Hi, On 04.05.2019 12:45, Cyrille wrote: > I tried: > git push ssh://lafric...@gerrit.libreoffice.org:29418/dictionaries > HEAD:refs/for/master > > I got now this error: > remote: Resolving deltas: 100% (1/1) > remote: Processing changes: refs: 1, done > remote: ERROR: [b5f81e8] missing Change-Id

Re: Permission not granted to push my patch

I tried: git push ssh://lafric...@gerrit.libreoffice.org:29418/dictionaries HEAD:refs/for/master I got now this error: remote: Resolving deltas: 100% (1/1) remote: Processing changes: refs: 1, done    remote: ERROR: [b5f81e8] missing Change-Id in commit message footer remote: remote: Hint: To auto

  1   2   3   4   5   6   7   8   9   10   >