Re: Patch: Fix bug 90222 - Replace ScaList with std container

2015-07-30 Thread Eike Rathke
Hi Ryan, On Thursday, 2015-07-30 14:25:04 +1200, Ryan McCoskrie wrote: Apparently we don't have your license statement on file I've already done that. http://lists.freedesktop.org/archives/libreoffice/2014-September/063297.html Don't know why I missed that in

Re: Patch: Fix bug 90222 - Replace ScaList with std container

2015-07-29 Thread Ryan McCoskrie
On Wednesday, July 29, 2015 03:27:07 PM Eike Rathke wrote: On Wednesday, 2015-07-29 22:45:18 +1200, Ryan McCoskrie wrote: (I'm having trouble with logerrit) That is why? We much prefer patches on gerrit, it eases review and handling a lot. Using git review might also be an option for you.

Patch: Fix bug 90222 - Replace ScaList with std container

2015-07-29 Thread Ryan McCoskrie
(I'm having trouble with logerrit) This replaces the ScaList class used in scaddins with/source with std::vector. Odd issues: - I've written a wrap around to std::vectorScaFuncData* since the original ScaFuncDataList class would generate its contents in the constructor and supported looking

Re: Patch: Fix bug 90222 - Replace ScaList with std container

2015-07-29 Thread Eike Rathke
Hi Ryan, Thanks for your patch! On Wednesday, 2015-07-29 22:45:18 +1200, Ryan McCoskrie wrote: (I'm having trouble with logerrit) That is why? We much prefer patches on gerrit, it eases review and handling a lot. Using git review might also be an option for you. If for some reason you *have*