On Mon, Feb 4, 2013 at 9:33 PM, Marc Paré wrote:
> We have added the gerrit section of the release notes page to the website
> "4.0 Release Notes" page[1] but one of the nl site maintainers has pointed
> out that the section:
>
>
> ssh logerrit gerrit query status:merged|grep change|wc -l for numb
We have added the gerrit section of the release notes page to the
website "4.0 Release Notes" page[1] but one of the nl site maintainers
has pointed out that the section:
ssh logerrit gerrit query status:merged|grep change|wc -l for number of
merged patches
will not allow a user to see any
On Thu, 2013-01-03 at 11:10 +0100, Matteo Casalin wrote:
> 827 if( bSynchron )
> 828 {
> 829 if( mnUpdateTagsEvent )
> 830 Application::RemoveUserEvent( mnUpdateTagsEvent );
> 831
> 832 UpdateTagsHdl(0);
>
> I think that UpdateTagsHdl should be called unco
ists.freedesktop.org'
Subject: Re: [libreoffice-dev] - architecture question about
interproces,extension,addIn
hi Neeraj,
On 03/01/13 16:54, Rai, Neeraj wrote:
> Based on above text, I looked at addIns but it doesn't seem like what I
> need. I don't want to be restricted to a function
libreoffice-dev] - architecture question about
interproces,extension,addIn
hi Neeraj,
On 03/01/13 16:54, Rai, Neeraj wrote:
> Based on above text, I looked at addIns but it doesn't seem like what I
> need. I don't want to be restricted to a function call. I need a
> com
hi Neeraj,
On 03/01/13 16:54, Rai, Neeraj wrote:
> Based on above text, I looked at addIns but it doesn't seem like what I
> need. I don't want to be restricted to a function call. I need a
> component running in scalc.
>
> _http://wiki.openoffice.org/wiki/Documentation/DevGuide/Spreadsh
On 02/01/13 10:11, Lionel Elie Mamane wrote:
> C++11 has a specific syntax to achieve mostly the same effect more
> cleanly:
>
> OXMLCell& operator =(const OXMLCell&) = delete;
>
> That's slightly better since it tells the compiler that this class
> should have *no* assignment operator. So any
Hi all, and my best wishes for 2013!
While browsing through code, I noticed that
sd/source/ui/annotations/annotationmanager.cxx presents poor
indentation. I have a doubt on the following function, line 832:
825 void AnnotationManagerImpl::UpdateTags( bool bSynchron )
826 {
827 if( bSynchr
Hi ,
I need some advise on which libreoffice technology to use.
I need to update data from some of our processes to scalc. I would like to use
sockets to transfer data.
Preference is for running my own code in scalc that can parse the data sent by
my other processes. Speed is important to me.
R
On Wednesday 02 of January 2013, Lionel Elie Mamane wrote:
> C++11 has a specific syntax to achieve mostly the same effect more
> cleanly:
>
> OXMLCell& operator =(const OXMLCell&) = delete;
>
> That's slightly better since it tells the compiler that this class
> should have *no* assignment opera
On Sun, Dec 30, 2012 at 09:58:30PM +0100, Julien Nabet wrote:
> On 30/12/2012 21:48, Markus Mohrhard wrote:
>>>Cppcheck reported this:
>>>[reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style)
>>>'OXMLComponent::operator=' should return 'OXMLComponent&'.
>>>[reportdesign/source/filter/xml/x
On 30/12/2012 21:48, Markus Mohrhard wrote:
Hey,
Cppcheck reported this:
[reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style)
'OXMLComponent::operator=' should return 'OXMLComponent&'.
[reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style)
'OXMLFunction::operator=' should return
Hey,
> Cppcheck reported this:
> [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style)
> 'OXMLComponent::operator=' should return 'OXMLComponent &'.
> [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style)
> 'OXMLFunction::operator=' should return 'OXMLFunction &'.
> [reportdesign/s
ng to fix these, I noticed that none of them was implemented. So can
they just be removed, is it another C++ "trick", or something obvious I
missed?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-oper
On 30/12/2012 18:24, Markus Mohrhard wrote:
Hey,
Cppcheck reported this:
[sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable
'bIsDec2' can be reduced
Here are the lines:
2651 while( bValid&& (nCharIndex< nCharCount) )
2652 {
2653
Hey,
>
> Cppcheck reported this:
> [sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable
> 'bIsDec2' can be reduced
>
> Here are the lines:
>2651 while( bValid && (nCharIndex < nCharCount) )
>2652 {
>2653 sal_uInt16 nDigit1 = 0;
>265
t;, or
something is wrong here.
Any idea?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-sc-source-core-tool-interpr2-cxx-and-lcl-GetArabicValue-tp4026584.html
Sent from the Dev mailing list archive at Nabble.com.
_
Thank you Michael for your answer.
I've created a cppcheck ticket about it. (see
https://sourceforge.net/apps/trac/cppcheck/ticket/4425)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-cppcheck-report-on-SwCrsrShell-GetSmartTagTerm-tp4025236p40
On 20/12/12 00:15, julien2412 wrote:
> Hello,
>
> Cppcheck reported this:
> [source/core/crsr/crsrsh.cxx:3357] -> [source/core/crsr/crsrsh.cxx:3365]:
> (performance) Variable 'rContent' is reassigned a value before the old one
> has been used.
>
> Indeed, we have these lines:
>3356
rContent = nWordEnd - 1; <-- Assignation 3 without
having used Assignation2
http://opengrok.libreoffice.org/xref/core/sw/source/core/crsr/crsrsh.cxx#3357
Any idea what to do with these assignations?
Julien
--
View this message in context:
http://nabble.documentfound
pPt3->Y()-=dy2/3;
and Opengrok:
http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdoedge.cxx#1436
Either pPt1 and pPt4 assignations may really be removed or a change must be
done here.
Any idea?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-cp
On Sat, 2012-12-15 at 06:19 -0800, julien2412 wrote:
> Should it be (sValue[0] == 'e' || sValue[0] == 'E')
Yeah, that's what I had in mind. Fixed now, thanks for that :-)
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.f
Hi julien2412,
On Saturday, 2012-12-15 01:30:04 -0800, julien2412 wrote:
> Either first bDisable is useless or the result of it should be used for the
> next line?
Indeed, that's missing a condition like in the other cases.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=63e10bf2383d22a5
Le Sat, 15 Dec 2012 21:43:41 +0100, Markus Mohrhard
a écrit:
Hey Mat,
[...]
Maybe your confusion comes from using ^ at the wrong place. Try git
diff
4f901a2f451a552853c1dd38309dd55b22616fdd^..4f901a2f451a552853c1dd38309dd55b22616fdd
Dammit! Git should know it and fix it by himself! :
Hey Mat,
>>
>>
>> Implemented a correct version with
>> 4f901a2f451a552853c1dd38309dd55b22616fdd.
>
>
> Sorry but what I see in 4f901a2f45 is the same thing as Julien pasted in his
> mail.
> It rollback the good version:
I don't understand your q
Hello Markus
Le Sat, 15 Dec 2012 15:39:26 +0100, Markus Mohrhard
a écrit:
Hey,
I noticed these lines in file sc/source/core/data/colorscale.cxx
(because cppcheck report indicates that bNeedUpdate is reassigned
before to
be used line 641)
637 void ScDataBarFormat::DataChanged(const
On 15/12/2012 15:39, Markus Mohrhard wrote:
Hey,
I noticed these lines in file sc/source/core/data/colorscale.cxx
(because cppcheck report indicates that bNeedUpdate is reassigned before to
be used line 641)
637 void ScDataBarFormat::DataChanged(const ScRange& rRange)
638 {
639
Hey,
> I noticed these lines in file sc/source/core/data/colorscale.cxx
> (because cppcheck report indicates that bNeedUpdate is reassigned before to
> be used line 641)
>
> 637 void ScDataBarFormat::DataChanged(const ScRange& rRange)
> 638 {
> 639 bool bNeedUpdate = false;
> 6
_END : VCL_PACK_START;
1895 pCurrent->set_pack_type(ePackType);
1896 }
Should it be (sValue[0] == 'e' || sValue[0] == 'E'), just sValue[0] == 'e'
or something else?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Q
text:
http://nabble.documentfoundation.org/Question-about-sc-source-ui-view-cellsh-cxx-tp4024486.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
())) ||
(GetRange().Intersects(rRange)) )
{
mpDoc->RepaintRange(GetRange());
}
What do you think?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-sc-source-core-data-colorscale-cxx-tp4024485.html
Sent from th
Hi ,
I posted this to users list but now I think this is more of a developers
questions. Please correct me if this is not the right forum.
I am trying to convert scalc.java to c++.
Scalc.java comes with libreoffice and I am able to build and run it using the
makefile provided.
I am also able to
On Sat, Nov 10, 2012 at 06:23:02PM -0500, William Park
wrote:
> As a way of learning LibreOffice Spreadsheet code, I would like to add a
> simple file import/export. The file format is sort of 3-column CSV
> format. Can someone point me to directory/file I should look at?
This is done in gener
Hi William,
On Sat, 2012-11-10 at 18:23 -0500, William Park wrote:
> As a way of learning LibreOffice Spreadsheet code, I would like to add a
> simple file import/export. The file format is sort of 3-column CSV
> format. Can someone point me to directory/file I should look at?
Certainly
Hi all,
As a way of learning LibreOffice Spreadsheet code, I would like to add a
simple file import/export. The file format is sort of 3-column CSV
format. Can someone point me to directory/file I should look at?
--
William
___
LibreOffice mailing lis
On 11/03/2012 11:11 PM, Steven Marguet wrote:
I have difficulties to create a PolyLineShape using the Pyhton API of
LibreOffice (in the Draw application).
In fact, I don't know what kind of data structure I have to used for the
points of the PolyLineShape I want to create.
Here is my code :
===
Hello to everyone,
I don't know if this mailing list is also for the scripting abilities of
LibreOffice. If it's not I appologize.
I have difficulties to create a PolyLineShape using the Pyhton API of
LibreOffice (in the Draw application).
In fact, I don't know what kind of data structure I h
Hi Mat,
On Fri, Sep 14, 2012 at 12:24:50AM +0200, Mat M wrote:
> I was using an "official" build to test.
> THe about box gives me:
> LibreOffice 3.5.6.2
> Version ID : e0fbe70-5879838-a0745b0-0cd1158-638b327
>
> IIUC, the commit id matching this is 45d6f613425c [1] or 72d3b35748b [2]
>
> Is th
Hello
I was using an "official" build to test.
THe about box gives me:
LibreOffice 3.5.6.2
Version ID : e0fbe70-5879838-a0745b0-0cd1158-638b327
IIUC, the commit id matching this is 45d6f613425c [1] or 72d3b35748b [2]
Is there a way to get back to the commit id from the build id ? I thought
as
e real bug - but fixing it in either way would be fine I
suspect :-)
> The reason that makes me ask this question is that this bug is exists
> since the OpenOffice (2).
Ah - there are plenty of these around.
> and I'm sure that several solutions were proposed to deal with t
these buttons on "Visible
Buttons" and "Customize Toolbar" make no sense.
I'm wondering if we can solve this by just remove them from "Visible Buttons"
and "Customize Toolbar".
The reason that makes me ask this question is that this bug is exists sinc
On Tue, Jul 24, 2012 at 02:27:56PM -0400, Kohei Yoshida wrote:
> So, I approved this patch: https://gerrit.libreoffice.org/#/c/337/
> and would like to see this pushed to the fdo master. But I'm not
> sure if I need to do anything more to make that happen. Being a
> newbie on gerrit I'd like to k
Hi there,
So, I approved this patch: https://gerrit.libreoffice.org/#/c/337/ and
would like to see this pushed to the fdo master. But I'm not sure if I
need to do anything more to make that happen. Being a newbie on gerrit
I'd like to know what the next step is for this patch.
Thanks a lot
On 07/13/2012 11:37 PM, Christophe JAILLET wrote:
Le 13/07/2012 23:17, Lubos Lunak a écrit :
according to my understanding,
OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives
compareAsciiL - the L means it gets the string length from the macro
I was speaking about compar
Le 13/07/2012 23:17, Lubos Lunak a écrit :
according to my understanding,
OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives
compareAsciiL - the L means it gets the string length from the macro
I was speaking about compareToAscii, without the L. compareAsciiL does
not see
Le 13/07/2012 22:59, Christophe JAILLET a écrit :
Hi,
according to my understanding,
OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives
exactly the same result as
OUString::compareToAscii("A string")
However, the first one:
- is harder to read
- uses the deprecate
On Friday 13 of July 2012, Christophe JAILLET wrote:
> Hi,
>
> according to my understanding,
>
> OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives
compareAsciiL - the L means it gets the string length from the macro
> exactly the same result as
> OUString::compareToAscii("A
Hi,
according to my understanding,
OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives
exactly the same result as
OUString::compareToAscii("A string")
However, the first one:
- is harder to read
- uses the deprecated RTL_CONSTASCII_STRINGPARAM macro
- is a bit s
On Sunday 08 of July 2012, Christophe JAILLET wrote:
> Hi,
>
> Sometimes some methods are declared with some default value(s)
> As an example, here is the definition of matchAsciiL for OUString
>
> sal_Bool matchAsciiL( const sal_Char* asciiStr, sal_Int32
> asciiStrLength, sal_Int32 fromIndex
Hi,
Sometimes some methods are declared with some default value(s)
As an example, here is the definition of matchAsciiL for OUString
>
sal_Bool matchAsciiL( const sal_Char* asciiStr, sal_Int32
asciiStrLength, sal_Int32 fromIndex = 0 ) const SAL_THROW(())
>
When these functions are
On Wed, Jun 20, 2012 at 09:17:16AM +0200, Tomaž Vajngerl
wrote:
> As far as I can see by just looking at this snippet of code this is
> needed because rText would be ", ... , ... , ..." instead of "... ,
> ... , ..." if you omit rText.Len() from the if statement. In other
> words.. the rText.Len(
an see by just looking at this snippet of code this is
needed because rText would be ", ... , ... , ..." instead of "... ,
... , ..." if you omit rText.Len() from the if statement. In other
words.. the rText.Len() is to ensure you don't write comma at the
beginning of rText.
;rText.Len() &&..." (line 92) (and therefore line 93 and 78) ?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-function-SwAttrSet-GetPresentation-sw-source-ui-utlui-attrdesc-cxx-tp3991205.html
Sent from the Dev mailing list archive at Nabble.com.
this message in context:
http://nabble.documentfoundation.org/Question-about-filter-source-msfilter-msdffimp-cxx-tp3986364p3986370.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Monday 28 of May 2012, julien2412 wrote:
> Hello,
>
> I'm trying to understand why cppcheck (git updated today) hangs on the file
> liboroot/filter/source/msfilter/msdffimp.cxx
>
> I tried to find where was the problem and found that it worked if I
> commented just the following curly parenthesi
On Mon, 2012-05-28 at 05:01 -0700, julien2412 wrote:
> Before I create a tracker for cppcheck, I'd like to know at what corrrespond
> these curly parenthesis.
> I found nothing about this kind of construct in C++ however I know it's ok
> since it compiles ok.
These add scope to the objects inside
ow at what corrrespond
these curly parenthesis.
I found nothing about this kind of construct in C++ however I know it's ok
since it compiles ok.
Julien.
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-filter-source-msfilter-msdffimp-cxx-tp3986364.html
Sent from
On Fri, May 04, 2012 at 09:49:09AM +0200, David Tardon wrote:
> Marking as pushed.
Done the same in gerrit. Interesting "real" review process this one on gerrit
there:
https://gerrit.libreoffice.org/#/c/105/
Best,
Bjoern
___
LibreOffice mailing list
Li
Marking as pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Thu, 03 May 2012 12:40:38 +0200, Thorsten Behrens
wrote:
Marco Cecchetti wrote:
Btw I have no idea which user action the ShapeRenderingVisitor
is triggered by.
Hi Marco,
sigh, yeah, as mentioned in another mail - the whole importSvg() is
dead code by now, sorry for having missed that ear
Marco Cecchetti wrote:
> Btw I have no idea which user action the ShapeRenderingVisitor
> is triggered by.
>
Hi Marco,
sigh, yeah, as mentioned in another mail - the whole importSvg() is
dead code by now, sorry for having missed that earlier when
Christina started consolidating stuff - commit
48c
On Mon, 30 Apr 2012 23:26:58 +0200, Christina Roßmanith
wrote:
Hi,
what influence does a scale
foo
have on font size of foo if sx!=sy?
(I'm close to render coords-trans-03-t.svg as expected :-) )
Well for what I know the font size should be unchanged and
the text scaled as any othe
Hi,
what influence does a scale
foo
have on font size of foo if sx!=sy?
(I'm close to render coords-trans-03-t.svg as expected :-) )
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/li
On Sat, 28 Apr 2012 00:35:26 +0200, Marco Cecchetti
wrote:
On Fri, 27 Apr 2012 23:03:41 +0200, Christina Roßmanith
wrote:
Hi,
there are two "case XML_RECT" blocks in svgreader.cxx in two different
visitors. The ShapeWritingVisitor scales rx and ry with width and
height, the ShapeRen
On Fri, 27 Apr 2012 23:03:41 +0200, Christina Roßmanith
wrote:
Hi,
there are two "case XML_RECT" blocks in svgreader.cxx in two different
visitors. The ShapeWritingVisitor scales rx and ry with width and
height, the ShapeRenderingVisitor does not apply any scaling. I guess
both visitor
Hi,
there are two "case XML_RECT" blocks in svgreader.cxx in two different
visitors. The ShapeWritingVisitor scales rx and ry with width and
height, the ShapeRenderingVisitor does not apply any scaling. I guess
both visitors should treat rx and ry the same way?
Christina
It must be something in my build.. Libreoffice installed on OpenSuSe 12.1 x64
system is OK.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffi
Hi, while working on this bug (33599) I found an issue which causes writer to
crash.
Here are the steps to reproduce it:
1. Open new writer document.
2. Insert new comment by pressing Ctrl+Alt+C or by selecting Insert/Comment
3. Write 'Test' into the comment.
4. Press Alt+Tab to switch t
>I think I know where is the problem.
I think I know where the problem is. <- Sorry for the mistakes, i don't know
why i make them :)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.
e:
'// #i98686# if we have several views, all notes should update their text'
Commenting out that Broadcast call, or the whole call for UpdateData() solves
the issue. My question is: what is the purpose of this UpdateData call (or the
broadcast)?
ps.: i tried without commenting out cal
Hi Kendy,
On Mon, Mar 19, 2012 at 09:51:24AM +0100, Jan Holesovsky wrote:
> Hi Khaled,
>
> I've got the following report:
>
> - 8< -
> The Arabic keyboard layout in X11 has the less-than sign (<) on the same
> position as the left curly bracket ({) in the English keyboard layout.
> Same
On Thu, 2012-03-08 at 12:35 +0100, Dézsi Szabolcs wrote:
> Adding a simple if( nLinePitch != 0 ) before the line seems to solve
> the problem, documents load with it.
>
> Question: should I use this solution (if it's a solution) or this
> causes other issues somewhere else?
T
simple if( nLinePitch != 0 ) before the line seems to solve the
problem, documents load with it.
Question: should I use this solution (if it's a solution) or this causes other
issues somewhere else?
Szabolcs
Andrew Higginson wrote:
> So if I am getting the SVG from the brand/ folder in the galaxy icon theme,
> what should I use to read it?
>
Hi Andrew,
ok, some code pointers - look into vcl/source/app/brand.cxx,
Application::LoadBrandBitmap() on how to get to the brand dir - note
those $BRAND_BASE_DI
Hi,
On 28 February 2012 14:55, Thorsten Behrens wrote:
> Andrew Higginson wrote:
> > Sorry still don't understand, what class is the aSvgData? :/
> >
> Hi Andrew,
>
> ah, that was a somewhat made-up example - uno::Sequence
> for the methods I used there. But it really depends on how/where you
> g
Andrew Higginson wrote:
> Sorry still don't understand, what class is the aSvgData? :/
>
Hi Andrew,
ah, that was a somewhat made-up example - uno::Sequence
for the methods I used there. But it really depends on how/where you
get your data read.
HTH,
-- Thorsten
pgpS75qAdVkhj.pgp
Description:
On 27 February 2012 15:04, Thorsten Behrens wrote:
> Andrew Higginson wrote:
> > Thanks, and finally, how do I get the aSvgData?
> >
> Just load your file into that - this RenderGraphic just wants a
> const sal_uInt8* ptr with the utf-8 encoded xml stream. ;)
>
> Cheers,
>
> -- Thorsten
>
Sorry s
Andrew Higginson wrote:
> Thanks, and finally, how do I get the aSvgData?
>
Just load your file into that - this RenderGraphic just wants a
const sal_uInt8* ptr with the utf-8 encoded xml stream. ;)
Cheers,
-- Thorsten
pgpMWjjjB12TW.pgp
Description: PGP signature
__
Hi,
> const ::vcl::RenderGraphicRasterizer aRaster(
> "image/svg+xml",
> aSvgData.getLength(),
> aSvgData.getConstArray() );
>
> BitmapEx aBmpEx = aRaster.Rasterize( Size(200,300) );
>
> Thanks, and finally, how do I get the aSvgData?
--
Andrew Higginson
_
Andrew Higginson wrote:
> I can see there are various classes (i.e. vcl::SVGReader and
> vcl::RenderGraphicRasterizer) which may do the job, however I need to
> rasterize it to a specific resolution (pretty much what
> vcl::RenderGraphicRasterizer::Rasterize does) however I don't want to
> duplicat
Hi,
I am trying to do some work on improving the About Dialog and I need to
be able to rasterize an SVG (which I guess I would have to pack in the
icon themes) to a vcl::BitmapEx
I can see there are various classes (i.e. vcl::SVGReader and
vcl::RenderGraphicRasterizer) which may do the job, howev
Hi there,
On Tue, 2012-02-21 at 08:52 +0100, Winfried Donkers wrote:
> Presently, the last used colour is stored within the control
> (mLastColor) and in the shell (e.g. ScFormatShell, SwTextShell) where
> the execute function is.
Riight - that doesn't seem so optimal :-)
> I would like
I am working on fdo45671 which concerns the use of 'split buttons' for
font/background/border colours, split button meaning that you can either choose
from the colour palette or that you can use the used color.
Presently, the last used colour is stored within the control (mLastColor) and
in the
http://nabble.documentfoundation.org/Question-about-iterator-management-in-sw-source-core-fields-cellfml-cxx-tp3708331p3714286.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Fri, 2012-02-03 at 18:30 +0100, Michael Stahl wrote:
> On 03/02/12 18:17, Terrence Enger wrote:
>
> > Stephan, I am sorry to question your expertise, but I wonder ... is
> > your reassurance based on knowledge of the language standard, or is
> > based on observed be
On 03/02/12 18:17, Terrence Enger wrote:
> Stephan, I am sorry to question your expertise, but I wonder ... is
> your reassurance based on knowledge of the language standard, or is
> based on observed behaviour of C++ compilers?
hahaha, i believe that among all the developers who ever
On Fri, 2012-02-03 at 12:17 -0500, Terrence Enger wrote:
a question, which Stephan Bergmann answered even as I was
writing.
Thank you, Stephan.
Terry.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman
ave the same problem? "i" is incremented only after
> >> the erase is complete, when "i" is already invalid.
> >
> > No, i is incremented before calling erase in the above code.
>
> ah, that's surprising.
> see, that is why i almost always w
On 02/03/2012 05:31 PM, Michael Stahl wrote:
ah, that's surprising.
that's shocking ;)
see, that is why i almost always write the i++ as an extra statement,
i'm never quite exactly sure what it does, and when :)
There is a sequence point (in C++03 parlance; the nomenclature changed
slight
On 03/02/12 17:21, Stephan Bergmann wrote:
> On 02/03/2012 04:18 PM, Michael Stahl wrote:
>> On 03/02/12 14:01, Stephan Bergmann wrote:
>>> The "standard idiom" is
>>>
>>> for (iterator i = m.begin(); i != m.end();) {
>>> if (doErase) {
>>> m.erase(i++);
>>> } else {
>>>
On 02/03/2012 04:18 PM, Michael Stahl wrote:
On 03/02/12 14:01, Stephan Bergmann wrote:
The "standard idiom" is
for (iterator i = m.begin(); i != m.end();) {
if (doErase) {
m.erase(i++);
} else {
++i;
}
}
but doesn't that have the same problem? "i" is
On 03/02/12 14:01, Stephan Bergmann wrote:
> On 02/02/2012 09:08 PM, julien2412 wrote:
>> Would this patch better ? (I kept the for loop)
>
> Unfortunately that still has a problem. After "rBoxes.erase(toErase)",
> "it" (which is the same as "toErase") is invalidated, so incrementing it
> (up i
On 02/02/2012 09:08 PM, julien2412 wrote:
Would this patch better ? (I kept the for loop)
Unfortunately that still has a problem. After "rBoxes.erase(toErase)",
"it" (which is the same as "toErase") is invalidated, so incrementing it
(up in the for(...;...;...) part) has undefined behavior.
he same.
Moreover, I don't know if the evolution of the standard had changed the
behavior on this point.
Any idea ?
Julien
(sorry for the nitpicking but I'd like to understand this point)
--
View this message in context:
http://nabble.documentfoundation.org/Question-about-iterato
On 02/02/2012 02:06 PM, Lubos Lunak wrote:
I definitely didn't mean to get formal here, I simply meant a description of
how to actually handle this, as it turns up now and then, and STL doesn't
make this trivial.
In which case the answer should be to read Item 9 "Choose carefully
among erasi
On Thursday 02 of February 2012, Stephan Bergmann wrote:
> On 02/02/2012 11:26 AM, Lubos Lunak wrote:
> > I agree with all the points, but in Julien's defense, I remember
> > exactly this same approach was pushed in recently as a fix to the same
> > issue elsewhere.
>
> Might well be, I probably
On 02/02/2012 11:26 AM, Lubos Lunak wrote:
I agree with all the points, but in Julien's defense, I remember exactly this
same approach was pushed in recently as a fix to the same issue elsewhere.
Might well be, I probably didn't notice. And this is in no way meant to
criticize Julien -- but
On 02/02/2012 10:13 AM, Marcel Metz wrote:
If the box that is represented by `it` should be deleted you could use.
970 it = rBoxes.erase( it );
Unfortunately, this is only C++11, not C++03.
Stephan
___
LibreOffice mailing list
L
On Thursday 02 of February 2012, Stephan Bergmann wrote:
> On 02/01/2012 11:40 PM, julien2412 wrote:
> > Here are the lines :
> > 961 // dann mal die Tabellenkoepfe raus:
> > 962 for( SwSelBoxes::iterator it = rBoxes.begin(); it !=
> > rBoxes.end(); ++it )
> >
Hello Julien
On 02/01/2012 11:40 PM, julien2412 wrote:
> Here are the lines :
> 961 // dann mal die Tabellenkoepfe raus:
> 962 for( SwSelBoxes::iterator it = rBoxes.begin(); it !=
> rBoxes.end(); ++it )
> 963 {
> 964 pLine = i
301 - 400 of 620 matches
Mail list logo
