RE: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-05-08 Thread Winfried Donkers
The function originates from Lotus 1-2-3 where it was called DATEDIF, MS-Excel called it the same, and ODF just adopted that name. The DATEDIFF function you mention is something different (VBA?). I don't know if the function needs to be added to xlformula.cxx and/or lotform.cxx (see

Re: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-05-08 Thread Kohei Yoshida
On Tue, May 8, 2012 at 5:23 AM, Winfried Donkers w.donk...@dci-electronics.nl wrote: Once the xlformula.cxx/lotform.cxx question has been answered, I will submit the patch. What I would suggest is to add it to xlformula.cxx, but leave out lotform.cxx (for now). Kohei

RE: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-05-08 Thread Winfried Donkers
Van: Kohei Yoshida [mailto:kohei.yosh...@gmail.com] Verzonden: dinsdag 8 mei 2012 21:00 Once the xlformula.cxx/lotform.cxx question has been answered, I will submit the patch. What I would suggest is to add it to xlformula.cxx, but leave out lotform.cxx (for now). Kohei Thank you. I

RE: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-05-05 Thread Winfried Donkers
Attached diff is NOT intended to be pushed at this state. I have added the formula 'datedif', as defined in ODF 1.2 to calc (see diff). Hey, great! 2. the calculation in DateDif(..) uses mean values for days in year (365.2425) and for days in month (30.4369). That will in some instances

RE: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-04-27 Thread Winfried Donkers
@Eike and @Regina: Thank you for your reactions. Unfortunately I have to be absent for a couple of days, so I cannot respond to you, nor put your advises/suggenstions into the code yet. But I will get back to you and make the enhancement fit to submit :-) Winfried

Re: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-04-26 Thread Regina Henschel
Hi Winfried, Winfried Donkers schrieb: Hi, I have added the formula 'datedif', as defined in ODF 1.2 to calc (see diff). Why do you not put it into interpr2.cxx? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-04-26 Thread Eike Rathke
Hi Winfried, On Thursday, 2012-04-26 13:55:14 +0200, Winfried Donkers wrote: I have added the formula 'datedif', as defined in ODF 1.2 to calc (see diff). Hey, great! But there are some items I would like to get advise on: 1. parameter fmt in datedif( date1; date2; fmt ) defines the output

Re: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-04-26 Thread Regina Henschel
Hi Eike, hi Winfried, Eike Rathke schrieb: Hi Winfried, On Thursday, 2012-04-26 13:55:14 +0200, Winfried Donkers wrote: I have added the formula 'datedif', as defined in ODF 1.2 to calc (see diff). Hey, great! 2. the calculation in DateDif(..) uses mean values for days in year