RE: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-08 Thread Winfried Donkers
Hi Eike, Great we agree :) Yes, isn't it :) Note that UI names may (and sometimes do) differ from ODF file format names, the relation is UI WEEKNUM == ODF ISOWEEKNUM UI WEEKNUM_ADD == ODF WEEKNUM see also formula/source/core/resource/core_resource.src Resource

RE: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-07 Thread Winfried Donkers
Hi Eike, I would like to change the behaviour of function WEEKNUM to conform to ODFF1.2 [...] We might get away with strictly complying with ODFF and generate an error for constraint cases if prominently mentioned in release notes that WEEKNUM changed. Users will have to change formulas

Re: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-07 Thread Eike Rathke
Hi Winfried, On Thursday, 2012-06-07 09:23:47 +0200, Winfried Donkers wrote: I will work on strictly implementing ODFF for WEEKNUM and ISOWEEKNUM. I don't know if I will find a way to produce an error message explaining to the user what exactly is wrong when opening old files with WEEKNUM in

RE: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-07 Thread Winfried Donkers
Hi Eike, I think this might be a plan: * enhance WEEKNUM_ADD to support all ODF WEEKNUM modes * in the UI rename WEEKNUM to ISOWEEKNUM * change ISOWEEKNUM to accept only one parameter * during import's formula compile step for ISOWEEKNUM check if a second argument is provided * if so

Re: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-07 Thread Eike Rathke
Hi Winfried, On Thursday, 2012-06-07 13:21:01 +0200, Winfried Donkers wrote: My first reaction is, yes, a good plan and in line with what I wanted to do. I will study your plan carefully, work on it step for step and keep you informed. Great we agree :) It looks as if after this plan has

Re: calc: function WEEKNUM seems not to conform to ODFF1.2

2012-06-06 Thread Eike Rathke
Hi Winfried, On Friday, 2012-06-01 10:07:00 +0200, Winfried Donkers wrote: I would like to change the behaviour of function WEEKNUM to conform to ODFF1.2 (core/tools/source/datetime/tdate.cxx, Date::GetWeekOfYear(..) allows this), but before enter a bug and start working on it, I would like