Hi Eike,
> All your comments have been processed in the code (I learned some new
> things too, thank you !).
> It now works fine for all possible argument values, including leaving out the
> optional value for WEEKNUM and illegal arguments.
>
> Now I will start on seeing how old-style documents
Hi Eike,
>Please see my splinter review in
>https://bugs.freedesktop.org/show_bug.cgi?id=50950#c6
All your comments have been processed in the code (I learned some new things
too, thank you !).
It now works fine for all possible argument values, including levibng out the
optional value for WEEK
Hi Winfried,
On Wednesday, 2012-07-11 16:49:13 +0200, Winfried Donkers wrote:
> I uploaded a new diff file to bug 50950.
Please see my splinter review in
https://bugs.freedesktop.org/show_bug.cgi?id=50950#c6
> I haven't started on the proper processing of saved old-style arguments as a
> stran
Hi Noel,
> $ git grep -n WEEKNUM_ADD
> sc/source/core/tool/odffmap.cxx:38:{ "WEEKNUM", "WEEKNUM_ADD",
> false, "com.sun.star
Thank you for your suggestion.
That line has been changed in my patch to ...{ "WEEKNUM", "WEEKNUM", ...
And that's why I am at a loss
Winfried
On 2012-07-11 16:49, Winfried Donkers wrote:
When running the modified code, LibO does not recognise WEEKNUM and
does recognise WEEKNUM_ADD, although I cannot find any text
'WEEKNUM_ADD' in the code!
$ git grep -n WEEKNUM_ADD
sc/source/core/tool/odffmap.cxx:38:{ "WEEKNUM", "WEEKNUM_ADD",
> Well, my hope is that I'm not too dumb to educate you ;-) so you'd be
> able to work more independently on spreadsheet functions.
It's more the question if I am smart enough to pick up the essentials of LibO
spreadsheet functions quick enough ;-)
Anyway, I improved my patch and did learn from
Hi Winfried,
On Monday, 2012-06-25 09:53:29 +0200, Winfried Donkers wrote:
> I will do that. (I hope my contributions don't cost you too much time
> in correcting so that they fit well in the general picture...)
Well, my hope is that I'm not too dumb to educate you ;-) so you'd be
able to work m
Hi Eike,
> Please see my Splinter review in
> https://bugs.freedesktop.org/show_bug.cgi?id=50950#c3
I will do that. (I hope my contributions don't cost you too much time in
correcting so that they fit well in the general picture...)
> It seems one point didn't make it across: I did not sugges
Hi Winfried,
On Wednesday, 2012-06-20 11:45:08 +0200, Winfried Donkers wrote:
> I just uploaded a diff file and test document to bug50950.
Please see my Splinter review in
https://bugs.freedesktop.org/show_bug.cgi?id=50950#c3
> The ODFF1.2-compliant functions work and I would like some help fro
Hi Winfried,
On Wednesday, 2012-06-20 11:45:08 +0200, Winfried Donkers wrote:
> I just uploaded a diff file and test document to bug50950.
I'll come back to this tomorrow.
Eike
--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60
10 matches
Mail list logo
