Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Lubos Lunak
On Wednesday 22 of February 2012, Michael Meeks wrote: > Of course, it would be even more wonderful, if, with some > template-magic, we could generate static rtl_uString structures that > would end up in the .rodata section, and got heap allocated only when > copied, with utf-8 -> UCS2 conver

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Michael Meeks
On Wed, 2012-02-22 at 13:42 +0100, Stephan Bergmann wrote: > So, if we ever wanted to extend the new facilities to also > support UTF-8 string literals, but would want to keep the performance > benefit for the ASCII-only case, we could not offer the same simple syntax Sure. On the other

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Lubos Lunak
On Wednesday 22 of February 2012, Stephan Bergmann wrote: > On 02/22/2012 11:25 AM, Michael Meeks wrote: > > Great ! :-) incidentally, I had one minor point around the ASCII vs. > > UTF-8 side; the rtl_string2UString (cf. sal/rtl/source/string.cxx) does > > a typically slower UTF-8 length count

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 11:25 AM, Michael Meeks wrote: Great ! :-) incidentally, I had one minor point around the ASCII vs. UTF-8 side; the rtl_string2UString (cf. sal/rtl/source/string.cxx) does a typically slower UTF-8 length counting loop; I suggest that we could do better performance wise (and

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Michael Meeks
On Tue, 2012-02-21 at 23:24 +0100, Lubos Lunak wrote: > No, it's not yet in, but I intend to push it soon, given that there's been > no > more discussion. Great ! :-) incidentally, I had one minor point around the ASCII vs. UTF-8 side; the rtl_string2UString (cf. sal/rtl/source/string.

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Lubos Lunak
On Tuesday 21 of February 2012, Stephan Bergmann wrote: > On 02/21/2012 09:29 PM, Chr. Rossmanith wrote: > > during code cleanup I came across badly readable > > RTL_CONSTASCII_USTRINGPARAM("bla") lines. I could replace them with > > "bla" which should be possible with Lubos patch removing the need

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:29 PM, Chr. Rossmanith wrote: during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM("bla") lines. I could replace them with "bla" which should be possible with Lubos patch removing the need for "The macro"... But Lobos's patch is not yet in? (And it woul

RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Chr. Rossmanith
Hi, during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM("bla") lines. I could replace them with "bla" which should be possible with Lubos patch removing the need for "The macro"... I wouldn't do it across the whole code base. Only if I come across instances of "The