Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-21 Thread G.H.M.Valkenhoef, van
Great to hear that it works that it will make it into master :-). Any thoughts on this one:  3) When creating the CLucene FileReader (HelpIndexer.cxx), the path is converted to plain ASCII, that's probably dangerous. There is probably a way to work around this, but I haven't gotten around to

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-20 Thread Caolán McNamara
On Sun, 2012-02-19 at 18:49 +0100, Gert van Valkenhoef wrote: Thanks again for the help. Attached a new series of patches (cumulative with the previously sent ones and Caolan's), in which (I think) all the Java invocations have been removed in favor of using the C++ components: 1)

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-20 Thread Caolán McNamara
On Sun, 2012-02-19 at 18:49 +0100, Gert van Valkenhoef wrote: Thanks again for the help. Attached a new series of patches (cumulative with the previously sent ones and Caolan's), in which (I think) all the Java invocations have been removed in favor of using the C++ components: Attached is

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 12:01 +, Caolán McNamara wrote: On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: Yes, I found that java code (the HelpIndexer I refer to). I'll work on a patch to replace the XInvocations of the Java code with calls to my code. I can try and

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 22:27 +0100, Gert van Valkenhoef wrote: 1. how to convert the rtl::UOString to the TCHAR* that CLucene needs. 2. In xmlhelp/source/cxxhelp/provider/makefile.mk, I've hacked the include path to include l10ntools/source/help Attached patch hopefully basically takes care

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread G.H.M.Valkenhoef, van
On 13-02-12, Rene Engelhard r...@debian.org wrote: Hi, first of all: thanks for this effort, which should have been done when this lucene dependency was introduced in the first place in OOo times. But... On Mon, Feb 13, 2012 at 04:17:49PM +0100, Radek Doulik wrote:    * This

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread G.H.M.Valkenhoef, van
Thanks for the answers, responses below. On 13-02-12, Caolán McNamara caol...@redhat.com wrote: The xmlhelp/source/com/sun/star/help/*.java route is the one that sets the bExtensionMode. I think this one is which third party extensions can insert their help into our help system. The cxxhelp

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: Yes, I found that java code (the HelpIndexer I refer to). I'll work on a patch to replace the XInvocations of the Java code with calls to my code. I can try and knock together a skeleton of a conversion of that Java component

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Norbert Thiebaud
Just a word of encouragement: thanks for working on that, I'm looking forward to see the impact on the build with LANG=all :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread G.H.M.Valkenhoef, van
On 14-02-12, Andras Timar tima...@gmail.com wrote: 2012/2/14 Norbert Thiebaud nthieb...@gmail.com: Just a word of encouragement: thanks for working on that, I'm looking forward to see the impact on the build with LANG=all :-) Me too, and also I wonder, if it fixes

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 17:04 +0100, G.H.M.Valkenhoef, van wrote: I noticed that CJK-based indexing is only enabled for the Japanese language. Maybe this can be fixed by adding more languages to be CJK-indexed. Indeed, opengrok for CJKAnalyzer and see if running zh-* (and possibly ko)

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Gert van Valkenhoef
Hi all, Thanks for all the replies and comments. Attached is a new bunch of patches against master. I've reworked the helpindexer.cpp code so that it can be used as a library, and I changed xmlhelp/source/cxxhelp/provider/databases.cxx to call it. The good news is that I think this gets rid

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Radek Doulik
Hi Gert, thanks for looking into this. On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: Dear LibreOffice developers, Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44681 Attached are initial implementations of the HelpIndexer and HelpSearch in C++ using CLucene, to

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Michael Meeks
Hi there, On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: Attached are initial implementations of the HelpIndexer and HelpSearch in C++ using CLucene, to replace the Java implementations using Lucene. Wow - this is awesome :-) Thanks so much for that; I hope it

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Caolán McNamara
On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: The code that interfaces with Lucene to do the indexing and searching is complete. Great. I've also looked into where the HelpIndexerTool is currently used, and found these: - xmlhelp/source/cxxhelp/provider/databases.cxx:

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Rene Engelhard
Hi, first of all: thanks for this effort, which should have been done when this lucene dependency was introduced in the first place in OOo times. But... On Mon, Feb 13, 2012 at 04:17:49PM +0100, Radek Doulik wrote: * This implementation is using the master branch of CLucene's git, with