On Tue, 2010-11-23 at 21:05 +0100, Pierre-André Jacquod wrote:
> To have a better code, would it not be better to change the prototyping
> of the function from foo (int) to foo() ?? Or did I miss a point?
It would be better, *but* often these are virtual methods and have to
retain their signature
On 11/23/2010 09:23 AM, Joachim Trémouroux wrote:
> Hi Michael,
> I will work on this. I see two possible ways:
>
Ok Michael, then I will continue within binfilter... ::-))
But a additional question:
>From Norbert Thiebaud:
>
> To be consistent, I rather see them commented out
> i.e
>
> foo(in
Hi Joachim,
On Tue, 2010-11-23 at 09:23 +0100, Joachim Trémouroux wrote:
> - wrap current loadImage with something similar to this:
> bool found = loadImage(...)
> if (!found) {
> found = loadImage( default_icon.png ...)
> }
> return found
That sounds fine :-) I suggest we simply remove
Hi Michael,
Le 22 novembre 2010 22:07, Michael Meeks a écrit
:
>
>Really, of course - I'd love to have someone working on eg.
>
>
> http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons
>
>Which should be mind-numblingly simple and
Hi Pierre,
On Mon, 2010-11-22 at 21:06 +0100, Pierre-André Jacquod wrote:
> Okay, but at compile time, there is really a flow of warning. So I
> wanted also to work a bit on it. That's just cleaning, not really
> improving.
Sure sure :-) fair enough.
> clone/filters/binfilter/bf_sc/s
Hi,
>> - Unused parameters in some methods are triggering compilation
>> warnings. Should I fix them by removing the parameter name ?
>
> Sounds reasonable.
>
> Really though - the binfilter is not the best place to focus cleanups
> (though I appreciate it is fugly old code ;-) Most
2010/11/22 Michael Meeks :
> Hi Joachim,
>
> On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote:
>> I have fixed some compilation warnings in binfilter and some
>> unnecessary comments. Patch is attached for review.
>
> Hokay - the binfilter is of course un-loved and under-maintaine
Hi Joachim,
On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote:
> I have fixed some compilation warnings in binfilter and some
> unnecessary comments. Patch is attached for review.
Hokay - the binfilter is of course un-loved and under-maintained.
> I have two questions:
> - /*N
