Re: Trying to solve a crasher in editeng unit test

2012-04-13 Thread Caolán McNamara
On Thu, 2012-04-12 at 10:14 -0400, Kohei Yoshida wrote: On Thu, Apr 12, 2012 at 10:06 AM, Caolán McNamara caol...@redhat.com wrote: *mumable* unotest::testDown has its dispose commented out ages ago, putting that back in shows some other problems with various mixes of global singletons that

Re: Trying to solve a crasher in editeng unit test

2012-04-13 Thread Kohei Yoshida
On Fri, Apr 13, 2012 at 8:15 AM, Caolán McNamara caol...@redhat.com wrote: Yes.  Some of my changes were an attempt to address that ok, plan b, reorganize matters so that we bootstrap the initial uno component context once before all tests, and dispose it once after all tests are complete.

Re: Trying to solve a crasher in editeng unit test

2012-04-13 Thread Caolán McNamara
On Fri, 2012-04-13 at 12:14 -0400, Kohei Yoshida wrote: On Fri, Apr 13, 2012 at 8:15 AM, Caolán McNamara caol...@redhat.com wrote: reenabled editeng test again, and await inevitable fallout on some platform or other. Keeping my fingers crossed. :-) Inevitable platform fallout on windows

Re: Trying to solve a crasher in editeng unit test

2012-04-12 Thread Stephan Bergmann
On 04/11/2012 10:44 PM, Kohei Yoshida wrote: On Wed, 2012-04-11 at 21:29 +0100, Caolán McNamara wrote: On Wed, 2012-04-11 at 15:56 -0400, Kohei Yoshida wrote: Hey there, I'm trying to set up a new unit test for the edit engine core, but struggling with one crasher.

Re: Trying to solve a crasher in editeng unit test

2012-04-12 Thread Kohei Yoshida
On Thu, 2012-04-12 at 10:50 +0200, Stephan Bergmann wrote: On 04/11/2012 10:44 PM, Kohei Yoshida wrote: On Wed, 2012-04-11 at 21:29 +0100, Caolán McNamara wrote: On Wed, 2012-04-11 at 15:56 -0400, Kohei Yoshida wrote: Hey there, I'm trying to set up a new unit test for the edit engine

Re: Trying to solve a crasher in editeng unit test

2012-04-12 Thread Caolán McNamara
On Thu, 2012-04-12 at 09:46 -0400, Kohei Yoshida wrote: Crap. Maybe a unit test in editeng wasn't such a good idea after all. I disabled it and backed out a few bit for the moment. I have a fairly good idea what the various problems are so I might have a go at fixing it up again in a bit.

Re: Trying to solve a crasher in editeng unit test

2012-04-12 Thread Kohei Yoshida
On Thu, Apr 12, 2012 at 10:06 AM, Caolán McNamara caol...@redhat.com wrote: On Thu, 2012-04-12 at 09:46 -0400, Kohei Yoshida wrote: Crap.  Maybe a unit test in editeng wasn't such a good idea after all. I disabled it and backed out a few bit for the moment. I have a fairly good idea what the

Re: Trying to solve a crasher in editeng unit test

2012-04-11 Thread Caolán McNamara
On Wed, 2012-04-11 at 15:56 -0400, Kohei Yoshida wrote: Hey there, I'm trying to set up a new unit test for the edit engine core, but struggling with one crasher. http://cgit.freedesktop.org/libreoffice/core/commit/?id=6089be1a7a17ae849d8793520e9d8d36296ed5cf should get you closer anyway,