Trying to understand a part of autoform.cxx (sc module)

2014-03-22 Thread julien2412
Hello, I noticed this in http://opengrok.libreoffice.org/xref/core/sc/source/core/tool/autoform.cxx#640 649 // do not insert empty CJK font 650 const SvxFontItem rCJKFont = rField.GetCJKFont(); 651 if (!rCJKFont.GetStyleName().isEmpty()) 652 {

Re: Trying to understand a part of autoform.cxx (sc module)

2014-03-22 Thread Kohei Yoshida
On Sat, 2014-03-22 at 07:12 -0700, julien2412 wrote: But shouldn't line 666 be: if (!rCTLFont.GetStyleName().isEmpty()) Yes. You can go ahead and fix that. Thanks, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[SOLVED] Re: Trying to understand a part of autoform.cxx (sc module)

2014-03-22 Thread Julien Nabet
On 22/03/2014 15:29, Kohei Yoshida wrote: On Sat, 2014-03-22 at 07:12 -0700, julien2412 wrote: But shouldn't line 666 be: if (!rCTLFont.GetStyleName().isEmpty()) Yes. You can go ahead and fix that. Thank you Kohei for the feedback! I've pushed the fix on master sources. (For 4.2: