Re: Unuseful SfxObjectFactory::GetFactoryURL() in SfxViewFrame::LoadViewIntoFrame_Impl, any clue?

2017-03-20 Thread Matteo Casalin
On 2017-03-20 14:44, Caolán McNamara wrote: On Fri, 2017-03-17 at 17:39 +0100, Matteo Casalin wrote: 3. Commit  https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8f1ad65612c 0e54969cabc541b183062ae3d905  My guess is that the "if" in the code under consideration can be removed. Yeah,

Re: Unuseful SfxObjectFactory::GetFactoryURL() in SfxViewFrame::LoadViewIntoFrame_Impl, any clue?

2017-03-20 Thread Caolán McNamara
On Fri, 2017-03-17 at 17:39 +0100, Matteo Casalin wrote: > > 3. Commit  > https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8f1ad65612c > 0e54969cabc541b183062ae3d905  > > My guess is that the "if" in the code under consideration can be > removed. Yeah, its clearly meaningless so might a

Unuseful SfxObjectFactory::GetFactoryURL() in SfxViewFrame::LoadViewIntoFrame_Impl, any clue?

2017-03-17 Thread Matteo Casalin
Hi all, I stumbled in the following code snippet in SfxViewFrame::LoadViewIntoFrame_Impl: OUString sURL( "private:object" ); if ( sURL.isEmpty() ) sURL = i_rDoc.GetFactory().GetFactoryURL(); in which the "if" test is obviously always false. I looked at how code evolved du