Re: avoiding cppunit zerodiv correction

2014-05-30 Thread julien2412
y 0 completely. You're right of course. Sorrry for this change which was indeed wrong, I reverted it (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea15c9dc4da75fcd56e6b0dbce473b9e912fa4e2) Julien -- View this message in context: http://nabble.documentfoundation.or

Re: avoiding cppunit zerodiv correction

2014-05-30 Thread Lionel Elie Mamane
On Fri, May 30, 2014 at 10:01:49AM +0200, Matteo Casalin wrote: >> I wonder if we should not rather do something like: >> double dRatioPreV; >> if( nHeight < 0 ) >> { >> nHeight = 0; >> dRatioPreV = 1; // or rather zero? or +infinity? Do we want to >> // "force" a branch of

Re: avoiding cppunit zerodiv correction

2014-05-30 Thread Matteo Casalin
Hi, On Fri, 30 May 2014 07:17:57 +0200 Lionel Elie Mamane wrote: [...] > > I wonder if we should not rather do something like: > > double dRatioPreV; > if( nHeight < 0 ) > { > nHeight = 0; > dRatioPreV = 1; // or rather zero? or +infinity? Do we want to > // "force" a br

avoiding cppunit zerodiv correction

2014-05-29 Thread Lionel Elie Mamane
About this commit: --- a/sd/source/ui/dlg/docprev.cxx +++ b/sd/source/ui/dlg/docprev.cxx @@ -87,7 +87,7 @@ void SdDocPreviewWin::CalcSizeAndPos( GDIMetaFile* pFile, Size& rSize, Point& rP void SdDocPreviewWin::CalcSizeAndPos( GDIMetaFile* pFile, Size& rSize, Point& rPoint ) { Size aTmpSi