[PUSHED] add basegfx::fround to unittest (was: basegfx::fround and friends seems needed in windows build)

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 21:24 +0700, Korrawit Pruegsanusak wrote: Now I attach a patch for reviewing. Lovely - pushed it :-) OK, I have to confess that I've shamelessly copy-n'-pasted the whole things from the adjacent ones, and made some modifications on top of it. There is

Re: [PUSHED] add basegfx::fround to unittest (was: basegfx::fround and friends seems needed in windows build)

2012-02-21 Thread Korrawit Pruegsanusak
Hello Michael, On Tue, Feb 21, 2012 at 22:28, Michael Meeks michael.me...@suse.com wrote:        Drat, I just did that for you :-) Thanks for this :) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list

Re: basegfx::fround and friends seems needed in windows build

2012-02-13 Thread Stephan Bergmann
On 02/12/2012 06:45 AM, Korrawit Pruegsanusak wrote: On Thu, Feb 9, 2012 at 17:39, Michael Meeksmichael.me...@suse.com wrote: On Wed, 2012-02-08 at 21:36 +0100, Stephan Bergmann wrote: On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something

Re: basegfx::fround and friends seems needed in windows build

2012-02-13 Thread Michael Meeks
Hi there, On Sun, 2012-02-12 at 12:45 +0700, Korrawit Pruegsanusak wrote: So there are some alternatives options to hide something from callcatcher. [...] write unit tests that call it [...] Could you please give me a hint how to do this? Thanks :-) Sure ! :-) so we want to

Re: basegfx::fround and friends seems needed in windows build

2012-02-11 Thread Korrawit Pruegsanusak
Hello Michael, all, On Thu, Feb 9, 2012 at 17:39, Michael Meeks michael.me...@suse.com wrote: On Wed, 2012-02-08 at 21:36 +0100, Stephan Bergmann wrote: On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something from callcatcher. [...] write unit

Re: basegfx::fround and friends seems needed in windows build

2012-02-09 Thread Michael Meeks
On Wed, 2012-02-08 at 21:36 +0100, Stephan Bergmann wrote: On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something from callcatcher. [...] write unit tests that call it [...] I somehow like that solution best. :) Ditto :-)

basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Korrawit Pruegsanusak
Hello Alexander, Caolán, all, Regarding recent voreppe tinderbox failure [1], it seems that at least 2 methods are needed: * basegfx::unotools::UnoPolyPolygon::getPolyPolygonUnsafe() const * basegfx::fround -- I'm not sure whether we need all 3 overloaded methods which I found that they've

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 10:30 AM, Korrawit Pruegsanusak wrote: What should we do next? (partially) revert it? or ...? :-) Yes, please just revert what is used by Windows-only canvas/source/directx but got erroneously removed. Stephan ___ LibreOffice mailing

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Korrawit Pruegsanusak
Hello Stephan, On Wed, Feb 8, 2012 at 17:11, Stephan Bergmann sberg...@redhat.com wrote: Yes, please just revert what is used by Windows-only canvas/source/directx but got erroneously removed. Thanks! Done at

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Michael Meeks
On Wed, 2012-02-08 at 21:22 +0700, Korrawit Pruegsanusak wrote: On Wed, Feb 8, 2012 at 17:11, Stephan Bergmann sberg...@redhat.com wrote: Yes, please just revert what is used by Windows-only canvas/source/directx but got erroneously removed. Thanks! Done at

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 06:31 PM, Michael Meeks wrote: And of course, it'd be good to add some #ifndef UNX stuff around that I suppose, so it is not compiled and doesn't re-appear on the unusedcode.easy list in future :-) I guess one can argue both ways here. A feature-complete basegfx library

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Caolán McNamara
On Wed, 2012-02-08 at 20:33 +0100, Stephan Bergmann wrote: I guess one can argue both ways here. A feature-complete basegfx library where some features happen to only be used in certain scenarios, but the library itself clean of scenario-differentiating ifdef hacks vs. micro-level

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something from callcatcher. [...] write unit tests that call it [...] I somehow like that solution best. :) Stephan ___ LibreOffice mailing list