Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Rene Engelhard
Hi, On Sun, Aug 12, 2018 at 04:58:52PM +0300, Maxim Monastirsky wrote: > On Sun, 2018-08-12 at 14:43 +0200, Rene Engelhard wrote: > > so vcl/source/app/IconThemeSelector.cxx > > > > > installedThemes) > > > { > > > if (!installedThemes.empty()) { > > > return installedThemes.front().

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Maxim Monastirsky
On Sun, 2018-08-12 at 14:43 +0200, Rene Engelhard wrote: > so vcl/source/app/IconThemeSelector.cxx > > > installedThemes) > > { > > if (!installedThemes.empty()) { > > return installedThemes.front().GetThemeId(); > > } > > else { > > return FALLBACK_ICON_THEME_ID; > >

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Rene Engelhard
Hi, On Sun, Aug 12, 2018 at 12:09:42PM +0300, Maxim Monastirsky wrote: > On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote: > > > I think you should use colibre *instead* of tango. My understanding > > > is > > > > No, that looks too much Windows'ishy to me. > > Ah, OK. In this case it mig

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Heiko Tietze
Tango actually got the remaining ICP s, or should at least. I will check it when back next Thursday. On 12 August 2018 11:09:42 CEST, Maxim Monastirsky wrote: >On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote: >> > I think you should use colibre *instead* of tango. My understanding >> > i

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Maxim Monastirsky
On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote: > > I think you should use colibre *instead* of tango. My understanding > > is > > No, that looks too much Windows'ishy to me. Ah, OK. In this case it might make sense to do an upstream patch to copy these icons to tango, as we already did

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Rene Engelhard
On Sun, Aug 12, 2018 at 10:44:21AM +0300, Maxim Monastirsky wrote: > only karasa_jaga has these images, but it isn't part of the fallback > mechanism as you saw. ... and this one isn't packaged by me anyway. Didn't see a need and didn't want to have months of delay for approving the new package. (

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Rene Engelhard
Hi, On Sun, Aug 12, 2018 at 10:44:21AM +0300, Maxim Monastirsky wrote: > On Sun, 2018-08-12 at 08:46 +0200, Rene Engelhard wrote: > > Will tango work there, > > No, as it doesn't have the radio/checkboxes images. Besides colibre, sigh, OK, so I did https://salsa.debian.org/libreoffice-team/libre

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Maxim Monastirsky
On Sun, 2018-08-12 at 08:46 +0200, Rene Engelhard wrote: > Will tango work there, No, as it doesn't have the radio/checkboxes images. Besides colibre, only karasa_jaga has these images, but it isn't part of the fallback mechanism as you saw. > or do I really need to add a extra > Depends: on coli

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Rene Engelhard
On Sun, Aug 12, 2018 at 08:56:23AM +0200, Heiko Tietze wrote: >Fallback was reworked. And Tango should also be complete in 6.1 after >copying the remaining icons from Galaxy So we should update the second case also to tango? Build with that change for testing just running. Regards, Rene

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-11 Thread Noel Grandin
​ ​Don't the icon themes have weird links files that allow each icon theme to copy icons from other themes? Perhaps just a matter of updating those files so those other themes get the necessary checkbox, etc icons?​ ___ LibreOffice mailing list LibreOffi

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-11 Thread Heiko Tietze
Fallback was reworked. And Tango should also be complete in 6.1 after copying the remaining icons from Galaxy -- Sent from my Android device with K-9 Mail. Please excuse my brevity.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-11 Thread Rene Engelhard
Hi again, On Sun, Aug 12, 2018 at 08:25:19AM +0200, Rene Engelhard wrote: > Or does it use an other fallback= Ah, vcl/source/image/ImplImageTree.cxx: OUString ImplImageTree::fallbackStyle(const OUString& rsStyle) { OUString sResult; if (rsStyle == "colibre" || rsStyle == "helpimg")

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-11 Thread Rene Engelhard
Hi, On Sun, Aug 12, 2018 at 12:41:02AM +0300, Maxim Monastirsky wrote: > The non-native code path inside vcl uses images from the icon theme to > draw radio/checkboxes. The problem is that not all icon themes have all > needed images, so e.g. Elementary does not have them but Colibre does. Eh, ok

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-11 Thread Maxim Monastirsky
Hi Rene, The non-native code path inside vcl uses images from the icon theme to draw radio/checkboxes. The problem is that not all icon themes have all needed images, so e.g. Elementary does not have them but Colibre does. In practice, all you need is to always have Colibre installed, as it's defi

broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-10 Thread Rene Engelhard
On Tue, Aug 07, 2018 at 12:47:04PM +0200, Heiko Tietze wrote: > No problem here. But haphazardly I could imagine it's the expander icon (see > screenshot) that is not painted for some reasons ending up in a zero/one > pixel height for the first line. This is my setup: How would I debug this? gtk