Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Lubos Lunak
On Thursday 12 of April 2012, Matúš Kukan wrote: Maybe it is better to just let check target depend on build target ? In general. Do you mean making the toplevel targets depend on each other, or also in each module? If this is meant to be also for all modules, wouldn't this possibly still

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Lubos Lunak
On Thursday 12 of April 2012, Rene Engelhard wrote: On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote: Or do people use make check with demand to build only what is necessary for tests and nothing more ? Well, make check is for after a successful build to check the result, no?

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Rene Engelhard
On Fri, Apr 13, 2012 at 04:35:27PM +0200, Lubos Lunak wrote: On Thursday 12 of April 2012, Rene Engelhard wrote: On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote: Or do people use make check with demand to build only what is necessary for tests and nothing more ? Well, make

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Matúš Kukan
On 13 April 2012 16:32, Lubos Lunak l.lu...@suse.cz wrote: On Thursday 12 of April 2012, Matúš Kukan wrote: Maybe it is better to just let check target depend on build target ? In general.  Do you mean making the toplevel targets depend on each other, or also in each module? I mean to add

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Lubos Lunak
On Friday 13 of April 2012, Rene Engelhard wrote: On Fri, Apr 13, 2012 at 04:35:27PM +0200, Lubos Lunak wrote: On Thursday 12 of April 2012, Rene Engelhard wrote: On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote: Or do people use make check with demand to build only what is

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Lubos Lunak
On Friday 13 of April 2012, Matúš Kukan wrote: On 13 April 2012 16:32, Lubos Lunak l.lu...@suse.cz wrote: On Thursday 12 of April 2012, Matúš Kukan wrote: Maybe it is better to just let check target depend on build target ? In general.  Do you mean making the toplevel targets depend on

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Matúš Kukan
On 13 April 2012 18:38, Lubos Lunak l.lu...@suse.cz wrote: On Friday 13 of April 2012, Matúš Kukan wrote: Note that the modules' dependencies (in the sense: first build sal then cppu) are written in module/prj/build.lst and build.pl reads them.  Does this mean that if there is a build race

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-13 Thread Matúš Kukan
Hi all, On 13 April 2012 18:21, Matúš Kukan matus.ku...@gmail.com wrote: Bjoern, what do you think about attached patch ? I left subsequentcheck untouched for now. Oh no, it won't work in new gbuild world where we can do: make -rs -j 4 $(WORKDIR)/Module/check/sw or anything, from clean. That's

Re: check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-12 Thread Rene Engelhard
On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote: Maybe it is better to just let check target depend on build target ? No? Or do people use make check with demand to build only what is necessary for tests and nothing more ? Well, make check is for after a successful build to check

check : build dependency (was: Re: what exactly needs localedata_en library ?)

2012-04-12 Thread Matúš Kukan
On 12 April 2012 16:14, Eike Rathke er...@redhat.com wrote: On Thursday, 2012-04-12 13:33:38 +0200, Lubos Lunak wrote:  As far as I can see, it is the i18npool library that dlopens localedata_en (i18npool/source/localedata/localedata.cxx), so I think the best way to express this dependency is