[PUSHED] convert setup_native to gbuild and add to tail_build

2013-02-09 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2063 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2063 To unsubscribe, vi

Re: convert setup_native to gbuild and add to tail_build

2013-02-13 Thread Niko Rönkkö
Hi! This commit breaks my Mac build with error message: Unrecognized option: -p Usage: ulfconv [-o ] [-t ] [] Problem seems to be on line 22 in CustomTarget_mac.mk: http://opengrok.libreoffice.org/xref/core/setup_native/CustomTarget_mac.mk#22 -- RN __

Re: convert setup_native to gbuild and add to tail_build

2013-02-14 Thread Peter Foley
Niko, I just pushed a fix. Can you see if it works now? Thanks, Peter -Original Message- From: Niko Rönkkö Sent: Wednesday, February 13, 2013 10:14 AM To: libreoffice-dev Cc: pefol...@verizon.net Subject: Re: convert setup_native to gbuild and add to tail_build Hi! This commit

Re: [PATCH] convert setup_native to gbuild and add to tail_build

2013-02-11 Thread Andras Timar
Hi Peter, On Sat, Feb 9, 2013 at 3:54 PM, Peter Foley (via Code Review) wrote: > Hi, > > I have submitted a patch for review: > > https://gerrit.libreoffice.org/2063 > I tested you patch and it does not work for me. Windows Installer cannot execure any of the CustomActions. E.g.: MSI (c) (9C

Re: [PATCH] convert setup_native to gbuild and add to tail_build

2013-02-12 Thread Peter Foley
Andras, I just pushed a patch that should fix it. Could you test it? Thanks, Peter -Original Message- From: Andras Timar Sent: Monday, February 11, 2013 7:37 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert setup_native to gbuild and add to tail_build Hi Peter

Re: [PATCH] convert setup_native to gbuild and add to tail_build

2013-02-13 Thread Andras Timar
fice Subject: Re: [PATCH] convert > setup_native to gbuild and add to tail_build > Hi Peter, > > On Sat, Feb 9, 2013 at 3:54 PM, Peter Foley (via Code Review) > wrote: >> >> Hi, >> >> I have submitted a patch for review: >> >> https://gerrit.l

[SOLVED] Re: convert setup_native to gbuild and add to tail_build

2013-02-13 Thread Niko Rönkkö
Peter, Can you see if it works now? Yes, it works now, thanks. -- RN ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] convert setup_native to gbuild and add to tail_build

2013-02-14 Thread Peter Foley
PATCH] convert setup_native to gbuild and add to tail_build Hi Peter, Thanks, it was a good fix, I did the same for all CustomActions. Just one more problem: now MSVCRT is linked dinamically. It is not good, because MSVCRT is not part of the default Windows installation. We need to link it statically

Re: [PATCH] convert setup_native to gbuild and add to tail_build

2013-02-17 Thread Andras Timar
why it changed or what the problem is. > Do you know how I would force msvcrt to be linked staticly? > > Thanks, > > Peter > > -Original Message- From: Andras Timar Sent: Wednesday, February 13, > 2013 6:13 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert