core.git: 2 commits - sd/source sfx2/source stoc/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/view/DocumentRenderer.cxx |    3 ---
 sfx2/source/dialog/dinfdlg.cxx         |    3 +--
 stoc/source/invocation/invocation.cxx  |    3 +--
 3 files changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 0afed1a48158cfc088b9cb60e609dac5515166fa
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Dec 9 20:28:36 2023 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Dec 10 11:56:48 2023 +0100

    cid#1546285 this copy is dead-code
    
    since:
    
    commit 9be3c3724cd0dd2409ac1ebba88d30e04127272c
    Date:   Mon Aug 17 17:34:28 2009 +0000
    
        #i92516# handle pageoffset in vcl instead of application
    
    Change-Id: I9548d15d57284a2d826239de57d0d1650bac4b82
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160518
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sd/source/ui/view/DocumentRenderer.cxx 
b/sd/source/ui/view/DocumentRenderer.cxx
index c9bed876e72f..c7587a1d2d40 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -1867,9 +1867,6 @@ private:
 
         SetupPaperOrientation(ePageKind, rInfo);
 
-        MapMode aMap (rInfo.maMap);
-        rInfo.maMap = aMap;
-
         if (mpOptions->IsBooklet())
             PrepareBooklet(ePageKind, rInfo);
         else
commit 936fa218ddff67643b4daa6b6b746ac3bc897f06
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Dec 9 20:23:07 2023 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Dec 10 11:56:40 2023 +0100

    cid#1546298 COPY_INSTEAD_OF_MOVE
    
    and
    
    cid#1546297 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I8fbb2bb1692cc822a79652312c6268379226a9c3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160517
    Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 26f34882ec42..8ae4420769d4 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -2469,8 +2469,7 @@ Sequence< document::CmisProperty > 
CmisPropertiesWindow::GetCmisProperties() con
                 sal_Int32 k = 0;
                 for ( const auto& rxValue : pLine->m_aValues )
                 {
-                    OUString sValue( rxValue->m_xValueEdit->get_text() );
-                    seqValueRange[k] = sValue;
+                    seqValueRange[k] = rxValue->m_xValueEdit->get_text();
                     ++k;
                 }
                 aPropertiesSeqRange[i].Value <<= seqValue;
diff --git a/stoc/source/invocation/invocation.cxx 
b/stoc/source/invocation/invocation.cxx
index 1b119085cb84..314b63104fc7 100644
--- a/stoc/source/invocation/invocation.cxx
+++ b/stoc/source/invocation/invocation.cxx
@@ -936,8 +936,7 @@ void Invocation_Impl::fillInfoForMethod
     for( sal_Int32 i = 0 ; i < nParamCount ; i++ )
     {
         Reference< XIdlClass > xParamClass = pInfo[i].aType;
-        Type aParamType( xParamClass->getTypeClass(), xParamClass->getName() );
-        pParamTypes[ i ] = aParamType;
+        pParamTypes[ i ] = Type(xParamClass->getTypeClass(), 
xParamClass->getName());
         pParamModes[ i ] = pInfo[i].aMode;
     }
 }