Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Noel Grandin
On 2012-03-22 15:19, Stephan Bergmann wrote: For code not below comphelper that only has a global XMultiServiceFactory at hand, but rather needs an XComponentContext (e.g., to pass it into a new-style service constructor), comphelper::getComponentContext (comphelper/processfactory.hxx) can

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Stephan Bergmann
On 03/23/2012 09:09 AM, Noel Grandin wrote: I'm needing to modify some code in the UCB module, but I get linking errors because I'm referencing comphelper. Do I need to modify the makefile or is this one of those modules that are below comphelper? Module ucb already depends on module

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Tor Lillqvist
What is a component context btw? Are there many kinds of such, or many instances of the same kind in a typical running LO? In what kind of environments/platforms/circumstances would the various kinds exist? --tml ___ LibreOffice mailing list

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Noel Grandin
On 2012-03-23 10:13, Stephan Bergmann wrote: On 03/23/2012 09:09 AM, Noel Grandin wrote: I'm needing to modify some code in the UCB module, but I get linking errors because I'm referencing comphelper. Do I need to modify the makefile or is this one of those modules that are below comphelper?

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Miklos Vajna
On Fri, Mar 23, 2012 at 10:16:12AM +0200, Tor Lillqvist t...@iki.fi wrote: What is a component context btw? Are there many kinds of such, or many instances of the same kind in a typical running LO? In what kind of environments/platforms/circumstances would the various kinds exist? As far as I

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Stephan Bergmann
On 03/23/2012 09:16 AM, Tor Lillqvist wrote: What is a component context btw? Are there many kinds of such, or many instances of the same kind in a typical running LO? In what kind of environments/platforms/circumstances would the various kinds exist? There's typically just one. (That's why

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Stephan Bergmann
On 03/23/2012 09:18 AM, Noel Grandin wrote: /home/noel/libo/workdir/unxlngx6.pro/CxxObject/ucb/source/ucp/ftp/ftpdynresultset.o:ftpdynresultset.cxx:function ftp::DynamicResultSet::DynamicResultSet(com::sun::star::uno::Referencecom::sun::star::lang::XMultiServiceFactory const,

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-23 Thread Michael Stahl
On 23/03/12 10:04, Stephan Bergmann wrote: On 03/23/2012 09:16 AM, Tor Lillqvist wrote: What is a component context btw? Are there many kinds of such, or many instances of the same kind in a typical running LO? In what kind of environments/platforms/circumstances would the various kinds exist?

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Noel Grandin
That was just about to be my next question :-) How do I decide whether to change the constructor to take XComponentContext or XMultiComponentFactory? On 2012-03-22 14:36, Stephan Bergmann wrote: On 03/22/2012 01:11 PM, Noel Grandin wrote: Diff attached. [...] @@ -258,12 +259,7 @@ void

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Stephan Bergmann
On 03/22/2012 01:56 PM, Noel Grandin wrote: How do I decide whether to change the constructor to take XComponentContext or XMultiComponentFactory? It is always XComponentContext that you want to move around, never XMultiComponentFactory. In the old days, there was just XMultiServiceFactory,

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Tor Lillqvist
What does the string SMgr that apprears in the names of many variables/fields/parameters that are of type ReferenceXMultiComponentFactory (or XMutiServiceFactory) mean? Was there something in the even older days called service manager? --tml ___

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Stephan Bergmann
On 03/22/2012 02:26 PM, Tor Lillqvist wrote: What does the string SMgr that apprears in the names of many variables/fields/parameters that are of type ReferenceXMultiComponentFactory (or XMutiServiceFactory) mean? Was there something in the even older days called service manager? I think that

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Noel Grandin
Hi Great explanation. In order to limit the knock-on effect from my change (I'm already up to about 12 files, and it just keeps spreading), I need to be able to convert an XComponentContext back into a XMultiServiceFactory. How do I do that? Thanks, Noel Grandin

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-22 Thread Stephan Bergmann
On 03/22/2012 03:13 PM, Noel Grandin wrote: In order to limit the knock-on effect from my change (I'm already up to about 12 files, and it just keeps spreading), I need to be able to convert an XComponentContext back into a XMultiServiceFactory. How do I do that?

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Stephan Bergmann
On 03/21/2012 06:46 AM, Noel Grandin wrote: All I did was modify Engine.idl to read published service Engine : com::sun::star::script::XEngine; So you did not modify offapi/type_reference/types.rdb as described at

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Stephan Bergmann
On 03/21/2012 08:38 AM, Stephan Bergmann wrote: On 03/21/2012 06:46 AM, Noel Grandin wrote: All I did was modify Engine.idl to read published service Engine : com::sun::star::script::XEngine; So you did not modify offapi/type_reference/types.rdb as described at

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Noel Grandin
Hi I was just using Engine as a testbed, but yes, I should probably pick a non-deprecated one :-) I modified types.rdb using the script referenced there, but still got an error. Regards, Noel Grandin On Wed, Mar 21, 2012 at 09:46, Stephan Bergmann sberg...@redhat.com wrote: On 03/21/2012

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Stephan Bergmann
On 03/21/2012 01:06 PM, Noel Grandin wrote: I modified types.rdb using the script referenced there, but still got an error. That's why I asked for a patch, to see what's wrong with your modified offapi/type_reference/types.rdb. (Btw, you did replace the com.sun.star.script.Converter from

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Noel Grandin
On Wed, Mar 21, 2012 at 14:44, Stephan Bergmann sberg...@redhat.com wrote: offapi/type_reference/types.rdb.  (Btw, you did replace the com.sun.star.script.Converter from the example with your actual com.sun.star.script.Engine, did you?) Aaah, that would be the problem. I assumed that because

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-21 Thread Noel Grandin
Thanks. But you know that no matter how good you make the instructions, users will __always__ find a way to misread them :-) On Wed, Mar 21, 2012 at 17:31, Stephan Bergmann sberg...@redhat.com wrote: On 03/21/2012 04:19 PM, Noel Grandin wrote: On Wed, Mar 21, 2012 at 14:44, Stephan

fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-20 Thread Noel Grandin
Hi Following instructions here: https://bugs.freedesktop.org/show_bug.cgi?id=46808 and here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=30a7a6189916396c7c2ee9bbd5861ad19bf7724c I started with the Engine service, but after running the instructions referenced in the git commit, I'm

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-20 Thread Stephan Bergmann
On 03/20/2012 12:55 PM, Noel Grandin wrote: I started with the Engine service, but after running the instructions referenced in the git commit, I'm still getting: SERVICE: /UCR/com/sun/star/script/Engine service1 contains 1 more references as service2 incompatible change: Reference 0

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

2012-03-20 Thread Noel Grandin
All I did was modify Engine.idl to read published service Engine : com::sun::star::script::XEngine; On Tue, Mar 20, 2012 at 17:00, Stephan Bergmann sberg...@redhat.com wrote: On 03/20/2012 12:55 PM, Noel Grandin wrote: I started with the Engine service, but after running the