On 10.08.2012 17:50, Bjoern Michaelsen wrote:
rationale: We are now sending a mail to the dev-list for every patch anyway.
It does not seem to send a mail to the dev-list, at least with
[CHERRYPICK]. I received:
From: Gerrit ger...@gerrit.libreoffice.org
CC: Ivan Timofeev
2012-08-10 13:09:19,202 INFO Handling incoming mail from Terrence Enger
ten...@iseries-guru.com
2012-08-10 13:09:19,202 INFO subject: '[ONGERRIT] leaked ODBC statement
handles'
2012-08-10 13:09:19,202 INFO executing command: None, branch: master,
commit: leaked
2012-08-10 13:09
ten...@iseries-guru.com
2012-08-10 13:09:19,202 INFO subject: '[ONGERRIT] leaked ODBC statement
handles'
2012-08-10 13:09:19,202 INFO executing command: None, branch: master,
commit: leaked
2012-08-10 13:09:19,202 ERROREmailCommand instance has no attribute
'do_None
--
View this message in context:
http://nabble.documentfoundation.org/CHANGEUPLOAD-FAILED-ONGERRIT-leaked-ODBC-statement-handles-tp4000433p4000479.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice
On Wed, Jul 18, 2012 at 03:09:55PM -0400, Terrence Enger wrote:
Patch attached. I think it as we discussed.
Thanks. Applied pushed to master.
I split your patch into three commits:
- avoid freeing the NULL handle
- ODBMetaDataRS ctor: abort if statement handle allocation failed
- stop
On Thu, 2012-07-19 at 07:18 -0400, Terrence Enger wrote:
Again, thank you for all the help you have given me along the way to
this small code contribution.
Hey ! this really helps - it's really great to have people tackling
bugs - there are really plenty to go around :-)
Patch attached. I think it as we discussed.
I do not have OpenId, so I am not registered with gerrit, so I think
that I shall not be able to enter your as reviewer. Sorry to be
awkward.
Thank you for your patience with me through all the to-ing and fro-ing
so far.
Terry.
From
at 05:15 +0200, Lionel Elie Mamane wrote:
On Tue, Jul 17, 2012 at 03:46:14PM -0400, Terrence Enger wrote:
On Tue, 2012-07-17 at 19:08 +0200, Lionel Elie Mamane wrote:
On Mon, Jul 16, 2012 at 10:15:02PM -0400, Terrence Enger wrote:
I am chasing some leaked ODBC statement handles.
I see
On Wed, Jul 18, 2012 at 09:55:21AM -0400, Terrence Enger wrote:
(*) Do you agree that ODatabaseMetaDataResultSet ctor should warn if
it does not get a statement handle?
It never gets a statement handle as an argument, it allocates it by
calling _pConnection-createStatementHandle(). If the
On Mon, Jul 16, 2012 at 10:15:02PM -0400, Terrence Enger wrote:
I am chasing some leaked ODBC statement handles.
I see that ODatabaseMetaDataResultSet.cxx takes care *not* to free a
statement handle which has not been subjected to one of 13 member
functions with names starting open
I am sorry for the length. I hope some of it is interesting.
On Tue, 2012-07-17 at 19:08 +0200, Lionel Elie Mamane wrote:
On Mon, Jul 16, 2012 at 10:15:02PM -0400, Terrence Enger wrote:
I am chasing some leaked ODBC statement handles.
I see that ODatabaseMetaDataResultSet.cxx takes care
On Tue, Jul 17, 2012 at 03:46:14PM -0400, Terrence Enger wrote:
On Tue, 2012-07-17 at 19:08 +0200, Lionel Elie Mamane wrote:
On Mon, Jul 16, 2012 at 10:15:02PM -0400, Terrence Enger wrote:
I am chasing some leaked ODBC statement handles.
I see that ODatabaseMetaDataResultSet.cxx takes care
Greetings,
I am chasing some leaked ODBC statement handles.
I see that ODatabaseMetaDataResultSet.cxx takes care *not* to free a
statement handle which has not been subjected to one of 13 member
functions with names starting open Questions arising ...
(1) Why should this protection
13 matches
Mail list logo
