Re: long paras + tools/string.hxx

2014-01-22 Thread Olivier Hallot
Em 22-01-2014 13:35, Caolán McNamara escreveu: > On Tue, 2014-01-21 at 11:15 -0200, Olivier Hallot wrote: >> Em 21-01-2014 11:12, Caolán McNamara escreveu: >>> Dunno. Rather doubt it though. How to reproduce ? >> Just save a file with one longpara (master as old as last friday). > > Fixed now with

Re: long paras + tools/string.hxx

2014-01-22 Thread Caolán McNamara
On Tue, 2014-01-21 at 11:15 -0200, Olivier Hallot wrote: > Em 21-01-2014 11:12, Caolán McNamara escreveu: > > Dunno. Rather doubt it though. How to reproduce ? > Just save a file with one longpara (master as old as last friday). Fixed now with http://cgit.freedesktop.org/libreoffice/core/commit/?i

Re: long paras + tools/string.hxx

2014-01-21 Thread Caolán McNamara
On Tue, 2014-01-21 at 14:20 +0100, Matteo Casalin wrote: > I'm (very) slowly working on this. Indeed there are some obscure (to > me) points in which I don't know how to proceed. I will push to gerrit > for review, just to have some cross checks, and the first bunch of > patches should be ready in

Re: long paras + tools/string.hxx

2014-01-21 Thread Matteo Casalin
Hi all, On Tue, 21 Jan 2014 12:10:40 + Caolán McNamara wrote: > The 16 bit length limitation in writer is now removed towards 4.3. > > The 16 bit paragraph length limit in editeng still remains, editeng > mixes freely sal_uInt16 with xub_StrLen and has a pile of hard-coded > 0x here and

Re: long paras + tools/string.hxx

2014-01-21 Thread Olivier Hallot
Hi Caolán Em 21-01-2014 11:12, Caolán McNamara escreveu: > On Tue, 2014-01-21 at 10:21 -0200, Olivier Hallot wrote: >> Hi Caolán >> >> Em 21-01-2014 10:10, Caolán McNamara escreveu: >>> Also, note there is a hidden limit in tools/stream.hxx of 0xFFFE in >>> things like ReadLine and ReadByteStringL

Re: long paras + tools/string.hxx

2014-01-21 Thread Caolán McNamara
On Tue, 2014-01-21 at 10:21 -0200, Olivier Hallot wrote: > Hi Caolán > > Em 21-01-2014 10:10, Caolán McNamara escreveu: > > Also, note there is a hidden limit in tools/stream.hxx of 0xFFFE in > > things like ReadLine and ReadByteStringLine and their callers. > > Is this the reason for the memory

Re: long paras + tools/string.hxx

2014-01-21 Thread Olivier Hallot
Hi Caolán Em 21-01-2014 10:10, Caolán McNamara escreveu: > Also, note there is a hidden limit in tools/stream.hxx of 0xFFFE in > things like ReadLine and ReadByteStringLine and their callers. Is this the reason for the memory leak that I get while saving a longpara file? It crashes my Linux. --

long paras + tools/string.hxx

2014-01-21 Thread Caolán McNamara
The 16 bit length limitation in writer is now removed towards 4.3. The 16 bit paragraph length limit in editeng still remains, editeng mixes freely sal_uInt16 with xub_StrLen and has a pile of hard-coded 0x here and there which makes it tricky to see at a glance which values are string lengths