Re: ppt import(?) bug hunting

2020-09-14 Thread Dr. David Alan Gilbert
* Caol?n McNamara (caol...@redhat.com) wrote: > On Sun, 2020-09-13 at 17:58 +0100, Dr. David Alan Gilbert wrote: > > > OK great, I'll look at sending a fix over the weekend. > > > > Done; https://gerrit.libreoffice.org/c/core/+/102542/1 > > > > https://gerrit.libreoffice.org/c/core/+/102590/1 >

Re: ppt import(?) bug hunting

2020-09-14 Thread Caolán McNamara
On Sun, 2020-09-13 at 17:58 +0100, Dr. David Alan Gilbert wrote: > > OK great, I'll look at sending a fix over the weekend. > > Done; https://gerrit.libreoffice.org/c/core/+/102542/1 > > https://gerrit.libreoffice.org/c/core/+/102590/1 looks good to me, merged now, thanks for that

Re: ppt import(?) bug hunting

2020-09-13 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (d...@treblig.org) wrote: > * Caol?n McNamara (caol...@redhat.com) wrote: > > On Sun, 2020-09-06 at 16:30 +0100, Dr. David Alan Gilbert wrote: > > > So I'm now even more convinced that the right thing to do is just > > > nuke these two lines > > > > That does look

Re: ppt import(?) bug hunting

2020-09-09 Thread Dr. David Alan Gilbert
* Caol?n McNamara (caol...@redhat.com) wrote: > On Sun, 2020-09-06 at 16:30 +0100, Dr. David Alan Gilbert wrote: > > So I'm now even more convinced that the right thing to do is just > > nuke these two lines > > That does look convincing, that it was left over and accidentally not > updated at

Re: ppt import(?) bug hunting

2020-09-08 Thread Caolán McNamara
On Sun, 2020-09-06 at 16:30 +0100, Dr. David Alan Gilbert wrote: > So I'm now even more convinced that the right thing to do is just > nuke these two lines That does look convincing, that it was left over and accidentally not updated at 8a64144fddde61dd050da4cb93b4a7242a495bb2 to the new reality

Re: ppt import(?) bug hunting

2020-09-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (d...@treblig.org) wrote: > * Dennis Roczek (dennisroc...@libreoffice.org) wrote: > > Hi Dave, > > > > Am 04.09.2020 um 16:48 schrieb Dr. David Alan Gilbert: > > > * Dennis Roczek (dennisroc...@libreoffice.org) wrote: > > >> Hi Dave, > > > > > > Thanks for the reply, > >

Re: ppt import(?) bug hunting

2020-09-04 Thread Dennis Roczek
Hi Dave, Am 04.09.2020 um 16:48 schrieb Dr. David Alan Gilbert: > * Dennis Roczek (dennisroc...@libreoffice.org) wrote: >> Hi Dave, > > Thanks for the reply, > >> Am 04.09.2020 um 02:52 schrieb Dr. David Alan Gilbert: >>> That code predates the move of the msfilters into that directory - >>> is

Re: ppt import(?) bug hunting

2020-09-04 Thread Dr. David Alan Gilbert
* Dennis Roczek (dennisroc...@libreoffice.org) wrote: > Hi Dave, > > Am 04.09.2020 um 16:48 schrieb Dr. David Alan Gilbert: > > * Dennis Roczek (dennisroc...@libreoffice.org) wrote: > >> Hi Dave, > > > > Thanks for the reply, > > > >> Am 04.09.2020 um 02:52 schrieb Dr. David Alan Gilbert: > >>>

Re: ppt import(?) bug hunting

2020-09-04 Thread Dr. David Alan Gilbert
* Dennis Roczek (dennisroc...@libreoffice.org) wrote: > Hi Dave, Thanks for the reply, > Am 04.09.2020 um 02:52 schrieb Dr. David Alan Gilbert: > > That code predates the move of the msfilters into that directory - > > is there a tree with history older than that still around so I can > > find

Re: ppt import(?) bug hunting

2020-09-04 Thread Dennis Roczek
Hi Dave, Am 04.09.2020 um 02:52 schrieb Dr. David Alan Gilbert: > That code predates the move of the msfilters into that directory - > is there a tree with history older than that still around so I can > find the bug/history/reasoning of where that pair of lines came from? Yep, there is:

ppt import(?) bug hunting

2020-09-04 Thread Dr. David Alan Gilbert
Hi, I've been poking about trying to understand a pet bug: https://bugs.documentfoundation.org/show_bug.cgi?id=49856 which is related to bullets in documents that go through a ppt export->import cycle; I've not yet quite convinced myself of whether it's an export or import bug, but I'm down to