Re: recent KahanSum change causes a new test failure on ppc64le

2023-10-15 Thread Eike Rathke
Hi Dan, On Tuesday, 2023-09-05 18:53:37 +0200, Dan Horák wrote: > seems the recent change [1] to KahanSum handling causes a test failure > on ppc64le. That should be fixed now with https://gerrit.libreoffice.org/c/core/+/156899 and cherry-picks are pending for 7-6, 7-5 and 7-5-8. Unfortunately

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-13 Thread Stephan Bergmann
On 9/13/23 13:58, Eike Rathke wrote: On Wednesday, 2023-09-13 13:45:36 +0200, Dan Horák wrote: It would be worth a try to simply call executeFast() only if SC_USE_SSE2 is defined, so the failing platforms skip executeUnrolled(), here

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-13 Thread Eike Rathke
Hi Dan, On Wednesday, 2023-09-13 13:45:36 +0200, Dan Horák wrote: > > It would be worth a try to simply call executeFast() only if SC_USE_SSE2 > > is defined, so the failing platforms skip executeUnrolled(), here > >

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-13 Thread Dan Horák
On Wed, 13 Sep 2023 13:06:10 +0200 Eike Rathke wrote: > Hi, > > On Thursday, 2023-09-07 11:36:33 +0200, Stephan Bergmann wrote: > > > On 9/7/23 08:25, Dan Horák wrote: > > > On Thu, 7 Sep 2023 08:16:28 +0200 > > > Stephan Bergmann wrote: > > > > On 9/5/23 18:53, Dan Horák wrote: > > > > >

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-13 Thread Eike Rathke
Hi, On Thursday, 2023-09-07 11:36:33 +0200, Stephan Bergmann wrote: > On 9/7/23 08:25, Dan Horák wrote: > > On Thu, 7 Sep 2023 08:16:28 +0200 > > Stephan Bergmann wrote: > > > On 9/5/23 18:53, Dan Horák wrote: > > > > seems the recent change [1] to KahanSum handling causes a test failure > > >

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-13 Thread Dan Horák
On Thu, 7 Sep 2023 11:36:33 +0200 Stephan Bergmann wrote: > On 9/7/23 08:25, Dan Horák wrote: > > On Thu, 7 Sep 2023 08:16:28 +0200 > > Stephan Bergmann wrote: > >> On 9/5/23 18:53, Dan Horák wrote: > >>> seems the recent change [1] to KahanSum handling causes a test failure > >>> on ppc64le. >

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-07 Thread Stephan Bergmann
On 9/7/23 08:25, Dan Horák wrote: On Thu, 7 Sep 2023 08:16:28 +0200 Stephan Bergmann wrote: On 9/5/23 18:53, Dan Horák wrote: seems the recent change [1] to KahanSum handling causes a test failure on ppc64le. Running scope as unit:

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-07 Thread Dan Horák
On Wed, 6 Sep 2023 16:32:49 +0200 Xisco Fauli wrote: > Hello Dan, > > That test is indeed testing the patch you are reverting, so it's > expected to fail. It shouldn't fail if you also revert > 2ac7d339a97efa638124c2862551e0876487833b. thanks, it makes sense (and helps) :-)

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-07 Thread Dan Horák
On Thu, 7 Sep 2023 08:16:28 +0200 Stephan Bergmann wrote: > On 9/5/23 18:53, Dan Horák wrote: > > seems the recent change [1] to KahanSum handling causes a test failure > > on ppc64le. > > > > Running scope as unit: > >

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-07 Thread Stephan Bergmann
On 9/5/23 18:53, Dan Horák wrote: seems the recent change [1] to KahanSum handling causes a test failure on ppc64le. Running scope as unit: -home-sharkcz-projects-libreoffice-workdir-CppunitTest-sc_statistical_functions_test.test:20230905152639:2378561.scope [_RUN_]

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-06 Thread Xisco Fauli
Hello Dan, That test is indeed testing the patch you are reverting, so it's expected to fail. It shouldn't fail if you also revert 2ac7d339a97efa638124c2862551e0876487833b. On 6/9/23 15:41, Dan Horák wrote: On Tue, 5 Sep 2023 18:53:37 +0200 Dan Horák wrote: Hello, seems the recent

Re: recent KahanSum change causes a new test failure on ppc64le

2023-09-06 Thread Dan Horák
On Tue, 5 Sep 2023 18:53:37 +0200 Dan Horák wrote: > Hello, > > seems the recent change [1] to KahanSum handling causes a test failure > on ppc64le. > > [1] > https://git.libreoffice.org/core/+/1f8cc7644293e62ad6430bbeec243d3283e478d7 and with the change reverted I am getting a failure in

recent KahanSum change causes a new test failure on ppc64le

2023-09-05 Thread Dan Horák
Hello, seems the recent change [1] to KahanSum handling causes a test failure on ppc64le. Running scope as unit: -home-sharkcz-projects-libreoffice-workdir-CppunitTest-sc_statistical_functions_test.test:20230905152639:2378561.scope [_RUN_]