Re: tests sc_array_functions_test fail due to floating point precision

2017-12-10 Thread Winfried Donkers
Hi Milton, I've also opened the other test documents in sc/qa/unit/data/functions/array/fods/ using LibreOffice. The documents which fail are linest.fods and also logest.fods. The others succeed. If your build completed ignoring these tests (i.e. produced a usable office under ./instdir/), cou

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-09 Thread Milton Vandersloot
Hi Eike On December 7, 2017 at 12:40 PM Eike Rathke wrote: > On Saturday, 2017-12-02 02:47:03 -0500, Milton Vandersloot wrote: > > I've also opened the other test documents in > > sc/qa/unit/data/functions/array/fods/ using LibreOffice. The documents which > > fail are linest.fods and also logest.

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-07 Thread Eike Rathke
Hi Milton, On Saturday, 2017-12-02 02:47:03 -0500, Milton Vandersloot wrote: > I've also opened the other test documents in > sc/qa/unit/data/functions/array/fods/ using LibreOffice. The documents which > fail are linest.fods and also logest.fods. The others succeed. If your build completed ig

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-07 Thread Stephan Bergmann
On 12/02/2017 08:47 AM, Milton Vandersloot wrote: functions_test.cxx:43:Assertion Test name: ArrayFunctionsTest::testArrayFormulasFODS double equality assertion failed - Expected: 1 - Actual : 0 - Delta : 1e-14 The issue seems to be (again) floating point precision. Indeed, I've compiled Li

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-06 Thread Milton Vandersloot
Hi Eike On December 4, 2017 10:22 PM, Eike Rathke wrote: > From what I understood by browsing shortly gcc enables > this by default for -std=gnu* and it can be unset by > #pragma STDC FP_CONTRACT OFF > [...] > Could you try if adding the pragma to include/sal/config.h > helps? I gave it a try but

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-04 Thread Eike Rathke
Hi Milton, On Saturday, 2017-12-02 02:47:03 -0500, Milton Vandersloot wrote: > The issue seems to be (again) floating point precision. Indeed, I've compiled > LibreOffice with FMA (fused multiply-add) instructions, if I disable them, > i.e. passing -ffp-contract=off to GCC, then the tests succe

tests sc_array_functions_test fail due to floating point precision

2017-12-02 Thread Milton Vandersloot
Dear LibreOffice developers I was told to report this bug here[2]. So here we go: The test ArrayFunctionsTest::testArrayFormulasFODS (files sc/qa/unit/functions_test.cxx, sc/qa/unit/functions_array.cxx) fails the test document sc/qa/unit/data/functions/array/fods/linest.fods. Error message in t